Reviews for asymptote
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| awm | 3.15+ds-1 | 1 month, 27 days ago | 1 month, 27 days ago | rejected | 1 month, 27 days ago | Hi, Licensing / DFSG concerns ========================= 1. Files: * license is misattributed as GPL-3+ — upstream is LGPL-3+. debian/copyright:30-32 declares the whole tree as License: GPL-3+, but the upstream README:22-25 states: "All source files in the Asymptote project, unless explicitly noted otherwise, are released under version 3 (or later) of the GNU Lesser General Public License." The shipped LICENSE.LESSER is the LGPL-3 text. The blanket entry should be LGPL-3+, not GPL-3+. (Both are DFSG-free, so this is a documentation error, not a DFSG violation, but it misstates the actual license of the core program.) 2. Vendored third-party components shipped in the .orig tarball but swallowed by Files: * (no dedicated stanza, wrong license label). These directories are present in the source and are not in Files-Excluded (debian/copyright:5-28), yet they get no Files: entry and are therefore covered by the incorrect Files: * GPL-3+: - backports/glew/ (BSD-3-Clause; backports/glew/LICENSE.txt, source backports/glew/src/glew.c) — still shipped even though dyn_link_GLEW.patch makes Debian use the system libglew. - backports/span/ (Boost-1.0; backports/span/LICENSE.txt). - wyhash/ (Unlicense/public domain; wyhash/UNLICENSE.txt). - libatomic_ops/ (MIT core / GPL-2 extensions; libatomic_ops/LICENSE). - cudareflect/ — shipped with no license header on cudareflect/*.cc|.h|cuh|.cu (e.g. cudareflect/main.cc), left undocumented. 3. Non-free JSON "evil" license text remains in the source. LspCpp/third_party/rapidjson/license.txt:45 contains the JSON.org license clause "The Software shall be used for Good, not Evil." The offending bin/jsonchecker code is excluded (debian/copyright:17), and this is handled by the override at debian/source/lintian-overrides:6 (license-problem-json-evil). This is a known, overridden relic rather than shipped non-free code — worth noting but not a live DFSG problem. 4. Bundled/minified asygl.js attribution may be incomplete. debian/copyright:64-66 licenses base/webgl/asygl.js as "Expat or LGPL-3+", but that file bundles gl-matrix code (zlib, per LICENSES-THIRD-PARTY.md:14 and webgl/gl-matrix-license). It is also a prebuilt/minified artifact (overrides at debian/source/lintian-overrides:3,18). While all the actual components are under a DFSG-free license, so the package is DFSG-compliant; the problems are in the accuracy/completeness of debian/copyright. Packaging quality concerns ========================== 5. Disabled patch left in series. debian/patches/series:3 has #honour-source-date-epoch commented out, but the patch file (debian/patches/honour-source-date-epoch) is still present — dead/stale entry that should be removed. 6. Patch Forwarded metadata contradicts the changelog. debian/patches/dyn_link_GLEW.patch and debian/patches/use_system_gc.patch both say Forwarded: yes, but debian/changelog:222/95 record that upstream rejected these suggestions (static linking preferred). They should be marked Forwarded: not-needed / no. 7. Hardcoded parallelism in debian/rules:31. make -j4 asy ignores DEB_BUILD_OPTIONS/nproc instead of letting dh_auto_build manage job count. 8. Dead code in debian/rules:11-13. The commented-out ifeq ($(DEB_HOST_ARCH), hurd-i386) LSPSERVER block is inert leftover. 9. Redundant GC configuration. --enable-gc=system is passed at debian/rules:19 and forced via debian/patches/use_system_gc.patch (configure.ac), so the vendor gc/ is excluded (debian/copyright:26) yet still referenced by debian/clean:27 (gc isn't listed) — the two mechanisms overlap. The most important fix is #1/#2: correct and complete debian/copyright so third-party components are accurately attributed rather than mislabeled as GPL-3+ under the blanket entry. Thanks! | View |
| awm | 3.15+ds-1 | 1 month, 23 days ago | 1 month, 23 days ago | accepted | 1 month, 23 days ago | View |