Reviews for dpp
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Comment |
|---|---|---|---|---|---|
| siretart | 10.1.4+dfsg-1 | 1 day ago | - | accepted | |
| siretart | 10.1.3+dfsg-1 | 9 days ago | 9 days ago | rejected | [note: I noticed that there is a newer commit in salsa that addresses the issues below. Until we have the technical ability to remove packages from the queue, your best option is to reach out to the archive team via mail or irc to have your package manually rejected and then re-upload it] rejected, found the following issues. Not mentioned in debian/copyright at all: cmake/FindFilesystem.cmake 1:# Distributed under the OSI-approved BSD 3-Clause License. See accompanying 2:# file Copyright.txt or https://cmake.org/licensing for details. Inaccurate description in debian/copyrigh, those files are apparently taken from https://webrtc.googlesource.com/src/+/refs/heads/main/modules/rtp_rtcp/source/leb128.cc and claimed as apache 2.0. That's not compliant with the BSD-3 license as outlined at https://webrtc.googlesource.com/src/+/refs/heads/main/LICENSE: src/dpp/dave/leb128.h 5: * SPDX-License-Identifier: Apache-2.0 6: * Copyright 2021 Craig Edwards and D++ contributors 9: * Licensed under the Apache License, Version 2.0 (the "License"); 10: * you may not use this file except in compliance with the License. 11: * You may obtain a copy of the License at 13: * http://www.apache.org/licenses/LICENSE-2.0 16: * distributed under the License is distributed on an "AS IS" BASIS, 18: * See the License for the specific language governing permissions and 19: * limitations under the License. 22: * Copyright (c) 2023 The WebRTC project authors. All Rights Reserved. 24: * Use of this source code is governed by a BSD-style license 25: * that can be found in the LICENSE file in the root of the source src/dpp/dave/leb128.cpp 5: * SPDX-License-Identifier: Apache-2.0 6: * Copyright 2021 Craig Edwards and D++ contributors 9: * Licensed under the Apache License, Version 2.0 (the "License"); 10: * you may not use this file except in compliance with the License. 11: * You may obtain a copy of the License at 13: * http://www.apache.org/licenses/LICENSE-2.0 16: * distributed under the License is distributed on an "AS IS" BASIS, 18: * See the License for the specific language governing permissions and 19: * limitations under the License. 22: * Copyright (c) 2023 The WebRTC project authors. All Rights Reserved. 24: * Use of this source code is governed by a BSD-style license 25: * that can be found in the LICENSE file in the root of the source |