Reviews for dwarfs
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 0.13.0+ds-1 | 1 month, 7 days ago | 1 month, 7 days ago | rejected | 1 month, 6 days ago | `debian/copyright` lists `Copyright: Unknown` for `folly/folly/external/fast-crc32/*`. The files themselves just say `/* Generated by https://github.com/corsix/fast-crc32/ */` and `/* MIT licensed */`, but don't name a copyright holder. Since the Expat license requires reproducing "the above copyright notice", we need to know who that is. Please look up the actual copyright holder from the upstream https://github.com/corsix/fast-crc32/ project and update `debian/copyright`. Separately, a few files under `fbthrift/thrift/lib/java/` are copyrighted by VMware rather than Meta — specifically `ForkJoinPoolScheduler.java`, `ForkJoinPoolSchedulerTest.java`, and `AbstractSchedulerTest.java`, all in `fbthrift/thrift/lib/java/runtime/.../resources/`. They say `Copyright (c) 2017-2021 VMware Inc. or its affiliates` and are Apache-2.0 licensed. The `fbthrift/*` stanza in `debian/copyright` currently only lists Meta Platforms as copyright holder, so VMware needs to be added there too. | View |