Reviews for evolution-data-server
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| awm | 3.62.0-1 | 1 month, 20 days ago | 1 month, 20 days ago | accepted | 1 month, 20 days ago | Hi, My review notes the following issues... 1. **Missing holders in `Files: *`** (lines 8–19): - `src/camel/camel-smime-context.c:2` — `Copyright (C) 1994-2000 Netscape Communications Corporation`; Netscape not listed. This is the same code the old Debian copyright file attributed to Netscape for years, so it was dropped during the DEP-5 conversion, not absent upstream. - `src/camel/camel-autocleanups.h:2` — `(C) 2019 elementary, Inc.`; not listed. - `tests/libedata-book/data-test-utils.{c,h}`, `test-book-cache-utils.{c,h}` — `(C) 2013, Openismus GmbH`; not listed. - `src/calendar/libedata-cal/e-cal-backend-intervaltree.{c,h}`, `tests/libedata-cal/test-intervaltree.c` — SPDX `(C) 2008` with no holder name (contributor Stanislav Slusny); no one to attribute the copyright to in the file list. 2. **`cmake/modules/GObjectIntrospection.cmake:6-10`** is explicitly derived from libical's CMake scripts and says "Redistribution and use is allowed according to the terms of the BSD license. For details see the accompanying COPYING-CMAKE-SCRIPTS file." That file is not shipped, and `debian/copyright` covers the file under `Files: *` → `LGPL-2+`. It should get its own BSD-3-Clause stanza (with text), or the upstream header should be proven wrong. 3. **`docs/index.html:4`** is `SPDX-License-Identifier: LGPL-2.0-only` but falls under `Files: *` → `LGPL-2+`, overstating an "or later" grant. Minor, worth a one-line `Files:` exception or comment. 4. Conversely, `Files: *` lists `2008 Joergen Scheibengruber` (line 12) and `2010-2012 Philip Withnall` (line 15) with no matching copyright line anywhere in the tree (only contributor credits / old-format headers) — likely carried over from the old non-DEP-5 file, harmless but inconsistent with a "converted" file. Note the spelling drift `Gergõ Érdi` (copyright) vs upstream `Gergő Érdi` is cosmetic. You could add these stanzas to debian/copyright to address some of these issues: Files: src/camel/camel-smime-context.c Copyright: 1994-2000 Netscape Communications Corporation License: LGPL-2+ Files: src/camel/camel-autocleanups.h Copyright: 2019 elementary, Inc. License: LGPL-2+ Files: tests/libedata-book/data-test-utils.c ... (full file list above) Copyright: 2013 Openismus GmbH License: LGPL-2+ Files: cmake/modules/GObjectIntrospection.cmake Copyright: 2010 Pino Toscano License: BSD-3-Clause Thanks! | View |