Reviews for faac
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| awm | 2.2-1 | 1 month, 5 days ago | 1 month, 5 days ago | accepted | 1 month, 5 days ago | Hi, docs/libfaac.pdf is "FAAC-ISO/MPEG 2/4 AAC Encoder Library V1.0", and page 1 reads: "© 2001 AudioCoding.com. All rights reserved." It documents the legacy faacEnc* API (e.g. faacEncOpen, faacEncGetCurrentConfiguration) and its data-structure reference. Fix: add Files-Excluded: docs/libfaac.pdf to debian/copyright, add the corresponding +dfsg repack suffix (watch + dversionmangle), bump to 2.2+dfsg-1, or have upstream drop/relicense the file. Exclusion is the safest given the unverifiable "All rights reserved" notice and the removed API it describes. Everything else looks fine. Thanks! | View |
| mechtilde | 2.0-1 | 3 months, 9 days ago | 3 months, 9 days ago | accepted | 3 months, 9 days ago | View |