Reviews for golang-filippo-nistec
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 0.0.4-3 | 2 months, 19 days ago | 2 months, 19 days ago | accepted | 2 months, 18 days ago | View | |
| siretart | 0.0.4-2 | 2 months, 21 days ago | 2 months, 21 days ago | rejected | 2 months, 21 days ago | Inaccurate `debian/copyright` for `internal/fiat`: The `debian/copyright` file lists `internal/fiat/*` as being under the BSD-1-Clause license with "The fiat-crypto Authors" as copyright holders. However, several files in this directory (e.g., internal/fiat/p256.go, internal/fiat/p224.go, internal/fiat/generate.go, and the *_invert.go files) contain headers explicitly stating: // Copyright 2021 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. These copyright statements must be preserved. Only the *_fiat64.go files and the README appear to be under the fiat-crypto BSD-1-Clause license. Please update debian/copyright to include all copyright statements | View |
| siretart | 0.0.4-1 | 2 months, 26 days ago | 2 months, 26 days ago | rejected | 2 months, 26 days ago | The package contains fiat-crypto derived code with a distinct copyright and license that is not properly documented in `debian/copyright`. File `internal/fiat/README` contains: ``` Copyright (c) 2015-2020 The fiat-crypto Authors. All rights reserved. Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. ``` This represents a separate copyright holder and license from the main Go Authors BSD-3-clause license. | View |