Reviews for golang-github-a-h-templ
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 0.3.1001+ds-1 | 1 month, 25 days ago | 1 month, 25 days ago | accepted | 1 month, 25 days ago | View | |
| siretart | 0.3.1001-1 | 1 month, 28 days ago | 1 month, 28 days ago | rejected | 1 month, 28 days ago | Thanks for your diligence while working on this package. I've had a look through the source, and while it's mostly there, I have to reject it for now because of some issues in the examples and a few copyright slips. The main headache is with a few specific examples that bundle minified JS and CSS without source. This is a bit of a DFSG problem since we don't have the preferred form for modification, and the minification process often strips out original authorship, which leads to license violations. Specifically: * **examples/counter-basic/**: contains `assets/bulma.min.css`. * **examples/counter/**: contains `assets/js/htmx.min.js` and `assets/css/bulma.min.css`. * **examples/crud/**: contains `static/htmx.min.js` and `static/bootstrap.css`. The bootstrap file is particularly messy as it embeds Normalize.css and HTML5 Boilerplate but loses the attribution for authors like Nicolas Gallagher and Jonathan Neal. I'd suggest just excluding these three example directories from the source tarball using Files-Excluded in d/copyright. It's usually the easiest way to deal with bundled web assets that aren't core to the actual library. The other examples seem fine to keep. Also, safehtml/style.go is actually copyrighted by 'The Go Authors' (2017), so you'll need a separate stanza for that rather than lumping it in with the LSP authors. You should also double-check the year ranges for the LSP authors in lsp/; I saw 2018-2021 in the headers, so make sure the d/copyright patterns reflect that. Fix those up and send it back my way. -rt | View |