DFSG NEW Queue

DFSG, Licensing & New Packages Team

Reviews for golang-github-expr-lang-expr

All reviews for this package from team members (across all versions).

Reviewer Version Allocated Started Status Completed Comment
awm 1.17.8-1 1 month, 15 days ago 1 month, 15 days ago rejected 1 month, 15 days ago Hi, Licensing Issues ================ 1. internal/spew/* — wrong licence short name (Expat ≠ actual text). debian/copyright:10–12 labels this stanza License: Expat, but every header is ISC, e.g. internal/spew/doc.go:2–11: "Copyright (c) 2013-2016 Dave Collins dave@davec.name … Permission to use, copy, modify, and distribute this software for any purpose with or without fee … THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES … IN NO EVENT SHALL THE AUTHOR BE LIABLE …". That is the ISC template (same wording the golang-github-davecgh-go-spew package uses), not the Expat/MIT "AUTHORS OR COPYRIGHT HOLDERS" text. The Invariant: change the stanza to License: ISC (text already in /usr/share/common-licenses). Holder is correct. 2. internal/difflib/* — vendored pmezard/go-difflib (BSD-3-Clause), not covered. internal/difflib/difflib.go:1–14 is the verbatim pmezard doc header: "Package difflib is a partial port of Python difflib module … SequenceMatcher … unified_diff … context_diff"; no copyright notice was carried over. It falls into the Files: * catch-all as "Anton Medvedev, MIT", which is wrong on both holder and licence. Fix: add a specific stanza, e.g. Files: internal/difflib/*, Copyright: 2013-2021 Patrick Mezard, License: BSD-3-clause, with the BSD-3 text included (not in common-licenses). 3. internal/testify/* — vendored stretchr/testify (MIT), not covered. Verbatim testify code with testify's generators (e.g. internal/testify/assert/assertions.go:25 //go:generate … ../_codegen/_codegen …, .tmpl files) and no copyright lines. Also falls under the catch-all as "Anton Medvedev". Fix: add Files: internal/testify/* with the testify holder (e.g. Copyright: 2012-2020 Mat Ryer/expr-lang vendored copy) and License: Expat; the Expat paragraph already carries the full MIT text. This is not academic: DH_GOLANG_EXCLUDES only drops test/examples, so all of internal/* (including these three vendored trees) is installed into the -dev package. Minor Packaging Issue ===================== Patch should be forwarded (minor). debian/patches/0001-*.patch is a genuine upstream bug (tests fail to compile on 32-bit — hardcoded 64-bit literals in builtin/builtin_test.go, expr_test.go), is DEP-3 formatted, and the runtime-computed bitushr() helper is a sound fix. Forwarded: no is present; it should be forwarded to expr-lang/expr or a bug note added. Thanks! View

Back to Dashboard