Reviews for golang-github-wneessen-go-mail
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 0.7.2+dfsg-1 | 1 month, 10 days ago | 1 month, 10 days ago | rejected | 1 month, 10 days ago | ### 1. Missing Copyright Holders in debian/copyright The `debian/copyright` file claims that all files are: ``` Files: * Copyright: 2022 Winni Neessen License: Expat ``` However, the source code reveals multiple copyright holders that are not properly documented: - **Go Authors**: Files in the `smtp/` directory contain `// SPDX-FileCopyrightText: Copyright 2010 The Go Authors. All rights reserved.` (e.g., `./smtp/smtp_test.go` line 1, `./smtp/smtp.go` line 1) - **Andrew Smith**: The `internal/pkcs7/` files contain `// SPDX-FileCopyrightText: Copyright (c) 2015 Andrew Smith` (e.g., `./internal/pkcs7/pkcs7.go` line 1) - **Mozilla Services Project**: The same files contain `// SPDX-FileCopyrightText: Copyright (c) 2017-2024 The mozilla services project` (e.g., `./internal/pkcs7/pkcs7.go` line 2) ### 2. Dual Licensing Not Properly Documented Several files in the `smtp/` directory are dual-licensed under both BSD-3-Clause AND MIT: ``` // SPDX-License-Identifier: BSD-3-Clause AND MIT ``` (e.g., `./smtp/smtp_test.go` line 12, `./smtp/smtp.go` line 12) The `debian/copyright` file only mentions the MIT license (Expat) and doesn't account for this dual licensing. ### 3. Inconsistent Copyright Attribution The actual copyright notices in source files refer to "The go-mail Authors" (e.g., `./smime_test.go` line 1), but `debian/copyright` attributes everything to "Winni Neessen". While the main `LICENSE` file does use "The go-mail Authors", this inconsistency needs clarification. ## Nitpicks / Suggestions 1. The copyright year range in `debian/copyright` shows "2022" but the actual `LICENSE` file shows "2022-2025" - consider updating for consistency. 2. Consider adding a comment in `debian/copyright` explaining the relationship between "The go-mail Authors" and the individual contributors for clarity. The package appears to be free software suitable for Debian main once these copyright documentation issues are resolved. The licenses themselves (MIT and BSD-3-Clause) are DFSG-compliant. | View |
| awm | 0.7.2-1 | 1 month, 8 days ago | 1 month, 8 days ago | rejected | 1 month, 8 days ago | See comments for golang-github-wneessen-go-mail_0.7.2+dfsg-1 | View |