Reviews for golang-modernc-libc
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Comment |
|---|---|---|---|---|---|
| siretart | 1.66.10-2 | 8 hours ago | 8 hours ago | accepted | -h |
| siretart | 1.66.10-1 | 5 days ago | 5 days ago | rejected | ### 1. Missing `ioutil_*.go` dual copyright declaration **Evidence:** Files `ioutil_linux.go`, `ioutil_darwin.go`, `ioutil_freebsd.go`, `ioutil_openbsd.go`, `ioutil_netbsd.go`, `ioutil_illumos.go` contain: ```go // Copyright 2010 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE-GO file. // // Modifications Copyright 2020 The Libc Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. ``` **Issue:** These files have dual copyright (Go Authors + Libc Authors), but `debian/copyright` only covers them under the `Files: *` pattern with just "The Libc Authors". **Fix:** Add a specific stanza to `debian/copyright`: ```debian Files: ioutil_*.go Copyright: 2010 The Go Authors 2020 The Libc Authors License: BSD-3-Clause ``` --- ### 2. Missing `testdata/nsz.repo.hu/libc-test/` licensing **Evidence:** The `testdata/nsz.repo.hu/libc-test/COPYRIGHT` states: ``` libc-test is licensed under the following standard MIT license: ... Portions of this software is derived from software authored by third parties: math tests use numbers under BSD and GPL licenses see src/math/ucb/* and src/math/crlibm/* for details ``` **Issue:** Only `testdata/nsz.repo.hu/libc-test/src/functional/strptime.c` is explicitly documented. The rest of the testdata directory, including: - `testdata/nsz.repo.hu/libc-test/src/math/crlibm/*` (GPL-2.0) - `testdata/nsz.repo.hu/libc-test/src/math/ucb/*` (Sun Microsystems BSD-like license) ...are not covered. **Fix:** Add stanzas to `debian/copyright`: ```debian Files: testdata/nsz.repo.hu/libc-test/* Copyright: 2005-2013 libc-test AUTHORS License: Expat Files: testdata/nsz.repo.hu/libc-test/src/math/crlibm/* Copyright: Free Software Foundation, Inc. License: GPL-2 Files: testdata/nsz.repo.hu/libc-test/src/math/ucb/* Copyright: 1988-1994 Sun Microsystems, Inc. License: Sun-Microsystems-BSD Comment: BSD-like license with redistribution and export control restrictions ``` You may also need to add the `License: Sun-Microsystems-BSD` license text block. --- ### 3. Missing `honnef.co/go/netdb/*` file coverage **Issue:** Only `honnef.co/go/netdb/LICENSE` is documented, but the directory contains other files (`netdb.go`, `README.md`). **Fix:** Update the existing stanza to: ```debian Files: honnef.co/go/netdb/* Copyright: 2012 Dominik Honnef License: Expat ``` |