Reviews for golang-modernc-sqlite
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 1.40.0-1 | 1 month, 8 days ago | 1 month, 8 days ago | accepted | 1 month, 7 days ago | I think the issues below are not affecting conformance with DFSG or cause concerns regarding whether Debian can redistribute this package. Nevertheless, please have a look at the found issues below and track them as regular issues. ### Sourceless Binary Blobs - **Files**: `embed.db`, `embed2.db` - **Issue**: These binary SQLite database files are present in the source but no source code or generation script (e.g., SQL dump or instruction in `Makefile`) was found to reproduce them. - **Action**: Please provide the source (SQL scripts) to generate these files, or remove them if they are not needed. If they are generated, ensure the build system creates them from source. ### Missing License/Copyright in `debian/copyright` - **File**: `vendor_libsqlite3/main.go` - **Issue**: This file has a copyright notice `Copyright 2024 The Sqlite Authors`, but `debian/copyright` only covers years `2016-2017` for `Files: *`. It also appears to be a build tool that should be documented. - **Action**: Update `debian/copyright` to include 2024 in the copyright years for the main stanza or add a specific stanza for `vendor_libsqlite3/*`. ### Potential Issue: `logo.png` - **File**: `logo.png` - **Issue**: This is a binary image file without explicit license documentation in the source (no embedded metadata or sidecar license file found). `debian/copyright` covers it under `Files: *` (BSD-3-Clause). - **Action**: Confirm if this image is indeed BSD-3-Clause or if it requires a different license (e.g. CC-BY, trademark restrictions). | View |