Reviews for grout
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 0.16.1-1 | 19 days ago | 19 days ago | accepted | 19 days ago | View | |
| siretart | 0.16.0-1 | 1 month, 17 days ago | 1 month, 17 days ago | rejected | 1 month, 17 days ago | Thanks for your diligence on this package. There are several DFSG compliance and licensing issues in debian/copyright that must be addressed. First, there are a couple of BSD-3-Clause files where the source copyright holders are missing from debian/copyright: - meson_options.txt contains "Copyright (c) 2024 Vincent Jardin" (line 2), but Vincent Jardin is not listed in debian/copyright. - smoke/bgp_frr_test.sh contains "Copyright (c) 2025 Andrea Panattoni" (line 3), but Andrea Panattoni is not listed in debian/copyright. Under the terms of the BSD-3-Clause license, copyright notices must be reproduced verbatim, so these contributors should be added to the list of copyright holders under the main Files: * stanza or their own sections. Second, the logo files docs/logo.svg and docs/logo-white.svg contain embedded metadata licensing them under Creative Commons Attribution-ShareAlike 4.0 International (CC-BY-SA-4.0) by Robin Jarry. Currently, these files are covered by the catch-all Files: * stanza in debian/copyright which declares BSD-3-Clause. To comply with licenses, these files should have their own stanza specifying the CC-BY-SA-4.0 license, and the full license text needs to be included in debian/copyright as it is not present in the common licenses archive. Additionally, the RDF metadata inside these SVGs contains a dc:rights field stating "All rights reserved" alongside the CC-BY-SA-4.0 license reference. While this is likely an artifact of the drawing tool's default configuration, it presents a major conflict. This needs to be clarified in debian/copyright. Please discuss the copyright situation with upstream and document the conclusions in debian/copyright. -rt | View |
| siretart | 0.16.0-1 | 27 days ago | 27 days ago | accepted | 27 days ago | Thanks for your diligence on this package. It's great to see that all the issues from the previous review have been addressed. The copyright file is now in much better shape. I did notice one small detail that could use a touch-up. The file `main/sd_notify.c` carries dual SPDX license headers: `BSD-3-Clause` (line 1) and `MIT-0` (line 7). The current `debian/copyright` stanza for this file only lists `MIT-0`. To be fully accurate, it should reflect both licenses, perhaps as `BSD-3-Clause OR MIT-0`. Please fix that in the next upload. -rt | View |