Reviews for hyprshade
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 4.0.1-1 | 1 month, 15 days ago | 1 month, 15 days ago | rejected | 1 month, 15 days ago | Thanks for your diligence in preparing this initial release of hyprshade! I've looked through the source and found a few things that need a quick fixup: First, there's a verbatim accuracy issue in debian/copyright. The copyright notice must exactly mirror what's in the upstream LICENSE file. Currently, you have "2023-2026 John Bernard <loqusion@gmail.com>", but the source only contains "Copyright (c) 2023 loqusion". Please update debian/copyright to match the source string exactly. Second, the shaders in the shaders/ directory have mixed origins that aren't documented in debian/copyright: * blue-light-filter.glsl: Includes "colorTemperatureToRGB" from Benjamin 'BeRo' Rosseaux (CC0 1.0). * vibrance.glsl: Is a port of the SweetFX Vibrance shader by Christian 'CeeJay.dk' Schjeldahl (MIT/Expat). Finally, I noticed some very large PNG assets in .github/assets/ (totaling about 39MB). Are you sure you want to have these large PNG files in the source package? Once those are addressed, this should be good to go. -rt | View |