Reviews for labwc-tweaks
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 0.1.0-1 | 1 month, 22 days ago | 1 month, 22 days ago | rejected | 1 month, 22 days ago | Thanks for your diligence on this initial release of labwc-tweaks. I found a few points in the copyright file that need a bit of adjustment before the package can be accepted into the archive. The most significant issue is that the main license for the project is documented as BSD-3-Clause in debian/copyright, but the upstream source (including the README, the LICENSE file, and several source headers like src/xml.cpp) explicitly states that the project is licensed under GPL-2.0-only. This needs to be corrected to accurately reflect the project's primary license. I also noticed that a few contributors are missing from the attribution list. Specifically, Alf Gaida (in bin/lxqt-transupdate) and Luís Pereira (in cmake/LXQtTranslate.cmake) should be documented. Luís's file also mentions Alexander Sokolov as the original author, so it would be good to include him as well. The AppStream metadata (data/labwc_tweaks.appdata.xml.in) is licensed under CC0-1.0 according to Config.cmake, so a block for that license and the "Labwc Team" (or Johan Malm) should be added. I also spotted a slight year discrepancy: tests/tap.h has a copyright notice for Johan Malm from 2020, but the current debian/copyright starts at 2021. It's best to include 2020 to be fully verbatim. Finally, while the "labwc-tweaks contributors" catch-all is fine if that's how upstream refers to them, the specific names found in the headers should definitely be called out individually in their respective file blocks. -rt | View |
| siretart | 0.1.0-1 | 1 month, 20 days ago | 1 month, 20 days ago | accepted | 1 month, 20 days ago | Thanks for your diligence on this release, it looks good! Btw, for the next upload, you might consider adjusting the copyright year for Johan Malm in the AppStream metadata block to 2020 to match the earliest date found in the source (like in tests/tap.h), although the main block already covers it. You could also simplify that block by just using the "Labwc Team" moniker as found in the AppStream metadata template (data/labwc_tweaks.appdata.xml.in). Overall, great work! -rt | View |