Reviews for lcalc
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| awm | 2.2.2-1 | 1 month, 19 days ago | 1 month, 19 days ago | accepted | 1 month, 19 days ago | Hi, Some minor issues spotted... 1: m4/ax_openmp.m4 is not described (copyright inaccuracy, minor) This file is new in 2.2.2 and has its own named author/licence origin. Its header (line 1): # Modified version of AC_OPENMP from autoconf 2.73 c.m4 file (Dima Pasechnik, 2026/03). It falls into the Files: * catch-all, which attributes it to "(2001–2004) Michael Rubinstein, GPL-2+". That is wrong on both counts: it is autoconf-derived (GPL-3+ under autoconf's terms) and was authored/adapted by Dima Pasechnik. Fix: add a stanza Files: m4/ax_openmp.m4 / Copyright: Dima Pasechnik / License: GPL-3+ (or note the autoconf origin). Not DFSG-blocking — it is clearly free build tooling — but the holder/licence attribution is inaccurate, and debian/copyright is the one place upstream source licensing must be pinned down. 2: Build-Depends missing autoconf/automake/libtool → FTBFS on clean buildds (must fix) The source ships no generated autotools files whatsoever — no configure, aclocal.m4, Makefile.in, build-aux/, src/config.h.in (I globbed; none exist anywhere outside .pc/), and doc/INSTALL confirms upstream uploads git trees. The tarball fetched by debian/watch (https://gitlab.com/sagemath/lcalc/-/archive/v2.2.2/..., a GitLab archive URL) is a bare git export, so the Debian build must regenerate the whole autotools system from configure.ac/Makefile.am. debian/rules does nothing special (just dh_auto_configure -- --with-pari), and in compat 14 dh automatically injects the +autoreconf addon (verified in /usr/share/perl5/Debian/Debhelper/SequencerUtil.pm: push(@addon_requests, '+autoreconf') for not compat(9,1)), so dh_autoreconf runs autoreconf -f -i (it only early-exits if there is no configure.ac, and configure.ac exists, requiring AC_PREREQ([2.72])). autoreconf/autoconf/automake/libtoolize are not in Build-Depends and are not pulled in by build-essential, libpari-dev, pkgconf or gengetopt. A clean buildd therefore fails with autoreconf: command not found. Fix: add autoconf (>= 2.72) (AC_PREREQ), automake, and libtool to Build-Depends (compat 14's auto-reconf then regenerates configure/Makefile.in/ltmain.sh correctly). This is the one change I would require before upload. 3: stale upstream URLs (minor) debian/control Homepage: and debian/copyright Source: still cite the abandoned oto.math.uwaterloo.ca/~mrubinst/L_function_public/… site, while the project (and the watch) moved to gitlab.com/sagemath/lcalc years ago. Recommend updating both to the gitlab URLs for consistency. Not policy-violating. Thanks! | View |