Reviews for libgbinder
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 1.1.45+ds-1 | 1 month, 13 days ago | 1 month, 13 days ago | rejected | 1 month, 12 days ago | libgbinder @review-notes-libgbinder-1.1.45+ds-1.txt | View |
| siretart | 1.1.45+ds-1 | 1 month, 12 days ago | 1 month, 12 days ago | rejected | 1 month, 12 days ago | Thanks for your diligence in bringing libgbinder to the archive. It's a valuable addition, but I've run into a few snags in debian/copyright that we'll need to sort out before it can be accepted. I noticed a slight slip in the attribution of several contributors. While Jolla and Slava are well-represented, a few others who are credited directly in the source headers have been missed in the copyright file. Specifically: * Gary Wang <gary.wang@canonical.com> is credited in several AIDL-related files (like src/gbinder_servicemanager_aidl4.c). * Madhushan Nishantha <jlmadushan@gmail.com> also appears in those same files. * Franz-Josef Haider <franz.haider@jolla.com> is credited in test/binder-call/binder-call.c. There's also a bit of a DFSG problem with src/binder.h. Since it's a bundled header derived from the Linux kernel via the Android Bionic project, it needs its own stanza acknowledging the original authors (Linux Kernel Developers and Google), even if the header itself claims to be non-copyrightable. I also noticed that the BSD-3-clause license text in debian/copyright seems to be a generic template rather than a verbatim copy of the actual license used by the project. For instance, your text still contains the "name of the ORGANIZATION" placeholder in the third condition, whereas upstream has replaced this with "names of the copyright holders." Similarly, the disclaimer in the source uses the plural "COPYRIGHT HOLDERS," while your text is in the singular. For a machine-readable copyright file, the text must be an exact verbatim match of what's in the source (including numbering styles and disclaimers), so please replace the template with the specific text found in the LICENSE file. Lastly, Slava Monich uses a couple of different email addresses across the headers, and some files like the cmdline lexer/parser in the test directory are missing headers entirely. It would be great to have those all tidied up in the documentation. Please take another look at the source and re-upload once these are addressed. I'm looking forward to seeing this in the archive. -rt | View |
| siretart | 1.1.45+ds-1 | 1 month, 10 days ago | 1 month, 10 days ago | rejected | 1 month, 9 days ago | Thanks for the update. I see most issues are resolved, but there is one remaining discrepancy in debian/copyright to address. Several files (e.g., src/gbinder_io_32.c and test/rild-card-status/) use a BSD-3-clause variant that explicitly names "Jolla Ltd" in the third condition. Please ensure this verbatim text is documented and applied to those paths in debian/copyright. As a minor note for future uploads: I noticed that Slava Monich uses both <slava@monich.com> and <slava.monich@jolla.com> across the source headers, but only the former is listed in debian/copyright. It might be nice to include both addresses eventually. Also, regarding src/binder.h, "Linux Kernel Developers" could be added to the copyright holders list, and there is a slight naming inconsistency between the file stanza ("GPL-2 WITH Linux-syscall-note") and the standalone license block ("GPL-2 with Linux-syscall-note exception"). These aren't blockers, but would be good to tidy up down the road. -rt | View |
| siretart | 1.1.45+ds-1 | 1 month, 8 days ago | 1 month, 8 days ago | accepted | 1 month, 7 days ago | View |