Reviews for liblsl
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| awm | 1.17.5-1 | 2 months, 9 days ago | 2 months, 9 days ago | rejected | 2 months, 9 days ago | Hi, Looks like you missed a couple of authors in the debian/copyright... liblsl_1.17.5-1$ grep -ri Kapoulkine . ./thirdparty/pugixml/pugiconfig.hpp: * Copyright (C) 2006-2025, by Arseny Kapoulkine (arseny.kapoulkine@gmail.com) ./thirdparty/pugixml/pugiconfig.hpp: * Copyright (c) 2006-2025 Arseny Kapoulkine ./thirdparty/pugixml/pugixml.hpp: * Copyright (C) 2006-2025, by Arseny Kapoulkine (arseny.kapoulkine@gmail.com) ./thirdparty/pugixml/pugixml.hpp: * Copyright (c) 2006-2025 Arseny Kapoulkine ./thirdparty/pugixml/pugixml.cpp: * Copyright (C) 2006-2025, by Arseny Kapoulkine (arseny.kapoulkine@gmail.com) ./thirdparty/pugixml/pugixml.cpp: * Copyright (c) 2006-2025 Arseny Kapoulkine ./thirdparty/pugixml/readme.txt:Copyright (C) 2006-2020, by Arseny Kapoulkine (arseny.kapoulkine@gmail.com) ./thirdparty/pugixml/readme.txt:Copyright (c) 2006-2019 Arseny Kapoulkine ./LICENSE:pugixml (https://pugixml.org), MIT. pugixml is Copyright (C) 2006-2018 Arseny Kapoulkine. liblsl_1.17.5-1$ grep -ri wegner . ./thirdparty/pugixml/pugiconfig.hpp: * Copyright (C) 2003, by Kristen Wegner (kristen@tima.net) ./thirdparty/pugixml/pugixml.hpp: * Copyright (C) 2003, by Kristen Wegner (kristen@tima.net) ./thirdparty/pugixml/pugixml.cpp: * Copyright (C) 2003, by Kristen Wegner (kristen@tima.net) There's also the cmake/ios.toolchain.cmake perhaps having a BSD-3-Clause license, but it's probably easiest to just exclude that file from Debian. Thanks! | View |
| awm | 1.17.5-1 | 2 months, 4 days ago | 2 months, 4 days ago | accepted | 2 months, 4 days ago | Hi, I've accepted, but I did manage to find another couple of authors who aren't credited in debian/copyright (see note) if you want to add them in your next upload. Thanks! | View |