Reviews for librime
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| awm | 1.17.0+dfsg2-4 | 8 days ago | 8 days ago | accepted | 8 days ago | Auto-accepted (binary NEW): Already in Debian | View |
| awm | 1.17.0+dfsg2-1 | 1 month, 20 days ago | 1 month, 20 days ago | rejected | 1 month, 20 days ago | Hi, In debian/copyright I see: Files: * Copyright: 2011-2024, GONG Chen <chen.sst@gmail.com> License: GPL-3.0-only However: $ grep -r 'BSD' * ... src/rime_api.cc:// Distributed under the BSD License src/rime/signature.cc:// Distributed under the BSD License src/rime/setup.h:// Distributed under the BSD License src/rime/segmentation.cc:// Distributed under the BSD License src/rime/translator.h:// Distributed under the BSD License src/rime/formatter.h:// Distributed under the BSD License src/rime/switcher.h:// Distributed under the BSD License src/rime/algo/encoder.cc:// Distributed under the BSD License src/rime/algo/syllabifier.h:// Distributed under the BSD License src/rime/algo/syllabifier.cc:// Distributed under the BSD License src/rime/algo/algebra.h:// Distributed under the BSD License src/rime/algo/encoder.h:// Distributed under the BSD License src/rime/algo/calculus.cc:// Distributed under the BSD License src/rime/algo/calculus.h:// Distributed under the BSD License src/rime/algo/algebra.cc:// Distributed under the BSD License src/rime/algo/utilities.h:// Distributed under the BSD License src/rime/algo/spelling.h:// Distributed under the BSD License src/rime/algo/utilities.cc:// Distributed under the BSD License src/rime/key_event.cc:// Distributed under the BSD License src/rime/key_event.h:// Distributed under the BSD License src/rime/module.h:// Distributed under the BSD License src/rime/gear/recognizer.cc:// Distributed under the BSD License src/rime/gear/selector.h:// Distributed under the BSD License src/rime/gear/abc_segmentor.cc:// Distributed under the BSD License src/rime/gear/uniquifier.h:// Distributed under the BSD License src/rime/gear/abc_segmentor.h:// Distributed under the BSD License src/rime/gear/unity_table_encoder.cc:// Distributed under the BSD License src/rime/gear/reverse_lookup_translator.cc:// Distributed under the BSD Licens ... It seems that this should be recognized as BSD-3-Clause license! Thanks! | View |
| awm | 1.17.0+dfsg2-1 | 1 month, 20 days ago | 1 month, 20 days ago | accepted | 1 month, 20 days ago | Hi, Thanks for the license fixes. Looking closer I can see that librime-lua/src/script_translator.cc, table_translator.cc, translator.h, types_ext.cc — headers say Copyright (C) 2023/2022 Shewer Lu <shewer@gmail.com> … Distributed under terms of the MIT license. Also librime-lua/sample/lua/{commit_history,component_test,leveldb,script_translator,table_translator,userdb}.lua — same MIT/Shewer Lu headers (2022–2024). Additionally Files: debian/* (lines 105–108) says License: GPL-3.0-only, but debian/debian-rime-processor is explicitly CC0-1.0 (its header: SPDX-License-Identifier: CC0-1.0, lines 5–6). That file is also shipped to users via librime-bin (debian/librime-bin.install). Fix: add a stanza for debian/debian-rime-processor with License: CC0-1.0 (+ text), or a blanket CC0 policy. Minor. Please fix these in your next upload. Thanks! | View |