Reviews for node-tsc-alias
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 1.8.16-1 | 1 month, 21 days ago | 1 month, 21 days ago | rejected | 1 month, 21 days ago | Thanks for your diligence while working on this package. I've had a look through the source, and while it's mostly there, I have to reject it for now because of inaccuracies in `debian/copyright` and missing metadata. ### Critical Issues (Blockers) 1. **Failure to Reproduce Copyright Notices Verbatim**: The Expat license requires that "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." In `debian/copyright`, the upstream notice has been modified to "Juste Méthode B. <cervotechit@gmail.com>". While this might be an attempt to identify the author's legal name, the license mandates verbatim reproduction of the notice found in the source: `Copyright (c) 2018 Justkey`. Please update the stanza to match the upstream `LICENSE` file exactly. 2. **Incorrect Copyright Years**: The upstream copyright year in `debian/copyright` is listed as 2026, but the source code's `LICENSE` file is dated 2018. The years in `debian/copyright` must accurately reflect the notices in the source. 3. **Missing Copyright for Test Projects**: `projects/project24/package.json` identifies a different author: `"author": "Dmitry Kirilyuk <gk.joker@gmail.com>"`. This file is not covered by the current `debian/copyright` stanzas. Please add a specific stanza for these files, again ensuring you reproduce the copyright notice as it appears in the source. ### Required Fixes - Update `debian/copyright` to verbatim match the upstream copyright notices and years. - Add a stanza for `projects/project24/*` to credit Dmitry Kirilyuk. - Add `Priority: optional` to the `Source` stanza in `debian/control` to comply with Debian Policy 2.5. -rt | View |
| siretart | 1.8.16-1 | 1 month, 19 days ago | 1 month, 19 days ago | accepted | 1 month, 19 days ago | View |