Reviews for pari
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| awm | 2.19.0~pre1-1 | 1 month, 13 days ago | 1 month, 13 days ago | accepted | 1 month, 13 days ago | Hi, Suggested replacement debian/copyright converted to DEP-5 format. ========================================================================== Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: PARI/GP Upstream-Contact: Bill Allombert and Aurel Page <pari@math.u-bordeaux.fr> Source: http://pari.math.u-bordeaux.fr/pub/pari/pari.tgz Comment: The bulk of the code is Copyright (C) 2000-2026 The PARI Group, Bordeaux and released under the GPL v2 or later. A few files embed third-party code by other authors under the same licence, and the Darwin system support files are MIT-licensed. Files: * Copyright: 2000-2026 The PARI Group, Bordeaux License: GPL-2+ Files: src/systems/darwin/darwin.c Copyright: 2002 Peter O'Gorman License: MIT Comment: Modified for PARI/GP by the PARI group. Files: src/systems/darwin/dlfcn.h Copyright: 2002 Jorge Acereda, Peter O'Gorman License: MIT Files: doc/refcard*.tex doc/refmacro.tex Copyright: 2007-2024 Karim Belabas; 1993-1994 Joseph H. Silverman (basis) License: GPL-2+ Files: src/modules/ratpoints.c Copyright: 2008, 2009, 2022 Michael Stoll; 2017 The PARI group License: GPL-2+ Comment: ratpoints-2.2.1 (find rational points on hyperelliptic curves), embedded under its original copyright notice. Files: src/basemath/lll.c Copyright: 2008 The PARI group; 2005, 2006 Damien Stehle' License: GPL-2+ Files: src/basemath/F2v.c Copyright: 2012-2019 The PARI group; 2006 Jason Papadopoulos License: GPL-2+ Comment: Lanczos algorithm derived from FlintQS. License: GPL-2+ This package is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. . On Debian systems, the complete text of the GNU General Public License version 2 can be found in '/usr/share/common-licenses/GPL-2'. License: MIT Permission is hereby granted, free of charge, to any person obtaining a copy of this software and attached documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. ========================================================================== Licensing findings ================== 1. debian/copyright omits the MIT-licensed Darwin files (main issue) debian/copyright (766 B, non-DEP-5, one paragraph) claims: "PARI/GP … Copyright (C) 2000-2023 The PARI Group, Bordeaux … GNU General Public License … version 2 of the License, or (at your option) any later version." Two shipped files are MIT, not GPL, and their holders are never mentioned: - src/systems/darwin/darwin.c:1 — "Copyright (c) 2002 Peter O'Gorman ogorman@users.sourceforge.net", full MIT text at lines 2–17. - src/systems/darwin/dlfcn.h:1-2 — "Copyright (c) 2002 Jorge Acereda jacereda@users.sourceforge.net & Peter O'Gorman …", MIT text at lines 12+. Header notes "Portions may be copyright others". These are in the shipped .orig tarball (the debian tarball is 17 KB of patches only), so they must be described. MIT is DFSG-free and GPL-compatible, so this is a copyright-file compliance problem, not a DFSG violation. Fix: on conversion to DEP-5, add Files: src/systems/darwin/* with Copyright: 2002 Peter O'Gorman; 2002 Jorge Acereda and the full MIT text (not in /usr/share/common-licenses, so it must be reproduced). Also add a Files: * / License: GPL-2+ catch-all (then the /usr/share/common-licenses/GPL-2 reference is valid). 2. debian/copyright mis-attributes GPL files to the PARI Group Within the (correctly GPL-2+) corpus, several files carry non-PARI holders the free-form notice fails to acknowledge: - doc/refcard*.tex and doc/refmacro.tex:1 — "Copyright (c) 2007-2024 Karim Belabas" (GPL). - doc/refcard.tex:18 — "Copyright (c) 1993,1994 Joseph H. Silverman" (basis, GPL). - src/modules/ratpoints.c:20 — "ratpoints-2.2.1 … Copyright (C) 2008, 2009, 2022 Michael Stoll" (GPL-2+). - src/basemath/lll.c:630 — "Copyright 2005, 2006 Damien Stehle'" (GPL-2+, lll floating-point code). - src/basemath/F2v.c:662-664 — lanczos algorithm "Copyright Jason Papadopoulos 2006", GPL-2+. - doc/refcard*.tex re Silverman/Gildea lineage. Licence short names are still correctly GPL-2+, so nothing here is non-free; it's an attribution gap the DEP-5 conversion should close (list these holders in the relevant Files: stanzas). Packaging findings (minor / non-blocking) ========================================= - Two patches lack DEP-3 header fields: debian/patches/perl-warning-non-fatal and debian/patches/no_harcode_path have no Description/Author. debian/patches/enable_build_envvar has a stale header path (Index: pari-2.15.4/config/get_cc — harmless to quilt, but shows drift). Add DEP-3 headers; consider forwarding perl-warning-non-fatal upstream. - Build flags ignore dpkg-buildflags: debian/rules invents its own CFLAGS/LDFLAGS (LDFLAGS = -Wl,-z,relro, no -z,now, no PIE/FORTIFY) and never imports the defaults. Given this is a C codebase parsing user scripts in a TUI, you may want at least default hardening. Thanks! | View |
| mechtilde | 2.19.0-1 | 1 month, 20 days ago | 1 month, 20 days ago | rejected | 1 month, 20 days ago | Hello, please list all authors with their files and licenses. This can be done easy in DEP-5 format. Thanks | View |