Reviews for poselib
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 2.0.5-1 | 1 month, 10 days ago | 1 month, 10 days ago | rejected | 1 month, 10 days ago | The `debian/copyright` file claims that all files (`*`) are copyrighted by "2020-2025 Viktor Larsson", but the evidence shows that some files have different copyright holders: - `./PoseLib/solvers/relpose_8pt.h` states: `// Copyright (c) 2020, Pierre Moulon` - `./PoseLib/solvers/relpose_8pt.cc` states: `// Copyright (c) 2020, Pierre Moulon` - `./PoseLib/solvers/relpose_upright_planar_3pt.h` states: `// Copyright (c) 2020, Pierre Moulon` - `./PoseLib/solvers/relpose_upright_planar_3pt.cc` states: `// Copyright (c) 2020, Pierre Moulon` You need to update `debian/copyright` to properly acknowledge Pierre Moulon's contributions. Please add a separate stanza for the files authored by Pierre Moulon: ``` Files: PoseLib/solvers/relpose_8pt.h PoseLib/solvers/relpose_8pt.cc PoseLib/solvers/relpose_upright_planar_3pt.h PoseLib/solvers/relpose_upright_planar_3pt.cc Copyright: 2020 Pierre Moulon License: BSD-3-clause ``` Once you address the missing copyright attribution for Pierre Moulon's files, this package should be ready for inclusion in Debian. | View |
| siretart | 2.0.5-1 | 1 month, 6 days ago | 1 month, 6 days ago | accepted | 1 month, 6 days ago | View |