Reviews for python-discid
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| awm | 1.4.2-1 | 1 month, 23 days ago | 1 month, 23 days ago | rejected | 1 month, 23 days ago | Hi, Please identify the LGPL version, i.e. "LGPL-3". Thanks! | View |
| awm | 1.4.2-1 | 30 days ago | 30 days ago | accepted | 30 days ago | Hi, Accepted, but there are still some issues which should be fixed... debian/copyright issues ======================= Missing copyright holder — must fix. discid/disc.py:2 and test_discid.py:3 both carry # Copyright (C) 2017 Frederik "Freso" S. Olesen, but every Files: stanza names only Johannes Dewender and Philipp Wolfer. The holder is absent from debian/copyright. Fix: add Frederik S. Olesen to the * stanza's Copyright: list (at least for discid/disc.py and test_discid.py, or as a separate stanza). Wrong short name: LGPL-3 should be LGPL-3+. All discid/*.py headers (e.g. discid/__init__.py:4-6) say "…Lesser General Public License … either version 3 of the License, or (at your option) any later version." DEP-5 short name LGPL-3 means version 3 only; the quoted text inside the copyright's own LGPL paragraph even reads "or (at your option) any later version" (debian/copyright:28-30). Fix: rename the short name (and the *, doc/*, debian/* stanzas) to LGPL-3+. examples.py / test_discid.py are not LGPL-3+. They carry # This example/test is free. You can redistribute and/or modify it at will. (examples.py:2-3, test_discid.py:5), an informal permissive/public-domain-style grant, and no LGPL header. The * catch-all currently attributes LGPL-3 to them. Not a DFSG problem (clearly permissive), but the attribution is factually wrong; give them their own stanza or note the "at will" grant. doc/* stanza: "LGPL-3 OR Expat" is unsupported. No file under doc/ is Expat-licensed; doc/index.rst:12-14 states the module docs are "LGNU Lesser General Public License Version 3 … or later (LGPL3+)". The "Expat" reference in debian/copyright:18 appears to be a carry-over from the relative, python-libdiscid which index.rst:36-37 mentions is Expat. Fix: doc/* should be LGPL-3+ (and the Expat paragraph then becomes unused). Wrong common-licenses path in the Comment (debian/copyright:36-38). The comment says the LGPL v3 text lives at /usr/share/common-licenses/LGPL; on Debian that file is the LGPL-2.1 text — v3 is at /usr/share/common-licenses/LGPL-3. Fix the path (and with the short-name fix, the "version 3" wording becomes correct). General packaging quality issues ================================ Watch file — likely broken, verify with uscan (debian/watch:1-5). It uses Version: 5 and Version-Mangle: s/^v// (fine — upstream tags are v1.4.2), but then Template: Github + Dist: https://github.com/metabrainz/python-discid. The v5 GitHub template is parameterised with Owner:/Project:, neither of which appears; Dist: is not a field of the GitHub template (the documented field set has Source, Template, Matching-Pattern, mangle/Repack/Compression/Search-Mode/Mode/Component/Version-Constraint etc., but no Dist), and the template name Github doesn't match GitHub. As written this is unlikely to resolve the release. Recommend the canonical form: ``` Version: 5 Version-Mangle: s/^v// Template: GitHub Owner: metabrainz Project: python-discid ``` Unused/odd Build-Depends (debian/control:6-15). pre-commit and ruff are upstream dev tooling (see .pre-commit-config.yaml), not used anywhere by the build (debian/rules is a bare dh $@ --buildsystem=pybuild); pre-commit in a build dependency is especially unusual. python3-sphinx, python3-sphinx-autodoc-typehints, python3-sphinx-rtd-theme are likewise never invoked — there is no doc-build override and no dh-sequence-sphinxdoc, and the binary ships no docs. libdiscid-dev is only there to pull the runtime .so for a hypothetical build-time test import (nothing is compiled; discid loads libdiscid0 via ctypes). Recommendation: drop pre-commit, ruff, and the three sphinx packages unless docs are actually built (and then add the sphinxdoc sequence/override); use libdiscid0 instead of libdiscid-dev in Build-Depends. Thanks! | View |