Reviews for python-greeneye-monitor
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| awm | 5.0.2-1 | 1 month, 23 days ago | 1 month, 23 days ago | rejected | 1 month, 23 days ago | Hi, Licensing / DFSG issues 1. Non-free vendor documentation PDFs shipped in the source, mislabeled as Expat (primary concern). The docs/ directory contains two third-party files: - docs/GEM-CMD_Commands_ver_10_0.pdf - docs/GEM-PKT_Packet_Format_2_1.pdf These are Brultech (the hardware manufacturer) device protocol/manual documents, not code authored by Jonathan Keljo. They are not covered by the MIT/Expat grant, yet debian/copyright lists them under the blanket Files: * ... License: Expat stanza, which is inaccurate for these files. Their license is undocumented/unknown, which is a genuine DFSG concern (source package contains material whose redistribution terms aren't established). The upstream source is shipped un-repacked (5.0.2-1, not 5.0.2+dfsg-1), so these PDFs remain in the Debian source. A proper fix would be to either: - exclude them via Files-Excluded + a +dfsg repack, or - document their actual license in debian/copyright. They aren't installed (only README.rst is in python3-greeneye-monitor.docs), so it's a source-only licensing gap, but still a DFSG-relevant defect. Packaging quality issues 2. debian/copyright Files: * claim is overbroad. Covering all files (including the PDFs above) under Expat obscures the real licensing situation. At minimum, the two PDFs should have their own Files: docs/* stanza. 3. Upstream-Contact is malformed — Jonathan Keljo, has a trailing comma and no email address. 4. debian/control binary package has no Depends field. It relies entirely on dh_python3's auto-dependency scanning to pick up the runtime deps (aiohttp, siobrultech-protocols). This generally works with pybuild-plugin-pyproject, but the runtime dependency on python3-siobrultech-protocols is declared only as a Build-Depends-Indep/test dep, and its availability in the archive is an implicit assumption that isn't visible in the binary package metadata. Hope this is useful. Thanks! | View |