Reviews for rauc-hawkbit-updater
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| awm | 1.4-1 | 2 months, 15 days ago | 2 months, 15 days ago | rejected | 2 months, 15 days ago | In the file include/config-file.h it is pretty explicit in the SPDX header that it is licensed as LGPL-2.1-only: /** * SPDX-License-Identifier: LGPL-2.1-only * SPDX-FileCopyrightText: 2018-2020 Lasse K. Mikkelsen <lkmi@prevas.dk>, Prevas A/S (www.prevas.com) */ I'm not sure why licensrecon picked on that file specifically though - that seems the case for a lot of files: $ grep -r LGPL-2.1-only . ./test/test_cancel.py:# SPDX-License-Identifier: LGPL-2.1-only ./test/conftest.py:# SPDX-License-Identifier: LGPL-2.1-only ./test/test_install.py:# SPDX-License-Identifier: LGPL-2.1-only ./test/test_download.py:# SPDX-License-Identifier: LGPL-2.1-only ./test/test_mtls.py:# SPDX-License-Identifier: LGPL-2.1-only ./test/helper.py:# SPDX-License-Identifier: LGPL-2.1-only ./test/rauc_dbus_dummy.py:# SPDX-License-Identifier: LGPL-2.1-only ./test/test_basics.py:# SPDX-License-Identifier: LGPL-2.1-only ./meson.build: license : 'LGPL-2.1-only', ./src/rauc-installer.c: * SPDX-License-Identifier: LGPL-2.1-only ./src/sd-helper.c: * SPDX-License-Identifier: LGPL-2.1-only ./src/rauc-hawkbit-updater.c: * SPDX-License-Identifier: LGPL-2.1-only ./src/config-file.c: * SPDX-License-Identifier: LGPL-2.1-only ./src/hawkbit-client.c: * SPDX-License-Identifier: LGPL-2.1-only ./src/log.c: * SPDX-License-Identifier: LGPL-2.1-only ./src/json-helper.c: * SPDX-License-Identifier: LGPL-2.1-only ./include/json-helper.h: * SPDX-License-Identifier: LGPL-2.1-only ./include/log.h: * SPDX-License-Identifier: LGPL-2.1-only ./include/hawkbit-client.h: * SPDX-License-Identifier: LGPL-2.1-only ./include/sd-helper.h: * SPDX-License-Identifier: LGPL-2.1-only ./include/config-file.h: * SPDX-License-Identifier: LGPL-2.1-only ./include/rauc-installer.h: * SPDX-License-Identifier: LGPL-2.1-only So perhaps you can have a chat with the upstream about what is going on. Perhaps they have a different understanding of what 'only' means. Thanks! | View |
| mechtilde | 1.4-1 | 1 month, 22 days ago | 1 month, 22 days ago | accepted | 1 month, 22 days ago | View |