Reviews for rust-minisign
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 0.9.1-1 | 1 month, 15 days ago | 1 month, 15 days ago | rejected | 1 month, 15 days ago | Thanks for your diligence. I've taken a look and noticed a couple of licensing details in debian/copyright that should be touched up before this can proceed to the archive: - src/crypto/blake2b.rs and src/crypto/util.rs: Both files include headers declaring dual licensing: "Licensed under the Apache License, Version 2.0 <...> or the MIT license <...> at your option." In debian/copyright, these files fall under the "Files: src/crypto/*" stanza with License: MIT, while only src/crypto/cryptoutil.rs is given "License: Apache-2.0 or MIT". Please include blake2b.rs and util.rs alongside cryptoutil.rs under the Apache-2.0 or MIT stanza. - src/crypto/sha512.rs: Line 2 carries the following notice: "//! (C) Frank Denis <fdenis [at] fastly [dot] com>, public domain" In debian/copyright, this file is currently covered by "Files: src/crypto/*" as MIT. It should have its own stanza documenting the public domain dedication and recording the verbatim author notice with the "<fdenis [at] fastly [dot] com>" address. Please update debian/copyright with these details in your next upload. -rt | View |
| siretart | 0.9.1-1 | 1 month, 14 days ago | 1 month, 14 days ago | accepted | 1 month, 14 days ago | View |