Reviews for tree-sitter-yaml
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 0.7.2-1 | 1 month, 8 days ago | 1 month, 8 days ago | rejected | 1 month, 8 days ago | ### 1. Placeholder Text in `debian/copyright` The file contains `TODO_YEARS` placeholders that must be replaced with actual copyright years: ``` Files: * Copyright: TODO_YEARS Ika <ikatyang@gmail.com> TODO_YEARS Amaan Qureshi <amaanq12@gmail.com> ``` **Evidence from `LICENSE` file:** ``` Copyright (c) 2024 tree-sitter-grammars contributors Copyright (c) 2019-2021 Ika ``` **Required Fix:** Replace the `TODO_YEARS` placeholders with the appropriate years (e.g., `2019-2021` for Ika and `2024` for the tree-sitter-grammars contributors). --- ### 2. Missing Copyright Holder The `LICENSE` file lists "tree-sitter-grammars contributors" as a copyright holder: ``` Copyright (c) 2024 tree-sitter-grammars contributors ``` However, `debian/copyright` does not include this entry for the `Files: *` stanza. **Required Fix:** Add "2024 tree-sitter-grammars contributors" to the copyright holders for `Files: *`. --- ## Required Fixes ### 3. Missing Coverage for `schema/*/src/tree_sitter/` Files The following files in the `schema/` subdirectories are copies of the same tree-sitter runtime header files that are documented for `src/tree_sitter/`: - `schema/json/src/tree_sitter/alloc.h` - `schema/json/src/tree_sitter/array.h` - `schema/json/src/tree_sitter/parser.h` - `schema/core/src/tree_sitter/alloc.h` - `schema/core/src/tree_sitter/array.h` - `schema/core/src/tree_sitter/parser.h` - `schema/legacy/src/tree_sitter/alloc.h` - `schema/legacy/src/tree_sitter/array.h` - `schema/legacy/src/tree_sitter/parser.h` These files should be covered by the same stanza (Max Brunsfeld, MIT license) as `src/tree_sitter/*.h`. **Required Fix:** Update the `Files:` stanza to include these paths, for example: ``` Files: src/tree_sitter/alloc.h src/tree_sitter/array.h src/tree_sitter/parser.h schema/*/src/tree_sitter/alloc.h schema/*/src/tree_sitter/array.h schema/*/src/tree_sitter/parser.h Copyright: 2018-2022, Max Brunsfeld License: MIT ``` | View |
| siretart | 0.7.2-1 | 1 month, 1 day ago | 1 month, 1 day ago | accepted | 1 month, 1 day ago | View |