Reviews for trilinos
All reviews for this package from team members (across all versions).
| Reviewer | Version | Allocated | Started | Status | Completed | Comment | |
|---|---|---|---|---|---|---|---|
| siretart | 17.0.0+dfsg-3 | 29 days ago | 29 days ago | rejected | 28 days ago | Thanks for your diligence in preparing this update and addressing the previous points. I've taken a look and found a few remaining DFSG details that need addressing before we can proceed: - The files under `packages/kokkos/` and `packages/kokkos-kernels/` have been updated with the LLVM exception, but the actual copyright holder string "Contributors to the Kokkos project" (which appears in thousands of files, e.g., `packages/kokkos-kernels/batched/KokkosBatched_Util.cpp`) is still entirely missing from `debian/copyright`. - While the catch-all stanza now includes "Sandia National Laboratories", there are still verbatim copyright notices that have been normalized or omitted. For example, "Sandia Corporation" appears in files like `packages/belos/tpetra/example/LSQR/LSQRTpetraExFile.cpp` and "National Technology Engineering Solutions of Sandia, LLC" (without the ampersand) appears in `packages/krino/` headers. These should be mirrored verbatim. - I noticed a slight slip in authorship for the generated EPS files. `packages/pamgen/rtcompiler/diag1.eps` and `diag2.eps` attribute copyright to "artofcode LLC, Benicia, CA", but this author is missing from `debian/copyright`. Please update the copyright file in your next upload. -rt | View |
| siretart | 17.0.0+dfsg-2 | 1 month, 8 days ago | 1 month, 8 days ago | rejected | 1 month, 6 days ago | Thanks for your diligence in preparing this update and addressing the previous rejection points. While the Bessel_I.C copyright and the Kokkos framework license documentation have been partially updated, a few issues and discrepancies remain. First, although the files under packages/kokkos/ have been updated, the copyright and license fields for the Kokkos kernels package under packages/kokkos-kernels/ remain undocumented in debian/copyright. This directory is still marked as Apache-2.0 and lists only NTESS as the copyright holder. The headers in these files (such as packages/kokkos-kernels/benchmarks/Benchmark_Utils.hpp) indicate they are licensed under Apache-2.0 WITH LLVM-exception and copyrighted by "Contributors to the Kokkos project", similar to the main Kokkos package. Second, the copyright entry added for packages/pamgen/rtcompiler/ Bessel_I.C has a slight typo: "1985, 1987, Stephen by Stephen L. Moshier". In addition to the "Stephen by Stephen" duplication, it misses the years 1984 and 2000 which are explicitly present in the copyright headers within the file (specifically "Copyright 1984, 1987, 2000 by Stephen L. Moshier" at line 169, and "Copyright 1985, 1987, 2000 by Stephen L. Moshier" at line 280). Lastly, there are a few copyright notices in the source that have been normalized in debian/copyright instead of being mirrored verbatim. For example, packages/panzer/mini-em/src/eqn_sets/ MiniEM_AuxiliaryEquationSet_MACROS.hpp lists "Copyright (c) 2015, Sandia National Laboratories" in the source header, but is documented under the NTESS entity name in debian/copyright. Similarly, packages/percept/src/percept/math/DenseMatrix.hpp lists "Copyright 2006 Sandia National Laboratories" and mentions the University of Wisconsin--Madison, but the copyright block in debian/copyright only references NTESS and Jason Kraftcheck's email. Additionally, I've checked the LPPL identifier in fancyhdr.sty. Since the files allow version 1 or any later version, they can be distributed under LPPL 1.3c (or later), which is DFSG-free, so the license definition in debian/copyright is compliant. -rt | View |
| siretart | 17.0.0+dfsg-1 | 1 month, 13 days ago | 1 month, 13 days ago | rejected | 1 month, 13 days ago | Thanks for your diligence in preparing this update. There are several significant licensing and copyright discrepancies that need to be addressed before this package can be accepted. First, there is a discrepancy in how the Kokkos framework is documented. The files under packages/kokkos and packages/kokkos-kernels are licensed under Apache-2.0 with LLVM exceptions (SPDX identifier: Apache-2.0 WITH LLVM-exception), and the copyright is held by "Contributors to the Kokkos project". However, in debian/copyright, these sections are documented as Apache-2.0 (without the exception) and only list specific institutional copyright holders (like NTESS). Since this affects nearly 2,500 files, the copyright file must be updated to include the Kokkos project contributors and the LLVM exception to be legally compliant and accurate. Second, there is a licensing omission in the Nevada RT compiler package. The file packages/pamgen/rtcompiler/Bessel_I.C incorporates a significant portion of the Cephes Math Library, which is copyrighted by Stephen L. Moshier (notably "Copyright 1984, 1987, 2000 by Stephen L. Moshier"). Currently, Stephen L. Moshier is not listed as a copyright holder in debian/copyright. This must be corrected by documenting his copyright block explicitly. -rt | View |