Review: ada-url 4.1.1-1
Package Information
| Description | WHATWG-compliant and fast URL parser A fast and spec-compliant URL parser written in C++. The Ada library passes the full range of tests from the specification, across a wide range of platforms (e.g., Windows, Linux, macOS). It fully supports the relevant Unicode Technical Standard. |
|---|---|
| Maintainer | Jérémy Lal <kapouer@debian.org> |
| Changed By | Jérémy Lal <kapouer@melix.org> |
| Sponsor | kapouer@melix.org |
| Distribution | experimental |
| Architecture | any all |
| VCS | git: https://salsa.debian.org/debian/ada-url.git (browse) |
| Popcon Installs | 2886 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/ada-url |
| Uploaded | 1 hour ago |
New Package Report
.changes
| Distribution | experimental |
|---|---|
| Date | Thu, 19 Nov 2026 21:25:26 +0100 |
| Source | ada-url |
| Version | 4.1.1-1 |
| Changed-By | Jérémy Lal <kapouer@melix.org> |
| Architecture | source amd64 all |
Changelog
ada-url (4.1.1-1) experimental; urgency=medium . * New upstream version 4.1.1 * Refresh patches
.dsc
| Section | libdevel |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | libada-url-dev deb libdevel optional arch=any libada-url-doc deb doc optional arch=all libada-url0-4 deb libs optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: Ada
Upstream-Contact: Daniel Lemire <daniel@lemire.me>
Yagiz Nizipli <yagiz@nizipli.com>
Source: https://github.com/ada-url/ada
Files: *
Copyright: 2022-2024, Daniel Lemire <daniel@lemire.me>
2022-2024, Yagiz Nizipli <yagiz@nizipli.com>
License: Apache-2.0 and Expat
Files: cmake/CPM.cmake
Copyright: 2019-2023, Lars Melchior and contributors
License: Expat
Files: cmake/codecoverage.cmake
Copyright: 2012-2017, Lars Bilke
License: BSD-3-Clause
Files: debian/*
Copyright: 2024-2025, Nicholas Guriev <guriev-ns@ya.ru>
License: Apache-2.0 and Expat
License: Apache-2.0
Licensed under the Apache License, Version 2.0 (the "License"); you may not
use this work except in compliance with the License. You may obtain a copy of
the License at http://www.apache.org/licenses/LICENSE-2.0
.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
License for the specific language governing permissions and limitations under
the License.
.
On Debian-based systems, you have the complete text of the License in file
/usr/share/common-licenses/Apache-2.0
License: BSD-3-Clause
Redistribution and use in source and binary forms, with or without modification,
are permitted provided that the following conditions are met:
1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
3. Neither the name of the copyright holder nor the names of its contributors
may be used to endorse or promote products derived from this software without
specific prior written permission.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
License: Expat
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 2 blocker, 0 important, 2 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 0 hours ago.
Report
DFSG NEW review for ada-url version 4.1.1-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 2 blocker, 0 important, 2 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: 2 found
Licensing
Every licence found is a free one (Apache-2.0, Expat/MIT, BSD-3-Clause, CC0-1.0, and the web-platform-tests BSD-3-Clause/W3C terms), no non-free wording applies to any file, and the README's 'research purposes only' sentence is about benchmark code, not a licence term. But debian/copyright does not accurately describe every file: the vendored CC0 header include/ada/expected.h is labelled Apache-2.0 and Expat and its author Sy Brand is not named, the MIT-derived IPv6 code in include/ada/url_ip-inl.h does not name Peter Fors, and the web-platform-tests data in tests/wpt/ is presented as the project's own dual-licensed work instead of WPT's BSD-3-Clause data.
Packaging
The packaging is solid: debhelper compat 13 with hardening, correct architecture-dependent/independent overrides, <!nocheck> and <!nodoc> used only for test/documentation-only dependencies, DEP-3 patches, a clean library/-dev/-doc split with Multi-Arch, and a current Standards-Version. The only defect found is a minor one: debian/libada-url-doc.doc-base registers the documentation under /usr/share/doc/libada-url-dev/html, where nothing is installed.
Issues
blocker licensing 1. debian/copyright calls include/ada/expected.h Apache-2.0 and Expat, but it is CC0-1.0 by Sy Brand ◂
- Files:
include/ada/expected.h:1-18,debian/copyright:7-10 - Basis: checked, in the package or with a reference tool
- Evidence:
include/ada/expected.h:// expected - An implementation of std::expected with extensions,// Written in 2017 by Sy Brand (tartanllama@gmail.com, @TartanLlama),To the extent possible under law, the author(s) have dedicated all copyright ... to the public domain worldwide ... You should have received a copy of the CC0 Public Domain Dedication.debian/copyright:Files: */Copyright: 2022-2024, Daniel Lemire ... 2022-2024, Yagiz Nizipli/License: Apache-2.0 and Expat. - Problem: This vendored tl::expected header is included by the library's public headers (url_pattern.h, url_pattern_helpers.h, url_pattern_list.h, implementation-inl.h, parser.h and others), compiled into libada-url0-4, and installed in libada-url-dev. Its copyright holder grants CC0-1.0, not the project's Apache-2.0/MIT dual licence, and debian/copyright has no stanza for it, names neither Sy Brand nor CC0. The licence is free, so this is not a DFSG problem in itself, but the copyright file attributes a licence the holder never gave, which is exactly the inaccuracy Policy 12.5 and the copyright-format require to be corrected. (Because the file is shipped as plain text with its notice in libada-url-dev, Policy 2.3 would by itself make the missing holder minor; the wrong licence is the blocker.)
- Fix: Add a
Files: include/ada/expected.hstanza withCopyright: 2017, Sy BrandandLicense: CC0-1.0, plus a stand-aloneLicense: CC0-1.0paragraph (the text is /usr/share/common-licenses/CC0-1.0).
blocker licensing 2. debian/copyright puts the web-platform-tests data in tests/wpt/ under Apache-2.0 and Expat and names no WPT copyright holder ◂
- Files:
tests/wpt/urltestdata.json,tools/update-wpt.sh:24-40,debian/copyright:7-10 - Basis: checked, in the package or with a reference tool
- Evidence:
tools/update-wpt.sh:git clone ... https://github.com/web-platform-tests/wpt.git wptthencp url/resources/*.json "$WPT_DIR"; README.md:428:Our tests include third-party code and data.Debian's own nodejs copyright describes wpt files asCopyright: web-platform-tests contributors/License: BSD-3-clause~contributors or W3C-Test-Suite. The ada copyright saysFiles: */License: Apache-2.0 and Expat. - Problem: The JSON files in tests/wpt/ (urltestdata.json, setters_tests.json, toascii.json, IdnaTestV2.json, percent-encoding.json, urlpatterntestdata.json etc., plus the files the patch/upstream names ada_*) are imported verbatim from web-platform-tests; those that come from WPT are third-party work under the WPT contributors' BSD-3-Clause or the W3C Test Suite License, not the Ada authors' Apache-2.0/MIT. debian/copyright has no stanza for them and claims the project licence for them. They are not installed in any binary package, so Policy 2.3 does not require their notices to be copied into debian/copyright, but the source package must still state their actual licence and holder.
- Fix: Add a
Files:stanza for the files imported from web-platform-tests (as listed by tools/update-wpt.sh) withCopyright: web-platform-tests contributors(together with W3C where the W3C Test Suite License applies) andLicense: BSD-3-Clause, whose text is already present; leave the Ada-authored ada_* additions under Files: *.
minor licensing 3. debian/copyright does not name Peter Fors, whose MIT-licensed IPv6 parser include/ada/url_ip-inl.h is derived from ◂
- Files:
include/ada/url_ip-inl.h:187-188,debian/copyright - Basis: checked, in the package or with a reference tool
- Evidence:
// Parse an IPv6 host with one masked 512-bit load. Derived from/// vtlmks/ipv6-avx512 (Peter Fors, MIT).debian/copyright's Files: * Copyright names only Daniel Lemire and Yagiz Nizipli. - Problem: The AVX-512 IPv6 parsing kernel in this header is a derivative of Peter Fors's MIT code; MIT requires its notice to be retained, and the file is compiled into libada-url0-4. The header itself, with the attribution, is installed unchanged as plain text in libada-url-dev, so Policy 2.3 does not require the notice to be copied into debian/copyright, but a complete debian/copyright should name the holder. (The character_sets Node.js attribution is left unconfirmed; see below.)
- Fix: Add
Files: include/ada/url_ip-inl.h/Copyright: Peter Fors/License: Expat, or add Peter Fors to the Copyright list of the existing stanza that covers the file.
minor packaging 4. libada-url-doc.doc-base registers the documentation under /usr/share/doc/libada-url-dev/html, where it is not installed ◂
- Files:
debian/libada-url-doc.doc-base:7-8,debian/libada-url-doc.docs:1-2 - Basis: checked, in the package or with a reference tool
- Evidence:
Files: /usr/share/doc/libada-url-dev/htmlandIndex: /usr/share/doc/libada-url-dev/html/index.html, while debian/libada-url-doc.docs installsREADME.mdanddocs/htmlinto libada-url-doc. - Problem: dh_installdocs installs debian/libada-url-doc.doc-base into libada-url-doc (the package in its name), and the HTML is installed by dh_installdocs into /usr/share/doc/libada-url-doc/html. libada-url-dev gets no HTML at all, so the doc-base registration points at a nonexistent file and dwww/doc-base show a broken document.
- Fix: Change both paths to /usr/share/doc/libada-url-doc/html and /usr/share/doc/libada-url-doc/html/index.html.
Verified ◂
- debian/copyright is DEP-5 with the canonical Format URL,
Files: *,Files: cmake/CPM.cmake(Expat, Lars Melchior),Files: cmake/codecoverage.cmake(BSD-3-Clause, Lars Bilke) andFiles: debian/*; the Expat and BSD-3-Clause texts are complete and Apache-2.0 points to /usr/share/common-licenses/Apache-2.0. There is no Files-Excluded and the tree is the unrepacked orig tarball. - Walked the whole tree (about 215 files, every directory listed with glob and checked with gitignore:false); there are no images, fonts, archives, PDFs or other binary files.
- Grepped the tree for Copyright, (C), (c), ©, SPDX-License-Identifier, 'Permission is hereby granted', 'Redistribution and use', 'Licensed under', MIT, Apache, MPL, GPL and 'public domain'. The only files carrying their own licence are LICENSE-APACHE, LICENSE-MIT, cmake/CPM.cmake (holder named, Expat), cmake/codecoverage.cmake (holder named, BSD-3-Clause), include/ada/expected.h (CC0, reported) and include/ada/url_ip-inl.h (MIT attribution, reported). The prescan's holder check found nothing because those last two notices do not contain the word 'Copyright'.
- README.md:428 '... provided for research purposes only and not part of the library' is a description of third-party benchmark code, not a licence term: debian/rules keeps ADA_BENCHMARKS off, nothing under benchmarks/ is installed, and the benchmark files are the project's own MIT/Apache work. .pc/no-remote-access-from-doc.patch/README.md is quilt's pre-patch copy of README.md, ignored as instructed.
- include/ada/ada_idna.h and src/ada_idna.cpp are marked auto-generated and synced from ada-url/idna. Each is a plain-text amalgamation holding the complete C++ headers and implementations used to build the library, not compiled output, and the build needs no generator; the amalgamation is the buildable source form.
- docs/html does not exist in the tree; it is generated during the build by the shipped doxygen config (OUTPUT_DIRECTORY = "docs", HTML_OUTPUT = html) and installed from debian/libada-url-doc.docs. The installed README.md differs only by the Debian anti-remote-image patch.
- tests/wpt/*.json are test data only: no install rule or .install file installs anything from tests/, fuzz/, benchmarks/ or tools/.
- Packaging: debhelper-compat (= 13), dh $@ with hardening=+all; override_dh_auto_configure-arch and the -indep override/hook are valid dh targets, and dh hoists the nocheck and nodoc profiles into DEB_BUILD_OPTIONS, so the rules conditionals and the empty configure-indep override behave as intended. libgtest-dev/libsimdjson-dev <!nocheck> are reached only when ADA_TESTING is on; libsimdutf-dev is used by the normal build. Patches carry DEP-3 headers; no maintainer scripts; Standards-Version 4.7.4 against Policy 4.7.4.1; Vcs-Git/Vcs-Browser present; gbp.conf sane.
- Binary split is consistent with the patched SONAME libada-url0.so.4: libada-url0-4 (Multi-Arch: same, shlibs via dh_makeshlibs), libada-url-dev (Multi-Arch: same, exact-version dependency, headers and .so symlink), libada-url-doc (Architecture: all, Multi-Arch: foreign, Recommends from -dev). ada.pc is generated with -lada-url0, matching the renamed library.
- No debian/tests/control (autopkgtest): optional, and the upstream test suite is run by dh_auto_test when the build is not nocheck.
- uscan found the packaged version as the newest upstream release (upstream
4.1.1, packaged4.1.1). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
- include/ada/character_sets.h and character_sets-inl.h credit Node.js as @author and link src/node_url_tables.cc; I could not determine whether the tables are copied (Node.js contributors, MIT, holder not named in debian/copyright) or independently written from the URL specification.
- The IDNA mapping tables embedded in src/ada_idna.cpp appear to be generated from Unicode's IdnaMappingTable.txt (referenced in include/ada/unicode.h); debian/copyright carries no Unicode, Inc. stanza, and I could not confirm whether the generated tables are covered by the Unicode data licence's notice requirement.
- No build or runtime test was possible in this read-only environment; nothing above depends on a build succeeding.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader rejected this upload in response to the review.
Review Information
rejected — allocated to dfsg-uploader 0 hours ago, started 0 hours ago, completed 0 hours ago.
Final Comment
The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 3.3.0-1 | de647840… | 2026-02-14 05:49 | 2026-02-14 05:56 | awm | accepted | VIEW |