DFSG NEW Queue

DFSG, Licensing & New Packages Team

amd-device-libs-21 7.1.1+ds-1~exp1

Package Information

DescriptionAMD specific device-side language runtime libraries

Set of AMD specific device-side language runtime libraries, specifically: the Open Compute library controls, the Open Compute Math library, the Open Compute Kernel library, the OpenCL built-in library, the HIP built-in library, and the Heterogeneous Compute built-in library.

MaintainerDebian ROCm Team <debian-ai@lists.debian.org>
Changed ByCordell Bloor <cgmb@debian.org>
Sponsorcgmb@debian.org
Distributionexperimental
Architectureany
VCSgit: https://salsa.debian.org/rocm-team/amd-device-libs.git (browse)
Trackerhttps://tracker.debian.org/pkg/amd-device-libs-21
Uploaded2 hours ago

Takes Over Existing Binary Packages

This upload builds binary packages that a different source package currently builds in unstable. Check that the takeover is intended and explained, for example in the changelog.

BinaryCurrently built by
rocm-device-libs-21rocm-llvm

New Package Report

.changes◂
Architecturesource amd64
Distributionexperimental
DateThu, 12 Nov 2026 21:44:36 -0600
Sourceamd-device-libs-21
Version7.1.1+ds-1~exp1
Changed-ByCordell Bloor <cgmb@debian.org>
Changelog◂
amd-device-libs-21 (7.1.1+ds-1~exp1) experimental; urgency=medium
 .
   * Initial packaging
     * Move rocm-device-libs-21 binary package out of src:rocm-llvm
       into src:amd-device-libs-21
.dsc◂
Sectionlibs
Priorityoptional
Componentmain
Package-Listrocm-device-libs-21 deb libs optional arch=any
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: llvm-project
Source: https://github.com/ROCm/llvm-project
Files-Excluded: amd/comgr
                amd/git-hooks
                amd/hipcc
                amd/README.md
                amd/utils
                .azuredevops
                .ci
                .clang-format
                .clang-tidy
                .git-blame-ignore-revs
                .gitattributes
                .github
                .gitignore
                .mailmap
                CODE_OF_CONDUCT.md
                CONTRIBUTING.md
                LICENSE.TXT
                README.md
                SECURITY.md
                bolt
                clang
                clang-tools-extra
                cmake
                compiler-rt
                cross-project-tests
                flang
                flang-rt
                libc
                libclc
                libcxx
                libcxxabi
                libunwind
                lld
                lldb
                llvm
                llvm-libgcc
                mlir
                offload
                openmp
                polly
                pstl
                pyproject.toml
                revert_patches.txt
                runtimes
                third-party
                utils
Comment: These are LLVM sources from upstream repository, but
 we only want to build the device-libs component. We isolate the
 device-libs for two reasons: (1) there's a B-D chain where comgr
 needs rocr-runtime, which needs the device-libs, which is cyclical
 if comgr and device-libs are produced by from the same source
 package, and (2) the device-libs binaries are compiled to LLVM bitcode
 and are therefore only guaranteed to be compatible with the LLVM
 major version that built them.

Files: amd/device-libs/*
Copyright: 2014-2016, Advanced Micro Devices, Inc.
License: NCSA

Files: debian/*
Copyright: 2022, Maxime Chambonnet <maxzor@maxzor.eu>
           2022-2023, Étienne Mollier <emollier@debian.org>
           2022-2026, Cordell Bloor <cgmb@debian.org>
           2024, Xuanteng Huang <xuanteng.huang@outlook.com>
License: Expat
Comment: The debian metafiles originated from src:rocm-llvm, but have had
 further modifications and updates.

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in
 all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.

License: NCSA
 University of Illinois/NCSA
 Open Source License
 .
 All rights reserved.
 .
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal with
 the Software without restriction, including without limitation the rights to
 use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
 of the Software, and to permit persons to whom the Software is furnished to do
 so, subject to the following conditions:
 .
 * Redistributions of source code must retain the above copyright notice,
   this list of conditions and the following disclaimers.
 * Redistributions in binary form must reproduce the above copyright notice,
   this list of conditions and the following disclaimers in the
   documentation and/or other materials provided with the distribution.
 * Neither the names of the LLVM Team, University of Illinois at
   Urbana-Champaign, nor the names of its contributors may be used to
   endorse or promote products derived from this Software without specific
   prior written permission.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
 CONTRIBUTORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS WITH THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 1 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 hour ago.

Report◂

DFSG NEW review for amd-device-libs-21 version 7.1.1+ds-1~exp1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: Yes
  • Issues: 1 blocker, 0 important, 0 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

All licences present are DFSG-free: NCSA over amd/device-libs, Expat over debian/, and Sun's permissive fdlibm notice in four ocml files. No non-free terms, no built artifacts, no third-party code without a notice. But debian/copyright is inaccurate for those four files: it attributes all of amd/device-libs to AMD under NCSA, and neither names Sun Microsystems, Inc. nor reproduces the Sun permission text that the files, and the bitcode built from them, carry.

Packaging

Clean, conventional CMake package: debhelper-compat 14, a small well-chosen override set, a DEP-3 patch marked applied upstream, an accurate changelog and README.source explaining the source split and binary takeover, gbp and salsa-ci configuration, upstream/metadata, and a correct repack (the orig tarball holds only amd/device-libs). No maintainer scripts and no policy violation found; the test suite runs through dh_auto_test with FileCheck supplied by llvm-21.

Issues

blocker licensing 1. debian/copyright does not name Sun Microsystems, Inc. nor include the Sun fdlibm licence for four ocml sources ◂
  • Files: debian/copyright, amd/device-libs/ocml/src/erfcD.cl:32, amd/device-libs/ocml/src/erfcF.cl:32, amd/device-libs/ocml/src/lgamma_rD.cl:15, amd/device-libs/ocml/src/lgamma_rF.cl:14
  • Basis: checked, in the package or with a reference tool
  • Evidence: Files: amd/device-libs/* gives Copyright: 2014-2016, Advanced Micro Devices, Inc. and License: NCSA, while lgamma_rD.cl:10 says "This lgamma routine began with Sun's lgamma code from netlib", and all four files contain Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved. and Permission to use, copy, modify, and distribute this software is freely granted, provided that this notice is preserved.
  • Problem: These files contain Sun code, so their copyright and licence are not what the single NCSA stanza says. Policy 12.5 requires a verbatim copy of the package's distribution licences and copyright-format 1.0 6.8 requires the Copyright field to collect every notice applying to the matched files. The Sun notice also requires that it be preserved and reproduced when the derived code is redistributed, and the binary package ships bitcode built from these files whose only licence documentation is debian/copyright.
  • Fix: After the Files: amd/device-libs/* stanza add a stanza for amd/device-libs/ocml/src/erfcD.cl, erfcF.cl, lgamma_rD.cl and lgamma_rF.cl with Copyright: 1993, Sun Microsystems, Inc. and License: NCSA and Sun-fdlibm, plus a stand-alone paragraph defining Sun-fdlibm with the sentence Permission to use, copy, modify, and distribute this software is freely granted, provided that this notice is preserved.
Verified ◂
  • The scan's single holder, Sun Microsystems, Inc in amd/device-libs/ocml/src/erfcD.cl, erfcF.cl, lgamma_rD.cl and lgamma_rF.cl, is real: those four files carry Sun's 1993 fdlibm notice, which grants free use, copying, modification and distribution with the notice preserved, so the files themselves are DFSG-free; only debian/copyright is inaccurate, as reported.
  • All 712 upstream files are matched by Files: amd/device-libs/* or Files: debian/*; 670 carry the "distributed under the University of Illinois Open Source License" banner, and no file carries a licence other than NCSA or Expat.
  • amd/device-libs/LICENSE.TXT (NCSA, AMD 2014-2016) and README.md read; the copyright file's NCSA text matches LICENSE.TXT; the ockl/inc/*.h files' own 2014-2015 NCSA notices are covered by the same stanza (year drift only).
  • Grepping the whole tree for Copyright/(C)/SPDX-License-Identifier/Licensed under/Permission is hereby granted/GNU/Apache/Mozilla/public domain/All rights reserved found no other holder and no non-free wording.
  • No built files, bitcode, objects, archives, minified code, PDFs, images, fonts or sounds in the tree; doc/OCKL.md and doc/OCML.md are hand-written markdown, and the .ll files are source LLVM IR, not generated artifacts.
  • amd-device-libs-21_7.1.1+ds.orig.tar.xz contains only llvm-project-rocm-7.1.1/amd/device-libs, consistent with Files-Excluded; no excluded path remains in the tree.
  • All files of debian/ read: control, rules, changelog, copyright, README.source, gbp.conf, salsa-ci.yml, ci-piuparts.sh, files-excluded.sh, not-installed, rocm-device-libs-21.install, source/format, upstream/metadata and the single patch with its series.
  • debian/not-installed still lists hipcc paths from src:rocm-llvm (usr/bin/hipconfig, usr/bin/hipvars.pm, usr/hip/); nothing here produces them, the entries are inert, and usr/share/doc/ masks upstream's LICENSE.TXT install.
  • The -O--buildsystem=cmake -O--builddirectory=... arguments to dh_auto_install are valid: Dh_Getopt handles -O and re-parses its value against the command's buildsystem options (Dh_Getopt.pm:161,185-195); dh_auto_build/dh_auto_test pick the makefile buildsystem from the generated build.device-libs/Makefile (makefile.pm:119-131), so no --sourcedir is needed there.
  • Build-Depends suffice for the tests: llvm-21-dev depends on llvm-21-tools and llvm-21 (apt-cache), which supply FileCheck ($LLVM_DIR/../../../bin, test/compile/CMakeLists.txt:12-17) and clang; without FileCheck the tests skip themselves.
  • Standards-Version 4.7.4 is current against the reviewing system's Policy 4.7.4.1; the changelog date (Thu, 12 Nov 2026) matches the weekday; 7.1.1+ds-1~exp1 is a higher version than the archived rocm-device-libs-21 7.0.2+dfsg-4 from src:rocm-llvm, whose Section libs and Architecture amd64 the new package keeps; no maintainer scripts, .maintscript files or debian/tests exist.
  • The install file matches what CMake installs: bitcode to usr/amdgcn/bitcode (mapped to /usr/lib/llvm-21/lib/clang/21) and AMDDeviceLibsConfig.cmake to lib//cmake/AMDDeviceLibs, per cmake/OCL.cmake and cmake/Packages.cmake.
  • uscan found upstream releases with debian/watch; a newer upstream version is available (upstream 7.2.4, packaged 7.1.1+ds), which is not a fault of the package.
Not confirmed ◂
  • debian/rules passes no -DLLVM_DIR and no CMAKE_PREFIX_PATH, while amd/device-libs/CMakeLists.txt:38 runs find_package(LLVM REQUIRED); on this system LLVMConfig.cmake is at /usr/lib/llvm-21/cmake and /usr/lib/llvm-21/lib/cmake/llvm, neither a default CMake search prefix, and installed cmake 4.4 adds no /usr/lib/llvm-* path. A clean-chroot build would show whether configure finds LLVM or fails at that find_package; the maintainer's build presumably passed, so this is noted rather than reported.
Proposed changes ◂

None.

Uploader's response to the LLM review

Waiting for the uploader's response until , because the review found serious issues.

Back to Dashboard | View all reviews for this package