DFSG NEW Queue

DFSG, Licensing & New Packages Team

amd-device-libs-23 10.1+ds-1~exp1

Package Information

DescriptionAMD specific device-side language runtime libraries

Set of AMD specific device-side language runtime libraries, specifically: the Open Compute library controls, the Open Compute Math library, the Open Compute Kernel library, the OpenCL built-in library, the HIP built-in library, and the Heterogeneous Compute built-in library.

MaintainerDebian ROCm Team <debian-ai@lists.debian.org>
Changed ByCordell Bloor <cgmb@debian.org>
Sponsorcgmb@debian.org
Distributionexperimental
Architectureany
VCSgit: https://salsa.debian.org/rocm-team/amd-device-libs.git (browse)
Trackerhttps://tracker.debian.org/pkg/amd-device-libs-23
Uploaded2 hours ago

New Package Report

.changes◂
DateSun, 15 Nov 2026 21:18:04 -0600
Sourceamd-device-libs-23
Version10.1+ds-1~exp1
Changed-ByCordell Bloor <cgmb@debian.org>
Architecturesource amd64
Distributionexperimental
Changelog◂
amd-device-libs-23 (10.1+ds-1~exp1) experimental; urgency=medium
 .
   * Initial packaging
.dsc◂
Sectionlibs
Priorityoptional
Componentmain
Package-Listamd-device-libs-23 deb libs optional arch=any
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: llvm-project
Source: https://github.com/ROCm/llvm-project
Files-Excluded: amd/comgr
                amd/docs
                amd/hipcc
                amd/tools
                .ci
                .clang-format
                .clang-format-ignore
                .clang-tidy
                .cursor
                .git-blame-ignore-revs
                .gitattributes
                .github
                .gitignore
                .mailmap
                CODE_OF_CONDUCT.md
                CONTRIBUTING.md
                LICENSE.TXT
                README.md
                SECURITY.md
                bolt
                clang
                clang-tools-extra
                cmake
                compiler-rt
                cross-project-tests
                flang
                flang-rt
                libc
                libclc
                libcxx
                libcxxabi
                libsycl
                libunwind
                lld
                lldb
                llvm
                llvm-libgcc
                mlir
                offload
                openmp
                orc-rt
                polly
                pyproject.toml
                revert_patches.txt
                runtimes
                third-party
                utils
Comment: These are LLVM sources from upstream repository, but
 we only want to build the device-libs component. We isolate the
 device-libs for two reasons: (1) there's a B-D chain where comgr
 needs rocr-runtime, which needs the device-libs, which is cyclical
 if comgr and device-libs are produced by from the same source
 package, and (2) the device-libs binaries are compiled to LLVM bitcode
 and are therefore only guaranteed to be compatible with the LLVM
 major version that built them.

Files: amd/device-libs/*
Copyright: 2014-2016, Advanced Micro Devices, Inc.
License: NCSA

Files: amd/device-libs/ocml/src/erfcD.cl
       amd/device-libs/ocml/src/erfcF.cl
       amd/device-libs/ocml/src/lgamma_rD.cl
       amd/device-libs/ocml/src/lgamma_rF.cl
Copyright: 2014-2016, Advanced Micro Devices, Inc.
           1993, Sun Microsystems, Inc.
License: NCSA and SunPro
Comment: These files began with Sun's netlib erf/lgamma implementations and
 were extended by AMD. AMD's contributions are distributed under NCSA, while
 the SunPro permissive notice is retained for the portions derived from Sun's
 original code, as required by that notice.

Files: debian/*
Copyright: 2022, Maxime Chambonnet <maxzor@maxzor.eu>
           2022-2023, Étienne Mollier <emollier@debian.org>
           2022-2026, Cordell Bloor <cgmb@debian.org>
           2024, Xuanteng Huang <xuanteng.huang@outlook.com>
           2024, Christian Kastner <ckk@debian.org>
           2025, Igor Luppi <igor.luppi@canonical.com>
           2025-2026, Talha Can Havadar <havadartalha@gmail.com>
License: Expat
Comment: The debian metafiles originated from src:rocm-llvm, but have had
 further modifications and updates.

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in
 all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.

License: SunPro
 Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved.
 .
 Developed at SunPro, a Sun Microsystems, Inc. business.
 Permission to use, copy, modify, and distribute this
 software is freely granted, provided that this notice
 is preserved.

License: NCSA
 University of Illinois/NCSA
 Open Source License
 .
 All rights reserved.
 .
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal with
 the Software without restriction, including without limitation the rights to
 use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
 of the Software, and to permit persons to whom the Software is furnished to do
 so, subject to the following conditions:
 .
 * Redistributions of source code must retain the above copyright notice,
   this list of conditions and the following disclaimers.
 * Redistributions in binary form must reproduce the above copyright notice,
   this list of conditions and the following disclaimers in the
   documentation and/or other materials provided with the distribution.
 * Neither the names of the LLVM Team, University of Illinois at
   Urbana-Champaign, nor the names of its contributors may be used to
   endorse or promote products derived from this Software without specific
   prior written permission.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
 CONTRIBUTORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS WITH THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 2 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 hour ago.

Report◂

DFSG NEW review for amd-device-libs-23 version 10.1+ds-1~exp1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: Yes
  • Packaging is of good quality: Yes
  • Issues: 0 blocker, 0 important, 2 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

debian/copyright is DEP-5 with the correct Format line and covers every file: amd/device-libs/* is NCSA via LICENSE.TXT and the per-file headers, the four netlib/Sun-derived ocml files are correctly carved out as NCSA and SunPro, and debian/* is Expat. Full NCSA, SunPro and Expat texts are present, no non-free terms or missing licences exist, and the pre-scan found no missing holder. No built binaries, minified code or PDFs are in the source.

Packaging

The packaging is solid: debhelper compat 14, current Standards-Version, correct Build-Depends for LLVM 23, hardened build, 3.0 (quilt) source format with no patches, and clean install/not-installed handling. Two minor quality points remain: the binary is declared Architecture: any although it installs only host-independent bitcode and CMake text, and the only autopkgtest declares unavailable and unused dependencies so it will be skipped.

Issues

minor packaging 1. Architecture: any for a package containing only architecture-independent bitcode and CMake text ◂
  • Files: debian/control:18, debian/amd-device-libs-23.install:1-2
  • Basis: inferred from what was read, not seen directly
  • Evidence: debian/control: Architecture: any; the install file lists only usr/lib/llvm-23/lib/clang/23/lib/amdgcn and usr/lib/llvm-23/lib/cmake/AMDDeviceLibs. The comparable libclc-23, which also ships amdgcn bitcode, is Architecture: all with Multi-Arch: foreign (apt-cache).
  • Problem: amdgcn LLVM bitcode and CMake configuration files are host-independent data; nothing in the package is compiled for the build architecture. Declaring the package any causes it to be built and tested once per Debian architecture and prevents it from being treated as architecture-independent, contrary to the meaning of the Architecture field (Policy 5.6.8).
  • Fix: Change Architecture: any to Architecture: all in debian/control (the .dsc Architecture follows), and consider Multi-Arch: foreign as libclc-23 does.
minor packaging 2. Autopkgtest declares unavailable and unused dependencies, so the only test is skipped ◂
  • Files: debian/tests/control:2-3, debian/tests/cmake-find-package:13-43
  • Basis: checked, in the package or with a reference tool
  • Evidence: debian/tests/control: Depends: @, cmake, make, gcc, libamdhip64-dev (>= 7.0~), clang-23, llvm-23, lld-23, clang-tools-23, libclang-rt-23-dev and Restrictions: superficial, skippable; the script only runs cmake -S. -Bbuild -DCMAKE_PREFIX_PATH=/usr/lib/llvm-23 on a generated CMakeLists.txt. apt-cache lists libamdhip64-dev only at 6.4.3-6.
  • Problem: The test does not use libamdhip64-dev, clang-23, llvm-23, lld-23, clang-tools-23 or libclang-rt-23-dev; it only needs the package itself, cmake, make and gcc. Because the requested libamdhip64-dev (>= 7.0~) is not in the archive and the test is marked skippable, autopkgtest will silently skip the package's only test, leaving it without test coverage.
  • Fix: Reduce Depends to @, cmake, make, gcc; if HIP/LLVM integration is actually intended, add the corresponding commands to the test and use a libamdhip64-dev version available in the archive (or keep the test conditional by design).
Verified ◂
  • Read every file under debian/; there is no debian/patches, so the source is upstream plus packaging.
  • Inventoried amd/device-libs directory by directory and grepped the whole tree for copyright and licence wording; the only non-AMD notices are the SunPro notices in ocml/src/erfcD.cl, erfcF.cl, lgamma_rD.cl and lgamma_rF.cl, and each is covered by the specific debian/copyright stanza.
  • The pre-scan listed no files and reported that every holder it found is named in debian/copyright; no built binaries, minified code, PDFs, fonts or images are present in the source.
  • debian/copyright is DEP-5 with the exact Format URL, full NCSA, SunPro and Expat texts, and Files patterns that cover amd/device-libs/* and debian/*; the four Sun files are later, overriding stanzas.
  • The upstream LICENSE.TXT is NCSA and is deliberately not installed via debian/not-installed, but the NCSA notice is reproduced in the package's debian/copyright, which dh_installdocs installs under /usr/share/doc/amd-device-libs-23/copyright.
  • Standards-Version 4.7.4 is current against Policy 4.7.4.1; debhelper-compat is 14; the build is hardened and the source format is 3.0 (quilt).
  • Checked debian/tests/cmake-find-package, debian/tests/control, debian/gbp.conf, debian/salsa-ci.yml, debian/ci-piuparts.sh, debian/upstream/metadata, debian/files-excluded.sh and debian/not-installed; the test script only invokes cmake.
  • Checked apt-cache for clang-23, libclang-23-dev, llvm-23-dev, libclc-23 and libamdhip64-dev; the LLVM 23 packages exist at 23.1.5-2, libclc-23 is Architecture: all, and libamdhip64-dev is 6.4.3-6.
  • debian/rules' override_dh_dwz is inert at compat 14 because dh_dwz is no longer in the dh sequence; it is harmless and not reported as an issue.
  • uscan found the packaged version as the newest upstream release (upstream 10.1, packaged 10.1+ds).
Not confirmed ◂
  • No build was attempted, and no build failure is asserted; in particular, the CMake configure's discovery of LLVMConfig.cmake without an explicit LLVM_DIR was not verified.
  • The autopkgtest was not executed; its skip is inferred from the versioned dependency being absent from the package lists.
  • The BTS was not consulted, so whether an ITP exists for the initial upload (the changelog has no Closes:) could not be confirmed.
  • Why the model asked for what a review has no use for. During this review it asked once for something outside the package and the reviewing system (another file of the sandbox, or a URL), or was given part of the review tooling's own configuration, and that was refused or withheld. A model does this when something it has read tells it to, so look in the package for text addressed to a reviewing program, and treat this report with suspicion. Refused: read: "xd://read/sources" is not a file of the package or of the reviewing system.
Proposed changes ◂

None.

Uploader's response to the LLM review

The LLM reported issues are valid, but I don't think they're blockers. I fixed all the minor problems reported in the LLM reviews of src:amd-device-libs-21 and src:amd-device-libs-22 in this upload of src:amd-device-libs-23, so I presume that fixing the previous issues has pushed it to dig deeper. I'm glad that the LLM can find more to improve, but the current quality already exceeds the level of the existing packages in the archive that this was derived from.

We've been shipping {rocm,amd}-device-libs* packages as arch: any as a precaution since they were introduced in Bookworm. The LLM pointing out libclc-23 is arch: all is interesting and does suggest that this bitcode probably compatible between the same LLVM versions on different host architectures. I'll file a bug to track this question, check if the existing packages are bit-for-bit identical between architectures, and then ask the upstream developers their opinion.

With regard to the autopkgtests. It's true that the dependency list includes unnecessary dependencies. Those were for a test that I temporarily removed. I'd copied d/t/hip-clang-build from src:amd-device-libs-22 and modified it for clang-23, but I then removed the test because it would fail due to https://bugs.debian.org/1153852 (clang-23: fails to link libamdhip64 when compiling hip sources). The bug has nothing to do with the device-libs, but the test will not pass until that bug is fixed. When the clang-23 bug is fixed, I'll put d/t/hip-clang-build back and those dependencies will no longer be unused. I could have deleted them, but why bother micro-optimizing for a temporary situation?

The libamdhip64-dev 7.2.4-1~exp2 package on experimental is sufficient for the autopkgtests to run, and I've verified them to be passing with autopkgtest amd-device-libs-23_10.1+ds-1~exp1_amd64.changes --add-apt-release=experimental -- unshare --release experimental --arch amd64 on my local machine.

— Cordell Bloor (cgmb), 0 hours ago

Back to Dashboard | View all reviews for this package