Review: aqlprofile 7.2.4+ds-1~exp1
Package Information
| Description | GPU profiling and tracing on AMD platforms AQLprofile (Architected Queuing Language Profiling Library) is an open source library that enables advanced GPU profiling and tracing on AMD platforms. It works in conjunction with rocprofiler-sdk to support profiling methods such as performance counters (PMC) and SQ thread trace (SQTT). AQLprofile provides the foundational mechanisms for constructing AQL packets and managing profiling operations across multiple AMD GPU architecture families. |
|---|---|
| Maintainer | Debian ROCm Team <debian-ai@lists.debian.org> |
| Changed By | Bastien Roucariès <rouca@debian.org> |
| Sponsor | rouca@debian.org |
| Distribution | experimental |
| Architecture | any |
| VCS | git: https://salsa.debian.org/rocm-team/aqlprofile.git (browse) |
| Closes | #1111528 |
| Tracker | https://tracker.debian.org/pkg/aqlprofile |
| Uploaded | 1 month, 4 days ago |
New Package Report
.changes
| Changed-By | Bastien Roucariès <rouca@debian.org> |
|---|---|
| Architecture | source amd64 |
| Distribution | experimental |
| Date | Sun, 04 Oct 2026 19:41:13 +0200 |
| Source | aqlprofile |
| Version | 7.2.4+ds-1~exp1 |
Changelog
aqlprofile (7.2.4+ds-1~exp1) experimental; urgency=medium . * Initial release. (Closes: #1111528)
.dsc
| Section | devel |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | libhsa-amd-aqlprofile64-1 deb devel optional arch=any libhsa-amd-aqlprofile64-1-dev deb devel optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: <url://example.com> Upstream-Name: aqlprofile Upstream-Contact: https://github.com/ROCm/rocm-systems/ Files-Excluded: * Files-Included: projects/aqlprofile/* Files: * Copyright: 2014-2025 Advanced Micro Devices, Inc. License: Expat Files: debian/* Copyright: 2026 Bastien Roucariès License: Expat License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Review Information
rejected — allocated to awm 30 days ago, started 30 days ago, completed 30 days ago.
Final Comment
Hi,
Some issues in debian/copyright
C1 — Placeholder Source: field. debian/copyright:2 is Source: url://example.com. That is a sentinel, not the upstream location (which the package itself documents as https://github.com/ROCm/rocm-systems/tree/develop/projects/aqlprofile).
Fix: put the real upstream/tag URL.
C2 — Non-standard Files-Included field(s). debian/copyright:6 uses Files-Included: projects/aqlprofile/*, which is not part of the DEP-5 copyright-format/1.0 spec, and uscan's documented repack is driven by Files-Excluded alone — which here is * (line 5). So the automatic repack cannot be sel-sustained from the watch/copyright pair: Files-Excluded: * would strip everything and Files-Included is ignored by the tools. The maintainer must document/reproduce how the projects/aqlprofile-only tarball is produced (manual repack), or uscan-driven builds will yield an empty or wrong source tree.
Fix: replace the pair with a mechanism uscan/licensecheck can act on, or add a comment explaining the manual repack.
Some issues with packaging in general
P1 — Likely FTBFS: install globs vs. hard-coded non-multiarch CMAKE_INSTALL_LIBDIR (blocker).
projects/aqlprofile/CMakeLists.txt sets set(CMAKE_INSTALL_LIBDIR "lib" CACHE STRING …) (overriding the GNUInstallDirs default), and debhelper deliberately omits its -DCMAKE_INSTALL_LIBDIR=lib/ argument when the project's CMakeLists already mentions CMAKE_INSTALL_LIBDIR (compat 14 behaviour). The library therefore installs to /usr/lib, not /usr/lib/. But debian/libhsa-amd-aqlprofile64-1.install and …-dev.install only match usr/lib//lib.so.* / usr/lib//lib.so — the * requires a subdirectory that won't exist. dh_install will fail with "Cannot find (any matches for)". Given debhelper's documented skip behaviour this will almost certainly break the build; it must be verified with dpkg-buildpackage. Fix options: override_dh_auto_configure passing -DCMAKE_INSTALL_LIBDIR=lib/$(DEB_HOST_MULTIARCH), or change the install globs to usr/lib/lib*.so* (and accept the non-multiarch layout).
P2 — debian/watch targets the wrong repository (blocker).
Template: GitHub with Project: rocm-system (line 3) — the trailing "s" is missing. debian/control Homepage and debian/copyright Source both say ROCM/rocm-systems. uscan will query github.com/ROCm/rocm-system, not the repository that contains projects/aqlprofile, so it either fails or watches the wrong project. Fix: Project: rocm-systems. (Version handling otherwise checks out: rocm-@ANY_VERSION@ matches a rocm-7.2.4 tag for the 7.2.4+ds changelog version, Uversion-Mangle: auto + Repack-Suffix: +ds are consistent, and the v5 format is correct.)
P3 — debian/upstream/metadata describes the wrong project (real, must fix).
Every field points at ROCm/rocprofiler-register (Repository, Repository-Browse, Bug-Database, Bug-Submit, Documentation), which is a different ROCm component — an obvious copy-paste from another package. For aqlprofile these should reference ROCm/rocm-systems (and its issue tracker). This ends up in /usr/share/doc and confuses consumers and DPT tools.
P4 — debian/copyright Source: placeholder (same as C1)
also goes into the binary package's copyright file; fix with P2/P3.
Thanks!
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 7.2.4+ds-1~exp1 | 95d8f805… | 2026-10-09 06:31 | 2026-10-09 09:18 | awm | accepted | VIEW |