Review: crispy 2026.0+ds-2
Package Information
| Description | Core-Level Spectroscopy Simulations in Python Crispy is a modern graphical user interface to calculate core-level spectra using the semi-empirical multiplet approaches implemented in Quanty. The application provides tools to generate input files, submit calculations, and plot the resulting spectra. |
|---|---|
| Maintainer | Debian Science Maintainers <debian-science-maintainers@lists.alioth.debian.org> |
| Changed By | Roland Mas <lolando@debian.org> |
| Sponsor | lolando@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/science-team/crispy.git (browse) |
| Tracker | https://tracker.debian.org/pkg/crispy |
| Uploaded | 1 month, 4 days ago |
New Package Report
.changes
| Changed-By | Roland Mas <lolando@debian.org> |
|---|---|
| Architecture | source amd64 |
| Distribution | unstable |
| Date | Sun, 04 Oct 2026 18:45:03 +0200 |
| Source | crispy |
| Version | 2026.0+ds-2 |
Changelog
crispy (2026.0+ds-2) unstable; urgency=medium . * Update debian/copyright. * Remove binaries from source package to fix Lintian warnings. . crispy (2026.0+ds-1) unstable; urgency=medium . * Initial packaging.
.dsc
| Section | science |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | crispy deb science optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: Crispy
Upstream-Contact: Marius Retegan <marius.s.retegan@gmail.com>
Source: https://github.com/mretegan/crispy
Files-Excluded:
src/crispy/quanty/bin/*
src/crispy/quanty/parameters/cowan/bin/*
Files: *
Copyright:
Marius Retegan <marius.s.retegan@gmail.com>
2016-2026 European Synchrotron Radiation Facility
License: MIT
Files: src/crispy/uic.py
Copyright:
2016-2026 European Synchrotron Radiation Facility
2015 Chris Beaumont and Thomas Robitaille
2011 Sebastian Wiesner <lunaryorn@gmail.com>
Charl Botha <cpbotha@vxlabs.com>
License: BSD-3-Clause
Comment:
This code is "adapted from qt-helpers which was released under a
3-clause BSD license […] Copyright (c) 2015, Chris Beaumont and
Thomas Robitaille […] Which itself was based on the solution at
[gist.github.com] which was released under the MIT license: Copyright
(c) 2011 Sebastian Wiesner <lunaryorn@gmail.com> Modifications by
Charl Botha <cpbotha@vxlabs.com>"
Files: debian/*
Copyright:
Roland Mas <lolando@debian.org>
License: MIT
License: MIT
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:
.
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
License: BSD-3-Clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:
.
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the
distribution.
* Neither the name of the Glue project nor the names of its contributors
may be used to endorse or promote products derived from this software
without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 1 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 24 days ago.
Report
DFSG NEW review for crispy version 2026.0+ds-2
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 1 minor
- debian/watch: version 5
- debian/copyright: machine-readable
Licensing
DFSG-compliant and debian/copyright is accurate and complete. The whole upstream is MIT (copyright Marius Retegan and 2016-2026 European Synchrotron Radiation Facility), single LICENSE.rst / pyproject / CITATION all MIT; the only file with other notices is src/crispy/uic.py (adapted qt-helpers, BSD-3-Clause with an MIT-derived part), which is given its own Files: stanza with the right holders. Grepping the whole tree for licence markers found no other notices, no non-free terms, no unlicensed files and no minified/obfuscated content. The Files-Excluded entries (src/crispy/quanty/bin/* and src/crispy/quanty/parameters/cowan/bin/*, the proprietary Quanty and Cowan binaries) are both confirmed absent from the tree. One minor inaccuracy: the uic.py stanza names only BSD-3-Clause although the file also carries an MIT notice.
Packaging
Good quality and would build. Standard modern dh + pybuild layout (debhelper-compat 13, dh-sequence-python3, pybuild-plugin-pyproject), python3 3.10+ CalVer 2026.0 package; every Build-Depends (quanty, python3-silx, python3-xraydb, python3-qtawesome, all six python3-pyside6.* modules, pybuild-plugin-pyproject) exists in the archive; runtime Depends combine quanty with python3:Depends and the app resolves the system Quanty from PATH, matching the archive binary. No quilt patches, no maintainer scripts, no upstream metadata dir (all optional). Standards-Version 4.7.4 is one patch behind current 4.7.4.1. Minor nits: package/DS_Store macOS cruft ships in the tarball; nothing blocking.
Issues
minor licensing 1. uic.py stanza names only BSD-3-Clause though the file is dual-licensed BSD-3-Clause + MIT ◂
- Files:
debian/copyright,src/crispy/uic.py - Evidence:
License: BSD-3-Clausein theFiles: src/crispy/uic.pystanza, while the file header contains both the qt-helpers 3-clause BSD notice and the gistCopyright (c) 2011 Sebastian Wiesner ... Permission is hereby grantedMIT notice. - Problem: copyright-format 1.0 (debian/copyright spec) requires the License field to carry the short name(s) of every licence covering the file; naming only BSD-3-Clause makes the file appear MIT-free although its MIT-derived portion must keep its notice. The Comment paragraph describes the history but the machine field stays incomplete.
- Fix: Change the stanza to
License: BSD-3-Clause and MIT(MIT text is in /usr/share/common-licenses, so no extra standalone License paragraph is needed), keeping the existing Comment.
Verified ◂
- Read debian/ in full: control, copyright, rules, changelog, source/format, salsa-ci.yml, pybuild.testfiles (watch looked at only by name)
- debian/copyright is machine-readable DEP-5 with the exact Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ line and full MIT and BSD-3-Clause License paragraphs
- Inventoried the tree by glob (src/, doc/, notebooks/, package/, .github/, top-level files), excluding .pc/ and debian/
- Grep over the whole tree for Copyright/(c)/©/SPDX/GNU/Apache/Mozilla/public domain/licence markers found only LICENSE.rst, pyproject.toml, CITATION.cff (MIT) and src/crispy/uic.py (BSD-3 + MIT, uniquely staked out) and src/crispy/uis/about.ui (ESRF notice); no other notices anywhere
- Files-Excluded paths
src/crispy/quanty/bin/*andsrc/crispy/quanty/parameters/cowan/bin/*are both absent from the tree (glob) - No .jar/.class/.so/.dll/.exe/.pyc/minified files present; icon preferred form src/crispy/icons/crispy.svg present
- apt-cache confirmed the existence of quanty, python3-silx, python3-xraydb, python3-qtawesome, pybuild-plugin-pyproject and all six python3-pyside6.* build-deps
- src/crispy/config.py findQuanty() prefers a
Quantyexecutable found on PATH, which the archive's quanty package provides (Commands: Quanty) - Bundled-data layout is complete: MANIFEST.in recursive-includes src/crispy/{icons,quanty,uis} and pyproject setuptools include-package-data defaults carry these into the wheel, matching the resourceAbsolutePath() runtime lookups
- uscan found upstream releases with
debian/watch; a newer upstream version is available (upstream2026.2, packaged2026.0+ds), which is not a fault of the package.
Not confirmed ◂
- Binary files recorded by name, not opened: the ~49 src/crispy/quanty/parameters/*.h5 (Cowan parameter data; the cowan scripts/Makefile/rcn31.patch that reproduce them ship alongside) and package/{DS_Store,background.pdf,crispy.icns,crispy.ico} (macOS/Windows installer assets, not installed by the Debian binary); judged from location and docs
- Only sampled the several hundred generated src/crispy/quanty/templates/*.lua (3d/4d/4f families plus a sample); none carried licence headers
- Could not verify the exact ${python3:Depends} strings dh-python derives for the
pyside6/silx[full_no_qt]Requires-Dist at build time (dh-python machinery not installed on this host); all resolved Debian modules exist in the archive
Proposed changes ◂
None.
Review Information
accepted — allocated to mechtilde 23 days ago, started 23 days ago, completed 23 days ago.
Final Comment
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 2026.0+ds-1 | 6455f517… | 2026-10-03 11:51 | 2026-10-03 11:56 | mechtilde | rejected | VIEW |