DFSG NEW review for dae-py-relay-controller version 1.5.2-2

Summary

• Licensing is DFSG-compliant and debian/copyright is accurate: Yes
• Packaging is of good quality: Yes
• Issues: 0 blocker, 0 important, 0 minor
• debian/watch: version 5
• debian/copyright: machine-readable
• Scan before the review: nothing found

Licensing

Every file in the source is single-license Expat/MIT: all 7 dae_RelayBoard modules, the 10 files under 'Example & Test/', setup.py and README.md, each carrying the full MIT text, by Peter Bingham (README.md and every .py header say so). debian/copyright is machine-readable DEP-5 with Format 1.0, a Files: * stanza matching all upstream files and a debian/* stanza for the packaging, with the full Expat text included. There are no non-free terms, no files without a licence, no binaries, minified code, images, fonts or generated blobs, and no embedded third-party code, so no DFSG-Excluded or preferred-form problems.

Packaging

Standard Debian Python Team packaging: dh-python pybuild in rules (compat 13 via debhelper-compat); explicit ${python3:Depends} and ${misc:Depends} are correct at compat 13 (auto-add only from compat 14); runtime deps python3-pylibftdi and python3-serial are real packages and match the actual imports (FTD2XXLinux imports pylibftdi, VCP imports serial). Both patches have DEP-3 headers and are forwarded upstream. Autopkgtests are sound: 'load-each-board' only constructs the board classes, whose constructors need no hardware, and both tests exercise the installed module. Standards-Version 4.7.4.1 equals current Policy 4.7.4.1; Vcs-* and salsa-ci are in place. Changelog, upstream metadata, gbp.conf and docs install are all correct.

Issues

None.

Verified

• Read every file under debian/ (control, rules, changelog, copyright, docs, gbp.conf, salsa-ci.yml, source/format, source/options, both patches and series, tests/control and load-each-board, upstream/metadata).
• Whole tree inventory via glob with gitignore:false (19 upstream files): 7 in dae_RelayBoard/, 10 in 'Example & Test/', setup.py, README.md; no binaries, images, fonts, archives, minified or generated files. Excluded .pc/ and (per instructions) debian/ and any cargo file, of which there is none.
• Every .py file ('Example & Test/' scripts too) and README.md carry the full Expat/MIT text with Copyright (c) Peter Bingham (petersbingham@hotmail.co.uk); the read of each dae_RelayBoard header and the grep across the tree confirm one holder and one licence.
• debian/copyright Files: * (License: Expat, with full text) matches all upstream files; Files: debian/* (Copyright 2026 Hans-Christoph Steiner, Expat) is correct. The extraneous 2018 Dirck Blaskey holder named in the copyright file appears in no file notice; the pre-scan author check found every in-file holder is named, and listing a git-history contributor is harmless.
• Autopkgtest 'load-each-board' verified against the class code: DAE_RelayBoard_D2XX/FTD2XXLinux.init only build a Driver(); DAE_RelayBoard_VCP.init only sets ser=None, so constructing each DAE_RELAYBOARD_TYPE_* class needs no board and the test passes without hardware.
• debian/docs entries Example${Space}&${Space}Test/ and README.md: dh_installdocs (man page) supports substitution variables from compat 13, debhelper(7) documents ${Space}, and compat 11+ errors on unmatched patterns while both paths exist.
• python3-pylibftdi exists in the archive (0.24.1-1, checked via apt-cache); python3-serial is a standard archive package.
• Patches (series order pylibftdi…, then setuptools…) both carry Forwarded/From/Description DEP-3 fields and touch only setup.py and FTD2XXLinux.py.
• Standards-Version 4.7.4.1 matches the Policy version reported by the policy tool (4.7.4.1).
• uscan found the packaged version as the newest upstream release (upstream 1.5.2, packaged 1.5.2).

Not confirmed

• Package was not built or run; no build/test failure is suspected from the tree. The compat-11+ behaviour of dh_installdocs matching paths was confirmed from the debhelper tool output, not from a build.

Proposed changes

None.