DFSG NEW review for dart-boolean-selector version 2.1.2-1

Summary

• Licensing is DFSG-compliant and debian/copyright is accurate: Yes
• Packaging is of good quality: Yes
• Issues: 0 blocker, 0 important, 1 minor
• debian/watch: version 5
• debian/copyright: machine-readable
• Scan before the review: nothing found

Licensing

The tree is entirely the boolean_selector Dart package, all under a 3-clause BSD licence held by 'the Dart project authors'; debian/copyright is DEP-5, its Files: * stanza matches every upstream file, the full BSD-3-clause text is reproduced (BSD is not in /usr/share/common-licenses), and debian/* is covered. No non-free terms, no built or vendored files. The only inaccuracy is that the reproduced licence names 'Google Inc.' where the shipped LICENSE names 'Google LLC' in the no-endorsement clause, a minor mismatch with no effect on the grant.

Packaging

Clean, conventional Dart-team packaging: source format 3.0 (quilt) with no patches, debhelper compat 14 with dh-sequence-single-binary explicitly activated, correct runtime Depends on the two libraries the shipped sources import (dart-source-span, dart-string-scanner), a real offline autopkgtest, Vcs-* and upstream/metadata present, and a sane changelog. Standards-Version 4.7.4 matches current Policy 4.7.4.1. No issues worth fixing before upload.

Issues

1. [minor] [licensing] debian/copyright reproduces the BSD-3-clause no-endorsement clause as 'Google Inc.' while LICENSE says 'Google LLC'

• Files: debian/copyright:38, LICENSE:11
• Basis: checked, in the package or with a reference tool
• Evidence: debian/copyright: * Neither the name of Google Inc. nor the names of its; LICENSE: * Neither the name of Google LLC nor the names of its
• Problem: copyright-format 1.0 (Policy 12.5) requires the licence text as actually granted; clause 3 here names the copyright holder whose names may not be used for endorsement, and the entity named differs from the notice shipped in the package. The grant is otherwise identical, so this is an accuracy nit rather than a legal defect.
• Fix: Change 'Google Inc.' to 'Google LLC' in the stand-alone License: BSD-3-clause paragraph so it matches LICENSE.

Verified

• debian/copyright is DEP-5 (Format: .../copyright-format/1.0/), read in full: Files: * (2016, the Dart project authors, BSD-3-clause) and Files: debian/* (2026, Emfox Zhou), plus the full BSD-3-clause text.
• Every source file carries the header 'Copyright (c) 2016, the Dart project authors ... BSD-style license ... in the LICENSE file'; grep for Copyright/(C)/©/SPDX/All rights reserved over the whole tree (excluding .pc/) matched only that header and the LICENSE/AUTHORS files, so Files: * matches all of lib/, test/, example/, README.md, pubspec.yaml, analysis_options.yaml, AUTHORS and CHANGELOG.md.
• AUTHORS lists only 'Google Inc.' as a contributor organisation; it is not a separate licence holder, so no extra stanza is needed.
• No binary, minified, generated or vendored files: the tree is .dart, .md, .yaml, LICENSE and AUTHORS only; no Files-Excluded and nothing to repack.
• The prescan's holder check found every holder named in debian/copyright, consistent with what I read.
• debian/control, rules, install, docs, changelog, source/format, tests/control, tests/smoke, gbp.conf and upstream/metadata read in full.
• Runtime imports in lib/ are only package:source_span and package:string_scanner; binary Depends dart-source-span and dart-string-scanner match, and both exist in the archive (1.10.2-2 and 1.4.1-2), as does dart-sdk (3.13.4+dfsg1-6).
• Build-Depends dh-sequence-single-binary is provided by debhelper 14.5 (dh(1) addons, line 480), consistent with compat 14.
• Standards-Version 4.7.4 against Policy 4.7.4.1: first two components match, not an issue.
• rules' override_dh_install touches directories to SOURCE_DATE_EPOCH; dpkg-buildpackage sets it from the latest changelog entry (dpkg-buildpackage(1) ENVIRONMENT), so the touch succeeds in a normal build.
• debian/tests/smoke builds a package_config.json for the installed dart packages and runs a real evaluation check offline; it is a genuine test, not a wiring echo.
• .pc/ (quilt) and debian/cargo-checksum.json ignored per instructions; there is no such cargo file.
• uscan found the packaged version as the newest upstream release (upstream 2.1.2, packaged 2.1.2).

Not confirmed

• Could not build the package or run the autopkgtest, so the smoke test's behaviour at build time is unverified; no source of failure is apparent from the files.

Proposed changes

None.