Review: dart-characters 1.4.1-2
Package Information
| Description | String operations that are Unicode grapheme cluster aware This package ships the characters Dart library as sources so that other Dart packages can depend on it at build time. Strings are sequences of Unicode code points, but the characters a user perceives are grapheme clusters. This library splits strings into those clusters and iterates over them. |
|---|---|
| Maintainer | Emfox Zhou <emfox@debian.org> |
| Changed By | Emfox Zhou <emfox@debian.org> |
| Sponsor | emfox@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/dart-team/dart-characters.git (browse) |
| Tracker | https://tracker.debian.org/pkg/dart-characters |
| Uploaded | 13 days ago |
New Package Report
.changes
| Date | Sun, 25 Oct 2026 17:38:50 +0800 |
|---|---|
| Source | dart-characters |
| Version | 1.4.1-2 |
| Changed-By | Emfox Zhou <emfox@debian.org> |
| Architecture | source all |
| Distribution | unstable |
Changelog
dart-characters (1.4.1-2) unstable; urgency=medium . * Record the Unicode and CC BY-SA 3.0 licences in debian/copyright.
.dsc
| Priority | optional |
|---|---|
| Component | main |
| Package-List | dart-characters deb devel optional arch=all |
| Section | devel |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: characters
Source: https://github.com/dart-lang/core/tree/main/pkgs/characters
Files: *
Copyright: 2019, the Dart project authors
License: BSD-3-clause
Files: third_party/Unicode_Consortium/*
Copyright: 1991-2024, Unicode, Inc.
License: Unicode-3.0
Comment: lib/src/grapheme_clusters/table.dart is generated from these data
files; the generated code itself is licensed under BSD-3-clause.
Files: third_party/Wikipedia/*
Copyright: Wikipedia contributors
License: CC-BY-SA-3.0
Files: test/src/text_samples.dart
Copyright: 2019, the Dart project authors
2024, Wikipedia contributors
License: BSD-3-clause and CC-BY-SA-3.0
Comment: Contains a Hangul text sample taken from the Korean Wikipedia.
Files: debian/*
Copyright: 2026, Emfox Zhou <emfox@debian.org>
License: BSD-3-clause
License: BSD-3-clause
Copyright 2019, the Dart project authors.
.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:
.
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the following
disclaimer in the documentation and/or other materials provided
with the distribution.
* Neither the name of Google LLC nor the names of its
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
License: Unicode-3.0
UNICODE LICENSE V3
.
COPYRIGHT AND PERMISSION NOTICE
.
Copyright © 1991-2024 Unicode, Inc.
.
NOTICE TO USER: Carefully read the following legal agreement. BY
DOWNLOADING, INSTALLING, COPYING OR OTHERWISE USING DATA FILES, AND/OR
SOFTWARE, YOU UNEQUIVOCALLY ACCEPT, AND AGREE TO BE BOUND BY, ALL OF THE
TERMS AND CONDITIONS OF THIS AGREEMENT. IF YOU DO NOT AGREE, DO NOT
DOWNLOAD, INSTALL, COPY, DISTRIBUTE OR USE THE DATA FILES OR SOFTWARE.
.
Permission is hereby granted, free of charge, to any person obtaining a
copy of data files and any associated documentation (the "Data Files") or
software and any associated documentation (the "Software") to deal in the
Data Files or Software without restriction, including without limitation
the rights to use, copy, modify, merge, publish, distribute, and/or sell
copies of the Data Files or Software, and to permit persons to whom the
Data Files or Software are furnished to do so, provided that either (a)
this copyright and permission notice appear with all copies of the Data
Files or Software, or (b) this copyright and permission notice appear in
associated Documentation.
.
THE DATA FILES AND SOFTWARE ARE PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF
THIRD PARTY RIGHTS.
.
IN NO EVENT SHALL THE COPYRIGHT HOLDER OR HOLDERS INCLUDED IN THIS NOTICE
BE LIABLE FOR ANY CLAIM, OR ANY SPECIAL INDIRECT OR CONSEQUENTIAL DAMAGES,
OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS,
WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,
ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THE DATA
FILES OR SOFTWARE.
.
Except as contained in this notice, the name of a copyright holder shall
not be used in advertising or otherwise to promote the sale, use or other
dealings in these Data Files or Software without prior written
authorization of the copyright holder.
License: CC-BY-SA-3.0
On Debian systems, the complete text of the CC BY-SA 3.0 license can be
found in "/usr/share/common-licenses/CC-BY-SA-3.0".
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 1 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 13 days ago.
Report
DFSG NEW review for dart-characters version 1.4.1-2
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 1 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The package is a Dart source library under a BSD-3-clause licence, with two third-party data sets recorded separately: Unicode Consortium data under the Unicode License V3, and a Wikipedia-derived Hangul text sample under CC BY-SA 3.0. All three licences are DFSG-free and mutually compatible; the full text of each is provided (or, for CC-BY-SA-3.0, referenced from /usr/share/common-licenses). debian/copyright is machine-readable DEP-5 and names every copyright holder found in the tree. One minor gap: two generated files that embed Unicode-licensed data carry the Unicode licence notice in their headers but are only assigned BSD-3-clause by the catch-all stanza.
Packaging
The packaging is simple and correct for an architecture-independent Dart source-only package. debian/rules is a clean dh(1) invocation at compat 14 with a single, well-commented override to fix pub.dev's epoch timestamps; dh-sequence-single-binary is the right explicit addon for a single-binary package. debian/install puts the library and pubspec.yaml in the standard /usr/share/dart/packages/characters/ location, and the autopkgtest smoke test genuinely exercises the installed library with dart-sdk. Standards-Version 4.7.4 is current, Vcs-* fields, upstream/metadata and gbp.conf are present, and there are no maintainer scripts or patches to get wrong.
Issues
minor licensing 1. Generated files table.dart and unicode_grapheme_tests.dart embed Unicode-licensed data but are recorded only as BSD-3-clause ◂
- Files:
lib/src/grapheme_clusters/table.dart:1-13,test/src/unicode_grapheme_tests.dart:1-13,debian/copyright:13-14 - Basis: checked, in the package or with a reference tool
- Evidence: table.dart and unicode_grapheme_tests.dart both carry
// Licensed under the Unicode Inc. License Agreementin their headers (generated from third_party/Unicode_Consortium data), but are matched only by theFiles: *stanza under BSD-3-clause; the Unicode stanza's Comment asserts 'the generated code itself is licensed under BSD-3-clause' and names only table.dart. - Problem: These generated files are derivative works of Unicode-licensed data and retain the Unicode licence notice, so the Unicode License V3 also governs their data content. Recording them solely as BSD-3-clause understates that. Both licences are DFSG-free and compatible and the full Unicode text is present in the file, so this is a completeness/accuracy gap rather than a DFSG problem.
- Fix: Either add a
Files: lib/src/grapheme_clusters/table.dart test/src/unicode_grapheme_tests.dartstanza withLicense: BSD-3-clause and Unicode-3.0, or correct the existing Comment to acknowledge that these two generated files carry the Unicode licence notice as well as the BSD-3-clause header.
Verified ◂
- Scanned all 47 source files in the tree (lib/, test/, tool/, benchmark/, example/, third_party/); there are no built/binary artefacts, no minified code, and no files without a licence.
- Every .dart file, README.md, CHANGELOG.md, AUTHORS and LICENSE carries a BSD-style header or falls under the catch-all; year drift (2018-2024) is present but the holder 'the Dart project authors' is consistent.
- The prescan's 'Unicode®, Inc.' holder is already recorded in debian/copyright as 'Unicode, Inc.' in the
third_party/Unicode_Consortium/*stanza (a loose-match alias). - third_party/Unicode_Consortium/* data files (DerivedCoreProperties.txt, GraphemeBreakProperty.txt, GraphemeBreakTest.txt, emoji_data.txt, emoji_test.txt) are under the Unicode License V3, whose full text matches UNICODE_LICENSE.txt and is reproduced in debian/copyright.
- third_party/Wikipedia/hangul.txt and the Wikipedia-derived sample in test/src/text_samples.dart are CC BY-SA 3.0, referenced from /usr/share/common-licenses/CC-BY-SA-3.0, and covered by the
third_party/Wikipedia/*andtest/src/text_samples.dartstanzas. - Standards-Version 4.7.4 is current (Policy 4.7.4.1; first two components match). dh-sequence-single-binary is a valid addon, explicitly recommended at compat 14/15 for a single-Package source (debhelper 14.5).
- Read debian/control, rules, changelog, install, docs, source/format, tests/control, tests/smoke, upstream/metadata, gbp.conf and watch in full; no patches directory or maintainer scripts exist.
- uscan found the packaged version as the newest upstream release (upstream
1.4.1, packaged1.4.1). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (CC-BY-SA-3.0).
Not confirmed ◂
None.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader rejected this upload in response to the review.
Review Information
rejected — allocated to dfsg-uploader 13 days ago, started 13 days ago, completed 13 days ago.
Final Comment
The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.