Review: dart-leak-tracker 11.0.2-1

Package Information

Description	framework for memory leak tracking for Dart applications This package ships the leak_tracker library as sources, so that other Dart packages can depend on it at build time.
Maintainer	Emfox Zhou <emfox@debian.org>
Changed By	Emfox Zhou <emfox@debian.org>
Sponsor	emfox@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/dart-team/dart-leak-tracker.git (browse)
Closes	#1152236
Tracker	https://tracker.debian.org/pkg/dart-leak-tracker
Uploaded	12 days ago

New Package Report

.changes◂

Date	Tue, 27 Oct 2026 08:52:31 +0800
Source	dart-leak-tracker
Version	11.0.2-1
Changed-By	Emfox Zhou <emfox@debian.org>
Architecture	source all
Distribution	unstable

Changelog◂

dart-leak-tracker (11.0.2-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #1152236)

.dsc◂

Component	main
Package-List	dart-leak-tracker deb devel optional arch=all
Section	devel
Priority	optional

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: leak_tracker
Source: https://github.com/dart-lang/leak_tracker/tree/main/pkgs/leak_tracker

Files: *
Copyright: 2022, the Dart project authors
License: BSD-3-clause

Files: debian/*
Copyright: 2026, Emfox Zhou <emfox@debian.org>
License: BSD-3-clause

License: BSD-3-clause
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions are
 met:
 .
  * Redistributions of source code must retain the above copyright
    notice, this list of conditions and the following disclaimer.
  * Redistributions in binary form must reproduce the above
    copyright notice, this list of conditions and the following
    disclaimer in the documentation and/or other materials provided
    with the distribution.
  * Neither the name of Google LLC nor the names of its
    contributors may be used to endorse or promote products derived
    from this software without specific prior written permission.
 .
 THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

DFSG Assistant LLM REVIEW 1 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 11 days ago.

Report◂

DFSG NEW review for dart-leak-tracker version 11.0.2-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: No
Packaging is of good quality: Yes
Issues: 1 blocker, 0 important, 0 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

All upstream files are under the 3-clause BSD licence in the top-level LICENSE, which the BSD-3-clause text in debian/copyright reproduces exactly (including the 'Neither the name of Google LLC' clause); nothing non-free or unlicensed was found, and the package is DFSG-free. debian/copyright is DEP-5 with the correct Format URL, but its Files: * stanza names only 'the Dart project authors' while four files are copyrighted by The Chromium Authors, so the copyright statement is incomplete. Fixing that one stanza makes the file accurate.

Packaging

The packaging is small, conventional and in good order: a single Architecture: all package of Dart sources installed under /usr/share/dart/packages/leak_tracker/, source format 3.0 (quilt) with no patches, debhelper compat 14 with the single-binary add-on explicitly activated as debhelper's own checklist recommends for compat 14/15. Depends mirror the pubspec constraints, an autopkgtest smoke test exercises the installed library offline, and Standards-Version 4.7.4 matches current Policy. The only external unknown is the dart-clock dependency, which I could not find in the archive or the NEW queue (recorded under Not confirmed, not as a fault).

Issues

blocker licensing 1. debian/copyright does not name The Chromium Authors, the copyright holder of four files ◂

Files: debian/copyright (Files: * stanza); lib/src/leak_tracking/primitives/_retaining_path/_connection.dart:1; lib/src/shared/_formatting.dart:1; lib/src/shared/_util.dart:1; test/test_infra/utils.dart:1
Basis: checked, in the package or with a reference tool
Evidence: Headers: // Copyright 2023 The Chromium Authors. All rights reserved. and // Use of this source code is governed by a BSD-style license that can be (_util.dart says 2022; the other three say 2023). The Files: * stanza has only Copyright: 2022, the Dart project authors.
Problem: DEP-5 requires the Copyright field of a Files stanza to state the copyright of the files it covers (copyright-format 5.2, 6.7). The four Chromium-authored files are licensed under the same BSD-3-clause terms as the rest of the tree, so there is no licence incompatibility, but their copyright holder is missing from debian/copyright, making it inaccurate.
Fix: Add 2022-2023 The Chromium Authors to the Copyright field of the Files: * stanza, or add a separate stanza for those four paths with Copyright: 2022-2023 The Chromium Authors and License: BSD-3-clause.

Verified ◂

debian/copyright is DEP-5, begins with the correct Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/, and is otherwise valid: Files: * plus Files: debian/*, with a stand-alone License stanza for BSD-3-clause whose text matches the top-level LICENSE word for word (including 'Neither the name of Google LLC').
Every other source file (51 of 55, from Copyright (c) 2022 to 2024) carries the Dart project authors BSD-3 notices and is covered by Files: *; no other copyright holders found (grep for Copyright/(C)/©/SPDX/Licensed under/All rights reserved across lib/, test/, example/ and the top-level files).
No non-free wording and no other licence found anywhere in the tree: a grep for Apache/MIT/MPL/GPL/Lesser General/CC-/non-commercial/public domain/permission-is-hereby-granted matched only incidental words (e.g. 'sampler' containing 'mpl').
The four prescan files attributed to The Chromium Authors are ordinary Dart sources (_retaining_path helper, shared formatting/util helpers, and test infrastructure): BSD-3-clause by their own notices and by reference to LICENSE, so they are DFSG-free; the only defect is the missing holder, reported above.
No compiled or generated artefacts in the tree: the source inventory is 55 files, all .dart, .md and .yaml; no jars, class files, shared objects, minified JS/CSS, fonts, images, PDFs or bytecode.
lib/DEPENDENCIES.md and lib/src/**/DEPENDENCIES.md are Markdown import-graph documentation generated by layerlens from the sources that are present; they are documentation, not code whose generator input is missing, and their preferred form for modification is the Markdown itself.
debian/install ships lib/ and pubspec.yaml into /usr/share/dart/packages/leak_tracker/, matching the pubspec name leak_tracker and the layout the package's own autopkgtest expects (/usr/share/dart/packages/*/pubspec.yaml).
debian/rules is dh $@ with a single override of dh_install that only re-stamps directory mtimes with SOURCE_DATE_EPOCH; source format is 3.0 (quilt) and there are no patches (no debian/patches, empty quilt series), so nothing needs DEP-3 headers.
Build-Depends: debhelper-compat (= 14) plus dh-sequence-single-binary is the correct way to keep the compat-14 single-binary behaviour at compat 15, per debhelper's compatibility checklist (checked with the debhelper tool); the source has no build system, so dh_auto_* do nothing and dh_install performs the installation.
Standards-Version 4.7.4 equals the current Policy version (checked with the policy tool); changelog is a well-formed initial release to unstable closing #1152236; Vcs-Git/Vcs-Browser, Homepage and debian/upstream/metadata (Bug-Database, Bug-Submit, Changelog, Repository, Repository-Browse) are present and plausible.
Depends versions match the pubspec: dart-collection (>= 1.15.0), dart-meta (>= 1.8.0), dart-path (>= 1.8.3) are satisfied by the archive's 1.19.1, 1.19.0 and 1.9.1; dart-vm-service >= 11.10.0 < 16.0.0 is satisfied by 15.4.0-1, which is in NEW (checked with apt-cache).
debian/tests/control declares one test (smoke, Restrictions: allow-stderr) with the package and its Dart dependencies; debian/tests/smoke builds a package_config.json from the installed packages, then compiles/runs a small program using LeakType, LeakDiagnosticConfig.copyWith and forceGC, all of which exist with the signatures used (model.dart, helpers.dart).
No maintainer scripts, no .maintscript, no debian/compat file, and no missing substvars: ${misc:Depends} is present in Depends.
uscan found the packaged version as the newest upstream release (upstream 11.0.2, packaged 11.0.2).

Not confirmed ◂

dart-clock is a hard dependency of the binary (and of the autopkgtest) but is not in the archive and not among the uploads in ftp-master's NEW queue as of 2026-10-27T04:47Z, and nothing provides it. If it is not uploaded before this package, dart-leak-tracker is uninstallable and its test cannot run; the package lists may simply predate its acceptance, so I do not report it as a fault.
The build and the autopkgtest were not run: the tree is read-only and dart-sdk is not installed on the reviewing system, so I cannot say whether dart run main.dart in the smoke test and the generated package_config.json work as intended; no build or test failure is claimed.

Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader rejected this upload in response to the review.

Review Information

rejected — allocated to dfsg-uploader 11 days ago, started 11 days ago, completed 11 days ago.

Final Comment

The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.

Other Reviews of this Package

Version	Hash	Allocated	Completed	Reviewer	Status	Details
11.0.2-1	6d9aa224…	2026-10-27 23:36	2026-10-27 23:36	awm	accepted	VIEW

Back to Dashboard | View all reviews for this package