DFSG NEW review for dart-matcher version 0.12.20-1

Summary

• Licensing is DFSG-compliant and debian/copyright is accurate: Yes
• Packaging is of good quality: Yes
• Issues: 0 blocker, 0 important, 1 minor
• debian/watch: version 5
• debian/copyright: machine-readable
• Scan before the review: nothing found

Licensing

The tree is BSD-3-Clause throughout, which is DFSG-free, and debian/copyright is DEP-5 with the right holder (the Dart project authors) and short name for every file: all 55 Dart sources carry a 'Copyright (c) ... the Dart project authors ... BSD-style license' header, the LICENSE says the same, and debian/* is covered by its own later stanza. The only blemish is one word in the reproduced licence body: the License: BSD-3-clause paragraph says 'Neither the name of Google Inc.', where the shipped LICENSE says 'Google LLC'. Nothing else is off: no non-free wording, no built/minified/binary files, no third-party code, no missing holder, no missing licence text. On that one wording difference the description is not a verbatim copy of the notice upstream ships, which is why an issue is filed; the licence and holders are otherwise stated correctly.

Packaging

The packaging is clean and matches the conventions the other dart-* packages in the archive use. debhelper compat 14 with a modern dh rules file (and dh-sequence-single-binary, which is exactly how the single-binary addon is activated explicitly at compat 14), source format 3.0 (quilt) with no patches, Standards-Version 4.7.4 against current Policy 4.7.4.1, Vcs-* and upstream/metadata present, a working autopkgtest, and a DEP-5 copyright. Architecture: all / Multi-Arch: foreign are right for a sources-only Dart library, and the Depends match pubspec.yaml's constraints against the archive's dart-async, dart-meta, dart-stack-trace and dart-term-glyph. I found nothing a sponsor would require to be changed.

Issues

1. [minor] [licensing] debian/copyright reproduces the licence with 'Google Inc.' where the upstream LICENSE says 'Google LLC'

• Files: debian/copyright line 24 (the stand-alone License: BSD-3-clause paragraph, clause 3); LICENSE line 11
• Basis: checked, in the package or with a reference tool
• Evidence: debian/copyright: * Neither the name of Google Inc. nor the names of its vs LICENSE: * Neither the name of Google LLC nor the names of its. Every other line of the two texts is identical.
• Problem: The License paragraph is supposed to reproduce the licence the upstream files are under; it renames the entity in clause 3, so the licence text in debian/copyright is not the text upstream ships. It does not change the licence's terms (still BSD-3-Clause, still free), so it is not a DFSG problem.
• Fix: Change Google Inc. to Google LLC in the License: BSD-3-clause paragraph so it matches LICENSE.

Verified

• Inventory: 55 .dart sources under lib/ and test/, plus LICENSE, README.md, CHANGELOG.md, pubspec.yaml, analysis_options.yaml and mono_pkg.yaml; nothing outside debian/ is built, minified, compressed or binary, so the scan's built-file checks have nothing to find, and there is no .jar/.so/.pyc/font/image/data file.
• Every .dart file except test/map_matchers_test.dart carries a three-line // Copyright (c) <2012-2023>, the Dart project authors ... BSD-style license that can be found in the LICENSE file header; test/map_matchers_test.dart begins directly with an import and has no header, but it is upstream's own test file and is covered by the Files: * stanza (I read the file: only matcher/test imports and its own test cases).
• LICENSE is BSD-3-Clause, Copyright 2014, the Dart project authors., matching the Files: * stanza's holder; debian/copyright reproduces the BSD-3-Clause text in full (3 clauses + disclaimer), so no /usr/share/common-licenses pointer is needed for it and the 'BSD-3-clause' short name is right.
• The scan's holder check found every holder named: apart from the one clause-3 wording above, every 'copyright' occurrence in the tree is 'the Dart project authors' (year drift 2012-2023, not noteworthy); debian/* is the maintainer Emfox Zhou. The pre-scan listed no files to account for.
• No non-free terms (non-commercial, no-modification, field-of-use), no CC-*-NC/-ND, no third-party or vendored code, and no embedded copy of a library Debian already ships.
• The scan's built-file/licence checks surfaced nothing else; .pc/applied-patches is empty, so quilt applied no patch and the upstream files in the tree are the orig tarball's.
• dart-copyright is DEP-5 (Format: .../copyright-format/1.0/), debian/* has its own later stanza, and Files: * correctly acts as the catch-all for the rest.
• Dependencies exist and satisfy pubspec.yaml: dart-async 2.13.1-2 (^2.10.0), dart-meta 1.19.0-2 (^1.8.0), dart-stack-trace 1.12.2-2 (^1.10.0), dart-term-glyph 1.2.2-2 (^1.2.0), all in the archive per apt-cache. dart-test-api 0.7.15-1 is not in the archive yet but is built by source dart-test-api 0.7.15-1 waiting in ftp-master's NEW queue, so its absence is not a fault.
• dh-sequence-single-binary is provided by debhelper 14.5; per debhelper-compat-upgrade-checklist it is the way to activate the single-binary addon explicitly at compat 14 (the implicit activation warns there and disappears at compat 15), so listing it in Build-Depends is correct rather than redundant.
• Standards-Version 4.7.4 is current: the policy tool reports Policy 4.7.4.1, so the first two components match.
• SOURCE_DATE_EPOCH, used by the touch -d "@$${SOURCE_DATE_EPOCH}" in override_dh_install, is set by dpkg-buildpackage to the changelog timestamp when it is not already defined (dpkg-buildpackage(1) ENVIRONMENT), so the override cannot fail with an empty value under a normal build.
• autopkgtest is present (debian/tests/control + debian/tests/smoke), depends on @ and dart-sdk, and the .dsc records Testsuite: autopkgtest / Testsuite-Triggers: dart-sdk; debian/upstream/metadata uses valid DEP-12 fields.
• uscan found the packaged version as the newest upstream release (upstream 0.12.20, packaged 0.12.20).

Not confirmed

• I did not enumerate the members of dart-matcher_0.12.20.orig.tar.gz or dart-matcher_0.12.20-1.debian.tar.xz (the archive reader showed only the top-level entries), so the tree was not compared member by member with the tarballs; the tree's file set and pubspec.yaml match a published pub.dev matcher 0.12.20 package and no Files-Excluded is needed.

Proposed changes

None.