DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: dart-native-synchronization 0.3.1-1

Package Information

DescriptionLow level synchronization primitives built on dart:ffi

This package ships the Dart sources so that other Dart packages can depend on it at build time.

MaintainerEmfox Zhou <emfox@debian.org>
Changed ByEmfox Zhou <emfox@debian.org>
Sponsoremfox@debian.org
Distributionunstable
Architectureall
VCSgit: https://salsa.debian.org/dart-team/dart-native-synchronization.git (browse)
Closes#1149079
Trackerhttps://tracker.debian.org/pkg/dart-native-synchronization
Uploaded1 month, 12 days ago

New Package Report

.changes◂
Version0.3.1-1
Changed-ByEmfox Zhou <emfox@debian.org>
Architecturesource all
Distributionunstable
DateSat, 26 Sep 2026 19:40:47 +0800
Sourcedart-native-synchronization
Changelog◂
dart-native-synchronization (0.3.1-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #1149079)
.dsc◂
Priorityoptional
Componentmain
Package-Listdart-native-synchronization deb libs optional arch=all
Sectionlibs
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: native_synchronization
Source: https://github.com/dart-lang/labs/tree/main/pkgs/native_synchronization

Files: *
Copyright: 2023, the Dart project authors
License: BSD-3-clause
 Copyright 2023, the Dart project authors.
 .
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions are
 met:
 .
     * Redistributions of source code must retain the above copyright
       notice, this list of conditions and the following disclaimer.
     * Redistributions in binary form must reproduce the above
       copyright notice, this list of conditions and the following
       disclaimer in the documentation and/or other materials provided
       with the distribution.
     * Neither the name of Google LLC nor the names of its
       contributors may be used to endorse or promote products derived
       from this software without specific prior written permission.
 .
 THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Review Information

accepted — allocated to awm 1 month, 11 days ago, started 1 month, 11 days ago, completed 1 month, 11 days ago.

Final Comment

Hi,

These may be issues that you want to work on. No need to reply with details.

  1. Incomplete mtime workaround

debian/rules:13 (override_dh_install) only re-stamps directories (find ... -type d), but the upstream pub.dev tarball records files with epoch-0 mtimes too. The claimed problem (files dated 1970-01-01) is not actually fixed for the regular files, so the override is half-applied and doesn't achieve what its own comment says. It also hardcodes the package dir name instead of $(CURDIR).

  1. Missing dependency on the Dart toolchain/ffi

debian/control:12-14 ships a binary package with no Depends:. Yet pubspec.yaml:9 declares ffi: ^2.1.0 as a runtime dependency. Consuming this package as a path dependency via pub get would not have ffi resolvable, so the package is not self-sufficient as shipped. It should at least depend on the Dart SDK, and ideally the Debian dart-ffi package.

  1. Wrong section

debian/control:2 uses Section: libs for a package that ships only build-time Dart sources; devel would be more appropriate, matching the intent stated in the Description ("ships the Dart sources ... depend on it at build time").

  1. No test integration

test/ contains mailbox_test.dart and primitives_test.dart, but there is no Testsuite: autopkgtest in debian/control and no debian/tests/. The shipped tests are never exercised.

  1. debian/install:1-2 ships only lib/ and pubspec.yaml into the package dir; CHANGELOG.md is omitted from the installed tree (README goes only to /usr/share/doc via debian/docs). Minor completeness gap for a path-package.

Thanks!

Back to Dashboard | View all reviews for this package