DFSG NEW review for dart-test-api version 0.7.15-1

Summary

• Licensing is DFSG-compliant and debian/copyright is accurate: Yes
• Packaging is of good quality: Yes
• Issues: 0 blocker, 0 important, 1 minor
• debian/watch: version 5
• debian/copyright: machine-readable
• Scan before the review: nothing found

Licensing

Everything in the tree is BSD-3-clause: the top-level LICENSE and every .dart file under lib/ and test/ carry the 'Copyright (c) , the Dart project authors ... BSD-style license that can be found in the LICENSE file' header, and debian/copyright is DEP-5 with a Files: * stanza naming that holder and the full BSD-3 text. No non-free terms, no built/minified/binary files, no vendored third-party code, no unknown-provenance assets. The only blemish is that the stand-alone BSD-3 text in debian/copyright reproduces clause 3 as 'Neither the name of Google Inc.' while the shipped LICENSE names 'Google LLC'; this does not change the rights granted or match any wrong holder and is reported as minor.

Packaging

Clean, minimal, source-only packaging in the dart-team style: debhelper-compat 14 with dh-sequence-single-binary (the single-binary add-on is required at compat 14 and provided by debhelper 14.5), Standards-Version 4.7.4 against Policy 4.7.4.1, Architecture: all + Multi-Arch: foreign, correct install of lib/ and pubspec.yaml into /usr/share/dart/packages/test_api/, all nine Depends matching pubspec.yaml dependencies (all real, dart-boolean-selector just in NEW), an autopkgtest smoke test with dart-sdk as trigger, and a well-formed initial changelog closing #1152043. No patches (quilt series empty), so the 3.0 (quilt) format is a formality. Nothing a sponsor would need fixed before upload.

Issues

1. [minor] [licensing] debian/copyright BSD-3 text names 'Google Inc.' where upstream LICENSE names 'Google LLC'

• Files: debian/copyright (stand-alone License: BSD-3-clause, clause 3); dart-test-api-0.7.15/LICENSE
• Basis: checked, in the package or with a reference tool
• Evidence: debian/copyright: Neither the name of Google Inc. nor the names of its; LICENSE: Neither the name of Google LLC nor the names of its.
• Problem: The stand-alone licence paragraph is supposed to reproduce the licence the files are under (copyright-format 1.0 §5.3/§6.7). It substitutes a different corporate entity in BSD-3 clause 3 than the notice actually shipped, so the file's licence text is not reproduced verbatim. It grants the same rights and names no wrong copyright holder, hence minor rather than a blocker.
• Fix: Change Google Inc. to Google LLC in the License: BSD-3-clause paragraph of debian/copyright so it matches LICENSE.

Verified

• debian/copyright is machine-readable DEP-5 starting with the exact Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/; two Files stanzas (* and debian/*) and one stand-alone BSD-3-clause paragraph; the full BSD-3 text is present (BSD-3 is not in /usr/share/common-licenses). No Files-Excluded.
• Top-level LICENSE: Copyright 2018, the Dart project authors + BSD-3; matches the Files: * stanza holder.
• All 43 .dart files under lib/ and test/ (grep for Copyright/SPDX/Licensed under/GNU/Apache/etc.) begin with // Copyright (c) <2013..2026>, the Dart project authors. Please see the AUTHORS file ... BSD-style license that can be found in the LICENSE file.; no other copyright holder or licence appears anywhere in the tree. Year drift across the headers is not noteworthy.
• Prescan (dfsg-author-check, 60 files): every holder found is named in debian/copyright.
• No built artifacts to account for: the tree is only Dart sources, pubspec.yaml/dart_test.yaml/mono_pkg.yaml, CHANGELOG.md, README.md and LICENSE; no .jar/.so/.class/.pyc/minified JS/PDF/font/image; no vendored third-party code (imports resolve to the nine declared Depends: async, boolean_selector, collection, meta, source_span, stack_trace, stream_channel, string_scanner, term_glyph).
• .pc/ and debian/cargo-checksum.json ignored per instructions (no cargo-checksum.json exists).
• All nine binary Depends check out via apt-cache (dart-async, dart-collection, dart-meta, dart-source-span, dart-stack-trace, dart-stream-channel, dart-string-scanner, dart-term-glyph in the archive; dart-boolean-selector built by the dart-boolean-selector 2.1.2-1 upload in NEW, not a fault).
• dh-sequence-single-binary is a real virtual package provided by debhelper 14.5 (/usr/share/perl5/Debian/Debhelper/Sequence/single_binary.pm), and at compat 14 it must be activated explicitly to keep single-binary --destdir behaviour; Build-Depends is correct.
• Standards-Version 4.7.4: Policy on the reviewing system is 4.7.4.1, so the first two components match — not an issue.
• debian/install installs lib and pubspec.yaml to usr/share/dart/packages/test_api/; debian/docs ships README.md; debian/tests/control runs the self-contained smoke test offline with dart-sdk; debian/upstream/metadata, gbp.conf (pristine-tar) and source/format (3.0 (quilt), series empty) are consistent.
• debian/rules only overrides dh_install to stamp installed directories with SOURCE_DATE_EPOCH (the pub.dev tarball carries epoch mtimes); dpkg-buildpackage exports that variable, so reproducible and harmless.
• uscan found the packaged version as the newest upstream release (upstream 0.7.15, packaged 0.7.15).

Not confirmed

• The autopkgtest smoke test was not executed (no build/run allowed); it registers every package under /usr/share/dart/packages/*/ in a package_config.json and runs dart run main.dart, which a buildd/autopkgtest would exercise.
• Whether #1152043 is the right bug to close was not checked (no issue access).

Proposed changes

None.