Review: dcmtk 3.7.1+dfsg-1~0exp0
Package Information
| Description | OFFIS DICOM toolkit command line utilities DCMTK includes a collection of libraries and applications for examining, constructing and converting DICOM image files, handling offline media, sending and receiving images over a network connection, as well as demonstrative image storage and worklist servers. This package contains the DCMTK utility applications. Note: This version was compiled with libssl support. |
|---|---|
| Maintainer | Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org> |
| Changed By | Étienne Mollier <emollier@debian.org> |
| Sponsor | emollier@debian.org |
| Distribution | experimental |
| Architecture | any all |
| VCS | git: https://salsa.debian.org/med-team/dcmtk.git (browse) |
| Closes | #1138478, #1149131, #1150500, #1150501, #1150502, #1150503, #1150504, #1150505, #1150506 |
| Popcon Installs | 4483 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/dcmtk |
| Uploaded | 21 days ago |
New Package Report
.changes
| Date | Sat, 17 Oct 2026 15:06:43 +0200 |
|---|---|
| Source | dcmtk |
| Version | 3.7.1+dfsg-1~0exp0 |
| Changed-By | Étienne Mollier <emollier@debian.org> |
| Architecture | source all amd64 |
| Distribution | experimental |
Changelog
dcmtk (3.7.1+dfsg-1~0exp0) experimental; urgency=medium
.
* New upstream version 3.7.1+dfsg (Closes: #1138478)
This version notably resolves security issues in dcmtk:
- CVE-2026-97059 (Closes: #1149131),
- CVE-2026-44031 (Closes: #1150500),
- CVE-2026-44033 (Closes: #1150501),
- CVE-2026-44034 (Closes: #1150502),
- CVE-2026-44035 (Closes: #1150503),
- CVE-2026-44036 (Closes: #1150504),
- CVE-2026-44037 (Closes: #1150505),
- CVE-2026-44038 (Closes: #1150506).
* d/{copyright,watch}: exclude Unicode sources with old strict terms.
This change excludes files with license terms that are not compatible
with DFSG, therefore also adjust the watch file to append +dfsg
upstream repack marker.
* d/dcmtk-doc.doc-base: update dcmtk doc-base path to version 3.7.1.
* d/*: soversion bump to libdcmtk21.
* skip-bigendian-roundtrip-failure.patch: delete.
This patch worked around a test failure affecting s390x, but the issue
was supposed to be fixed in upcoming dcmtk version at the time of
3.7.0. If test failures occur in dcmtk 3.7.1 on s390x, then the patch
may be re-applied.
* hurd.patch: delete: applied upstream.
* CVE-2026-*.patch: delete: applied upstream.
* fixup-manpages.patch: new: fix rendering bullet points in dcmodify.1.
* d/.gitignore: new: defuse upstream .gitignore..dsc
| Section | science |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | dcmtk deb science optional arch=any dcmtk-data deb science optional arch=all dcmtk-doc deb doc optional arch=all libdcmtk-dev deb libdevel optional arch=any libdcmtk21 deb libs optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: DCMTK
Upstream-Contact: DCMTK Team <info@dcmtk.org>
Source: https://github.com/commontk/DCMTK
Files-Excluded:
oficonv/datasrc/csmapper/GB/GB2312%UCS.src
oficonv/datasrc/csmapper/GB/GB2312GBK%UCS.src
oficonv/datasrc/csmapper/GB/UCS%GB2312.src
oficonv/datasrc/csmapper/ISO-8859/ISO-8859-11%UCS.src
oficonv/datasrc/csmapper/ISO-8859/ISO-8859-15%UCS.src
oficonv/datasrc/csmapper/ISO-8859/ISO-8859-2%UCS.src
oficonv/datasrc/csmapper/ISO-8859/ISO-8859-3%UCS.src
oficonv/datasrc/csmapper/ISO-8859/ISO-8859-4%UCS.src
oficonv/datasrc/csmapper/ISO-8859/ISO-8859-5%UCS.src
oficonv/datasrc/csmapper/ISO-8859/ISO-8859-6%UCS.src
oficonv/datasrc/csmapper/ISO-8859/ISO-8859-7%UCS.src
oficonv/datasrc/csmapper/ISO-8859/ISO-8859-8%UCS.src
oficonv/datasrc/csmapper/ISO-8859/ISO-8859-9%UCS.src
oficonv/datasrc/csmapper/ISO-8859/UCS%ISO-8859-11.src
oficonv/datasrc/csmapper/ISO-8859/UCS%ISO-8859-15.src
oficonv/datasrc/csmapper/ISO-8859/UCS%ISO-8859-2.src
oficonv/datasrc/csmapper/ISO-8859/UCS%ISO-8859-3.src
oficonv/datasrc/csmapper/ISO-8859/UCS%ISO-8859-4.src
oficonv/datasrc/csmapper/ISO-8859/UCS%ISO-8859-5.src
oficonv/datasrc/csmapper/ISO-8859/UCS%ISO-8859-6.src
oficonv/datasrc/csmapper/ISO-8859/UCS%ISO-8859-7.src
oficonv/datasrc/csmapper/ISO-8859/UCS%ISO-8859-8.src
oficonv/datasrc/csmapper/ISO-8859/UCS%ISO-8859-9.src
Comment:
Several files below oficonv/datasrc/csmapper/ have old problematic
unicode license terms. diffoscope reveals no differences builing dcmtk
with and without them, so we address the problem by excluding affected
files.
Files: *
Copyright: 1994-2026, OFFIS e.V.
License: OFFISeV
Files: dcmnet/include/dcmtk/dcmnet/dimse.h
dcmnet/include/dcmtk/dcmnet/assoc.h
dcmnet/include/dcmtk/dcmnet/dicom.h
dcmnet/include/dcmtk/dcmnet/dcompat.h
dcmnet/include/dcmtk/dcmnet/diutil.h
dcmnet/libsrc/dimstore.cc
dcmnet/libsrc/assoc.cc
dcmnet/libsrc/dulextra.cc
dcmnet/libsrc/dcompat.cc
dcmnet/libsrc/diutil.cc
dcmnet/libsrc/dimcmd.h
dcmnet/libsrc/dimfind.cc
dcmnet/libsrc/dimse.cc
dcmnet/libsrc/dimcmd.cc
dcmnet/libsrc/dimcancl.cc
dcmnet/libsrc/dimecho.cc
dcmnet/libsrc/dimmove.cc
Copyright: 1993/1994, OFFIS, Oldenburg University and CERIUM
License: OFFIS
This software and supporting documentation were
developed by
.
Institut OFFIS
Bereich Kommunikationssysteme
Westerstr. 10-12
26121 Oldenburg, Germany
.
Fachbereich Informatik
Abteilung Prozessinformatik
Carl von Ossietzky Universitaet Oldenburg
Ammerlaender Heerstr. 114-118
26111 Oldenburg, Germany
.
CERIUM
Laboratoire SIM
Faculte de Medecine
2 Avenue du Pr. Leon Bernard
35043 Rennes Cedex, France
.
for CEN/TC251/WG4 as a contribution to the Radiological
Society of North America (RSNA) 1993 Digital Imaging and
Communications in Medicine (DICOM) Demonstration.
.
THIS SOFTWARE IS MADE AVAILABLE, AS IS, AND NEITHER OFFIS,
OLDENBURG UNIVERSITY NOR CERIUM MAKE ANY WARRANTY REGARDING
THE SOFTWARE, ITS PERFORMANCE, ITS MERCHANTABILITY OR
FITNESS FOR ANY PARTICULAR USE, FREEDOM FROM ANY COMPUTER
DISEASES OR ITS CONFORMITY TO ANY SPECIFICATION. THE
ENTIRE RISK AS TO QUALITY AND PERFORMANCE OF THE SOFTWARE
IS WITH THE USER.
.
Copyright of the software and supporting documentation
is, unless otherwise stated, jointly owned by OFFIS,
Oldenburg University and CERIUM and free access is hereby
granted as a license to use this software, copy this
software and prepare derivative works based upon this
software. However, any distribution of this software
source code or supporting documentation or derivative
works (source code and supporting documentation) must
include the three paragraphs of this copyright notice.
Files: dcmnet/include/dcmtk/dcmnet/dul.h
dcmnet/include/dcmtk/dcmnet/dulstruc.h
dcmnet/libsrc/dul.cc
dcmnet/libsrc/dulconst.cc
dcmnet/libsrc/dulpriv.h
dcmnet/libsrc/dulpres.cc
dcmnet/libsrc/dulfsm.h
dcmnet/libsrc/dulfsm.cc
dcmnet/libsrc/dulparse.cc
Copyright: 1993, 1994 RSNA and Washington University
1994-2021, OFFIS e.V.
License: RSNA
The software and supporting documentation for the Radiological
Society of North America (RSNA) 1993, 1994 Digital Imaging and
Communications in Medicine (DICOM) Demonstration were developed
at the
Electronic Radiology Laboratory
Mallinckrodt Institute of Radiology
Washington University School of Medicine
510 S. Kingshighway Blvd.
St. Louis, MO 63110
as part of the 1993 DICOM Central Test Node project for, and
under contract with, the Radiological Society of North America.
.
THIS SOFTWARE IS MADE AVAILABLE, AS IS, AND NEITHER RSNA NOR
WASHINGTON UNIVERSITY MAKE ANY WARRANTY ABOUT THE SOFTWARE, ITS
PERFORMANCE, ITS MERCHANTABILITY OR FITNESS FOR ANY PARTICULAR
USE, FREEDOM FROM ANY COMPUTER DISEASES OR ITS CONFORMITY TO ANY
SPECIFICATION. THE ENTIRE RISK AS TO QUALITY AND PERFORMANCE OF
THE SOFTWARE IS WITH THE USER.
.
Copyright of the software and supporting documentation is
jointly owned by RSNA and Washington University, and free access
is hereby granted as a license to use this software, copy this
software and prepare derivative works based upon this software.
However, any distribution of this software source code or
supporting documentation or derivative works (source code and
supporting documentation) must include the three paragraphs of
the copyright notice.
Files: dcmjpeg/libijg8/*
dcmjpeg/libijg12/*
dcmjpeg/libijg16/*
dcmjpeg/docs/ijg_readme.txt
Copyright: 1991-1998, Thomas G. Lane.
License: JPEG
The authors make NO WARRANTY or representation, either express or implied,
with respect to this software, its quality, accuracy, merchantability, or
fitness for a particular purpose. This software is provided "AS IS", and you,
its user, assume the entire risk as to its quality and accuracy.
.
Permission is hereby granted to use, copy, modify, and distribute this
software (or portions thereof) for any purpose, without fee, subject to these
conditions:
(1) If any part of the source code for this software is distributed, then this
README file must be included, with this copyright and no-warranty notice
unaltered; and any additions, deletions, or changes to the original files
must be clearly indicated in accompanying documentation.
(2) If only executable code is distributed, then the accompanying
documentation must state that "this software is based in part on the work of
the Independent JPEG Group".
(3) Permission for use of this software is granted only if the user accepts
full responsibility for any undesirable consequences; the authors accept
NO LIABILITY for damages of any kind.
.
These conditions apply to any software derived from or based on the IJG code,
not just to the unmodified library. If you use our work, you ought to
acknowledge us.
.
Permission is NOT granted for the use of any IJG author's name or company name
in advertising or publicity relating to this software or products derived from
it. This software may be referred to only as "the Independent JPEG Group's
software".
.
We specifically permit and encourage the use of this software as the basis of
commercial products, provided that all warranty or liability claims are
assumed by the product vendor.
Files: dcmimage/include/dcmtk/dcmimage/diqtpix.h
Copyright: 1991 by Jef Poskanzer.
License: pbmplus
Permission to use, copy, modify, and distribute this software and its
documentation for any purpose and without fee is hereby granted, provided
that the above copyright notice appear in all copies and that both that
copyright notice and this permission notice appear in supporting
documentation. This software is provided "as is" without express or
implied warranty.
Comment: The code for the interpolatePixel() image scaling algorithm in module
dcmimgle has been derived from code written by Jef Poskanzer for the
"Extended Portable Bitmap Toolkit" (pbmplus10dec91)
Files: ofstd/libsrc/ofstd.cc
Copyright: 2001-2017 OFFIS e.V.
1998 Todd C. Miller <Todd.Miller(at)courtesan.com>
1988 Regents of the University of California
1999 Bob Withers <bwit@pobox.com>
License: OFFISeV
Files: oflog/*
Copyright: 1999-2009 Contributors to log4cplus project.
License: BSD-2-clause
Files: oficonv/*
Copyright: 2003-2008 Citrus Project
License: BSD-2-clause
Files: oficonv/docs/mkcsmapper.man
oficonv/docs/mkesdb.man
oficonv/include/dcmtk/oficonv/iconv.h
oficonv/libsrc/citrus_lock.h
oficonv/libsrc/citrus_none.c
Copyright: 2002 Citrus Project
2009-2010 Gabor Kovesdan <gabor@FreeBSD.org>
License: BSD-2-clause
Comment:
Manual pages are derived from the FreeBSD man pages.
Files: oficonv/libsrc/citrus_bcs_strtol.c
oficonv/libsrc/citrus_bcs_strtoul.c
Copyright: 2005 The DragonFly Project
2003-2008 Citrus Project
License: BSD-2-clause
Files: oficonv/libsrc/citrus_big5.c
oficonv/libsrc/citrus_euc.c
oficonv/libsrc/citrus_jisx0208.c
oficonv/libsrc/citrus_module.c
Copyright: 1990-1993, The Regents of the University of California
1998 The NetBSD Foundation, Inc.
1999-2006, Citrus Project
License: BSD-2-clause or BSD-3-clause
Files: oficonv/libsrc/citrus_strtol.h
oficonv/libsrc/citrus_strtoul.h
Copyright: 1990-1993, The Regents of the University of California
License: BSD-3-clause
Files: oficonv/libsrc/citrus_mskanji.c
Copyright: 1995 Sin'ichiro MIYATANI / Phase One, Inc
2002 Citrus Project
License: BSD-2-clause or BSD-4-clause
Comment:
Original state of the file in 1995 was BSD-4-clause. Changes by the
Citrus Project in 2002 brought BSD-2-clause.
Files: oficonv/libsrc/citrus_utf8.c
Copyright: 1993 The Regents of the University of California
2002 Citrus Project
License: BSD-2-clause or BSD-3-clause
Comment:
Original state of the file in 1993 was BSD-3-clause. Changes by the
Citrus Project in 2002 brought BSD-2-clause.
License: BSD-4-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
3. All advertising materials mentioning features or use of this software
must display the following acknowledgement:
This product includes software developed by Phase One, Inc.
4. The name of Phase One, Inc. may be used to endorse or promote products
derived from this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.
Files: oficonv/include/dcmtk/oficonv/oidefine.h
oficonv/include/dcmtk/oficonv/queue.h
Copyright: 2022, OFFIS e.V.
License: BSD-3-clause
Files: oficonv/apps/mkcsmapper_bison.cc
oficonv/apps/mkcsmapper_bison.h
oficonv/apps/mkesdb_bison.cc
oficonv/apps/mkesdb_bison.h
Copyright: 1984, 1989-1990, 2000-2015, 2018-2021 Free Software Foundation, Inc.
License: GPL-3+ and Bison-2.2-exception
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
You should have received a copy of the GNU General Public License
along with this program. If not, see <https://www.gnu.org/licenses/>.
.
On Debian systems, the full text of the GPLv3 can be found in
/usr/share/common-licenses/GPL-3.
.
As a special exception, you may create a larger work that contains
part or all of the Bison parser skeleton and distribute that work
under terms of your choice, so long as that work isn't itself a
parser generator using the skeleton or a modified version thereof
as a parser skeleton. Alternatively, if you modify or redistribute
the parser skeleton itself, you may (at your option) remove this
special exception, which will cause the skeleton and the resulting
Bison output files to be licensed under the GNU General Public
License without this special exception.
Files: oficonv/libsrc/oficonv_strcasestr.c
oficonv/libsrc/oficonv_strcasestr.h
Copyright: 1990-1993 The Regents of the University of California
2011 The FreeBSD Foundation
License: BSD-3-clause
Files: oficonv/libsrc/oficonv_strlcpy.c
oficonv/libsrc/oficonv_strlcpy.h
Copyright: 1998-2015, Todd C. Miller <Todd.Miller@courtesan.com>
License: ISC
Permission to use, copy, modify, and distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.
.
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
Files: oficonv/libsrc/data_csmapper.*
oficonv/libsrc/data_esdb.*
oficonv/libsrc/oficonv_logger.*
oficonv/tests/*
Copyright: 2022-2025, OFFIS e.V.
License: OFFISeV
License: BSD-2-clause
Redistribution and use in source and binary forms, with or without modifica-
tion, are permitted provided that the following conditions are met:
.
1. Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
.
THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED WARRANTIES,
INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
APACHE SOFTWARE FOUNDATION OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLU-
DING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Files: oflog/include/dcmtk/oflog/config/macosx.h
Copyright: 2003-2010 Christopher R. Bailey
License: Apache-2.0
Files: oflog/include/dcmtk/oflog/windebap.h
oflog/libsrc/windebap.cc
Copyright: 2003-2010 Eduardo Francos, Odalio SARL
License: Apache-2.0
Files: oflog/libsrc/clogger.cc
oflog/include/dcmtk/oflog/clogger.h
Copyright: 2011 Jens Rehsack and Tad E. Smith
License: Apache-2.0
Files: oflog/include/dcmtk/oflog/ntelogap.h
oflog/libsrc/ntelogap.cc
Copyright: 2003-2010 Michael CATANZARITI
License: Apache-2.0
Files: oflog/include/dcmtk/oflog/log4judp.h
oflog/libsrc/log4judp.cc
Copyright: 2012 Siva Chandran P
License: Apache-2.0
Files: oflog/docs/*
Copyright: 1999-2009 Contributors to log4cplus project
License: Apache-2.0
Files: config/stdcxx.m4
config/tests/cxx11.cc
config/tests/cxx14.cc
config/tests/cxx17.cc
config/tests/cxx20.cc
Copyright: 2008 Benjamin Kosnik <bkoz@redhat.com>
2012 Zack Weinberg <zackw@panix.com>
2013 Roy Stogner <roystgnr@ices.utexas.edu>
2014, 2015 Google Inc.; contributed by Alexey Sokolov <sokolov@google.com>
2015 Paul Norman <penorman@mac.com>
2015 Moritz Klammler <moritz@klammler.eu>
2016 Krzesimir Nowak <qdlacz@gmail.com>
2019 Enji Cooper <yaneurabeya@gmail.com>
2020 Jason Merrill <jason@redhat.com>
2021 Joern Heusipp <osmanx@problemloesungsmaschine.de>
License: FSFAP
Copying and distribution of this file, with or without modification, are
permitted in any medium without royalty provided the copyright notice
and this notice are preserved. This file is offered as-is, without any
warranty.
Files: oflog/include/dcmtk/oflog/appender.h
oflog/include/dcmtk/oflog/config/win32.h
oflog/include/dcmtk/oflog/configrt.h
oflog/include/dcmtk/oflog/consap.h
oflog/include/dcmtk/oflog/fileap.h
oflog/include/dcmtk/oflog/fstreams.h
oflog/include/dcmtk/oflog/helpers/apndimpl.h
oflog/include/dcmtk/oflog/helpers/lloguser.h
oflog/include/dcmtk/oflog/helpers/loglog.h
oflog/include/dcmtk/oflog/helpers/pointer.h
oflog/include/dcmtk/oflog/helpers/property.h
oflog/include/dcmtk/oflog/helpers/sleep.h
oflog/include/dcmtk/oflog/helpers/sockbuff.h
oflog/include/dcmtk/oflog/helpers/socket.h
oflog/include/dcmtk/oflog/helpers/strhelp.h
oflog/include/dcmtk/oflog/helpers/threadcf.h
oflog/include/dcmtk/oflog/helpers/timehelp.h
oflog/include/dcmtk/oflog/hierarchy.h
oflog/include/dcmtk/oflog/hierlock.h
oflog/include/dcmtk/oflog/layout.h
oflog/include/dcmtk/oflog/logger.h
oflog/include/dcmtk/oflog/loglevel.h
oflog/include/dcmtk/oflog/logmacro.h
oflog/include/dcmtk/oflog/ndc.h
oflog/include/dcmtk/oflog/nullap.h
oflog/include/dcmtk/oflog/socketap.h
oflog/include/dcmtk/oflog/spi/apndatch.h
oflog/include/dcmtk/oflog/spi/factory.h
oflog/include/dcmtk/oflog/spi/filter.h
oflog/include/dcmtk/oflog/spi/logevent.h
oflog/include/dcmtk/oflog/spi/logfact.h
oflog/include/dcmtk/oflog/spi/logimpl.h
oflog/include/dcmtk/oflog/spi/objreg.h
oflog/include/dcmtk/oflog/spi/rootlog.h
oflog/include/dcmtk/oflog/streams.h
oflog/include/dcmtk/oflog/syslogap.h
oflog/include/dcmtk/oflog/thread/impl/thredimp.h
oflog/include/dcmtk/oflog/thread/threads.h
oflog/include/dcmtk/oflog/tstring.h
oflog/libsrc/apndimpl.cc
oflog/libsrc/appender.cc
oflog/libsrc/config.cc
oflog/libsrc/consap.cc
oflog/libsrc/factory.cc
oflog/libsrc/fileap.cc
oflog/libsrc/filter.cc
oflog/libsrc/globinit.cc
oflog/libsrc/hierarchy.cc
oflog/libsrc/hierlock.cc
oflog/libsrc/layout.cc
oflog/libsrc/lloguser.cc
oflog/libsrc/logevent.cc
oflog/libsrc/logger.cc
oflog/libsrc/logimpl.cc
oflog/libsrc/loglevel.cc
oflog/libsrc/loglog.cc
oflog/libsrc/ndc.cc
oflog/libsrc/nullap.cc
oflog/libsrc/objreg.cc
oflog/libsrc/patlay.cc
oflog/libsrc/pointer.cc
oflog/libsrc/property.cc
oflog/libsrc/rootlog.cc
oflog/libsrc/sleep.cc
oflog/libsrc/sockbuff.cc
oflog/libsrc/socket.cc
oflog/libsrc/socketap.cc
oflog/libsrc/strhelp.cc
oflog/libsrc/syslogap.cc
oflog/libsrc/threads.cc
oflog/libsrc/timehelp.cc
oflog/libsrc/unixsock.cc
oflog/libsrc/winsock.cc
Copyright: 2001-2010 Tad E. Smith
License: Apache-2.0
Files: oflog/include/dcmtk/oflog/tracelog.h
oflog/libsrc/logmacro.cc
Copyright: 2010 Vaclav Haisman
License: Apache-2.0
Files: dcmjpls/libcharls/*
Copyright: 2007-2010, Jan de Vaan
License: BSD-3-clause
Files: ofstd/tests/tstring.cc
Copyright: 1997-2011, OFFIS e.V.
1994 Free Software Foundation
License: GPL-2.0+
All rights reserved. See COPYRIGHT file for details.
.
This software and supporting documentation were developed by
.
OFFIS e.V.
R&D Division Health
Escherweg 2
D-26121 Oldenburg, Germany
.
This file is part of the GNU ANSI C++ Library. This library is free
software; you can redistribute it and/or modify it under the terms of
the GNU General Public License as published by the Free Software
Foundation; either version 2, or (at your option) any later version.
.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
You should have received a copy of the GNU General Public License
along with this library; see the file COPYING, if not, see
<http://www.gnu.org/licenses/>.
.
On Debian systems, the complete text of the GNU General Public License
version 2 can be found in "/usr/share/common-licenses/GPL-2".
Files: debian/*
Copyright: 2005-2011 Juergen Salk <juergen.salk@gmx.de> on
2011-2014 Mathieu Malaterre <malat@debian.org>
2014-2015 Andreas Tille <tille@debian.org>
2015-2018 Gert Wollny <gw.fossdev@gmail.com>
2025-2026 Étienne Mollier <emollier@debian.org>
License: BSD-3-clause
Files: ofstd/include/dcmtk/ofstd/ofjsmn.h
Copyright: 2010 Serge Zaitsev
License: Expat
Files: ofstd/include/dcmtk/ofstd/ofxml.h
ofstd/libsrc/ofxml.cc
Copyright: 2002, Frank Vanden Berghen
License: dcmtk-or-AFPL
The following license terms apply to projects that are in some way related to
the "DCMTK project", including applications
using "DCMTK project" and tools developed
for enhancing "DCMTK project". All other projects
(not related to "DCMTK project") have to use this
code under the Aladdin Free Public License (AFPL)
See the file "AFPL-license.txt" for more information about the AFPL license.
.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
* Neither the name of Frank Vanden Berghen nor the
names of its contributors may be used to endorse or promote products
derived from this software without specific prior written permission.
THIS SOFTWARE IS PROVIDED BY Frank Vanden Berghen ``AS IS'' AND ANY
EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL <copyright holder> BE LIABLE FOR ANY
DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Comment:
Verbatim copy of the license text included a broken link to the full
AFPL text. Known copies are available here[1] and there[2].
Nevertheless, AFPL is not DFSG compliant, so DCMTK terms must be chosen.
.
[1]: https://web.mit.edu/ghostscript/www/Public.htm#fulltext
[2]: https://web.archive.org/web/20010314181518/http://www.ghostscript.com/doc/cvs/Public.htm
Files: ofstd/include/dcmtk/ofstd/ofwhere.h
ofstd/libsrc/ofwhere.c
Copyright: 2024 Gregory Pakosz
License: Expat
Files: ofstd/libsrc/ofstub.cc
Copyright: 2024-2025, OFFIS e.V.
2011-2015 Ryan Prichard
License: OFFISeV or Expat
Comment:
The function argvToCommandLine() is derived from an implementation
with the Expat copyright statement.
License: Expat
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
Files: dcmrt/*
Copyright: 2008-2012, OFFIS e.V. and ICSMED AG, Oldenburg, Germany
2013-2021, J. Riesmeier, Oldenburg, Germany
License: BSD-3-clause-Riesmeier
Files: dcmsr/include/dcmtk/dcmsr/dsrdncsr.h
dcmsr/include/dcmtk/dcmsr/dsrsaecc.h
dcmsr/libsrc/dsrdncsr.cc
dcmsr/libsrc/dsrsaecc.cc
dcmsr/include/dcmtk/dcmsr/cmr/tid1419m.h
dcmsr/include/dcmtk/dcmsr/cmr/tid1501.h
dcmsr/include/dcmtk/dcmsr/cmr/tid15def.h
dcmsr/include/dcmtk/dcmsr/cmr/tid300.h
dcmsr/include/dcmtk/dcmsr/dsrdnflt.h
dcmsr/include/dcmtk/dcmsr/dsritcsr.h
dcmsr/include/dcmtk/dcmsr/dsrprdcc.h
dcmsr/include/dcmtk/dcmsr/dsrpficc.h
dcmsr/libsrc/dsrpficc.cc
dcmsr/libsrc/dsrplicc.cc
dcmsr/libcmr/tid1419m.cc
dcmsr/libcmr/tid1501.cc
dcmsr/libcmr/tid15def.cc
dcmsr/libsrc/dsrdnflt.cc
dcmsr/libsrc/dsritcsr.cc
dcmsr/libsrc/dsrprdcc.cc
Copyright: 2016-2021, J. Riesmeier, Oldenburg, Germany
License: OFFISeV
Files: dcmect/include/dcmtk/dcmect/def.h
dcmect/include/dcmtk/dcmect/enhanced_ct.h
dcmect/include/dcmtk/dcmect/types.h
dcmect/libsrc/enhanced_ct.cc
dcmect/libsrc/types.cc
Copyright: 2019 Open Connections GmbH
License: OFFISeV
Files: dcmrt/include/dcmtk/dcmrt/drttypes.h
dcmrt/libsrc/drttypes.cc
dcmrt/libsrc/drtbvcps.cc
dcmrt/libsrc/drtmas.cc
Copyright: 2008-2012, OFFIS e.V. and ICSMED AG, Oldenburg, Germany
2013-2019, J. Riesmeier, Oldenburg, Germany
License: BSD-3-clause-Riesmeier
Files: dcmrt/include/dcmtk/dcmrt/drmdose.h
dcmrt/include/dcmtk/dcmrt/drmsrch.h
dcmrt/include/dcmtk/dcmrt/drmstrct.h
dcmrt/include/dcmtk/dcmrt/drmplan.h
dcmrt/libsrc/drmimage.cc
dcmrt/libsrc/drmplan.cc
dcmrt/libsrc/drmstrct.cc
dcmrt/tests/tsearch.cc
Copyright: 2012, OFFIS e.V.
License: OFFISeV
Files: dcmrt/libsrc/drmdose.cc
Copyright: 2012-2015, OFFIS e.V.
License: OFFISeV
Files: dcmrt/include/dcmtk/dcmrt/drmimage.h
dcmrt/tests/tests.cc
Copyright: 2012-2016, OFFIS e.V.
License: OFFISeV
Files: dcmfg/include/dcmtk/dcmfg/fgframeanatomy.h
dcmfg/include/dcmtk/dcmfg/fgpixeltransform.h
dcmfg/include/dcmtk/dcmfg/fgparametricmapframetype.h
dcmfg/libsrc/fgframeanatomy.cc
dcmfg/libsrc/fgpixeltransform.cc
dcmfg/libsrc/fgparametricmapframetype.cc
dcmiod/include/dcmtk/dcmiod/iodcontentitemmacro.h
dcmiod/include/dcmtk/dcmiod/iodreferences.h
dcmiod/include/dcmtk/dcmiod/modfloatingpointimagepixel.h
dcmiod/include/dcmtk/dcmiod/modimagepixelbase.h
dcmiod/include/dcmtk/dcmiod/modimagepixelvariant.h
dcmiod/libsrc/iodcontentitemmacro.cc
dcmiod/libsrc/iodreferences.cc
dcmiod/libsrc/modfloatingpointimagepixel.cc
dcmiod/libsrc/modimagepixelbase.cc
dcmdata/tests/tnewdcme.cc
Copyright: Copyright (C) 2017, Open Connections GmbH
License: OFFISeV
Files: config/configure
config/confmod
Copyright: 1992-1996, 1998-2012 Free Software Foundation, Inc.
License: FSFUL
This configure script is free software; the Free Software Foundation
gives unlimited permission to copy, distribute and modify it.
Files: config/install-sh
Copyright: 1994 X Consortium
License: X11
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to
deal in the Software without restriction, including without limitation the
rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
sell copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
X CONSORTIUM BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNEC-
TION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
.
Except as contained in this notice, the name of the X Consortium shall not
be used in advertising or otherwise to promote the sale, use or other deal-
ings in this Software without prior written authorization from the X Consor-
tium.
Comment:
FSF changes to this file are in the public domain.
Files: dcmjpls/docs/License.txt
dcmjpls/docs/dcmjpls.dox
Copyright: 2007-2010, Jan de Vaan
License: BSD-3-clause
License: Apache-2.0
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
.
http://www.apache.org/licenses/LICENSE-2.0
.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
.
On Debian GNU/Linux systems you can find this license under
/usr/share/common-licenses/Apache-2.0
License: BSD-3-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
3. The name of the author may not be used to endorse or promote products
derived from this software without specific prior written permission.
*
THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL
THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
License: BSD-3-clause-Riesmeier
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
.
* Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.
.
* Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
.
* Neither the name of the copyright holders nor the names of its
contributors may be used to endorse or promote products derived from this
software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.
License: OFFISeV
This software and supporting documentation were developed by
.
OFFIS e.V.
R&D Division Health
Escherweg 2
26121 Oldenburg, Germany
.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
- Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
- Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
- Neither the name of OFFIS nor the names of its contributors may be
used to endorse or promote products derived from this software
without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
DFSG Assistant LLM REVIEW 3 blocker, 2 important, 5 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 21 days ago.
Report
DFSG NEW review for dcmtk version 3.7.1+dfsg-1~0exp0
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 3 blocker, 2 important, 5 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: 91 found (42 not listed by the scan, so not checked)
Licensing
The repack is incomplete. Ten oficonv mapping sources (JIS and KS) still carry the old Unicode, Inc. notice that forbids redistribution to third parties, and the compiled .mps tables plus their generated C headers for the ISO-8859 and three GB2312 mappings remain in the tree and in the binaries although their .src sources were removed. debian/copyright calls all of oficonv/* Citrus BSD-2 and never mentions Unicode, Inc.; several other holders (Pascal Getreuer/Open Connections, Tyler Streeter, Newcastle University) and the GPL-2+ Autoconf exception of config.guess/config.sub are also missing.
Packaging
The packaging is otherwise of good quality: compat 13 with dh and cmake, clean package split, current Standards-Version 4.7.4, doc-main-package-aware documentation, and correct quilt/patch setup. It needs the missing libssl-dev dependency of libdcmtk-dev fixed, and several small defects cleaned up: an ABI guard that never runs, a jquery symlink in the wrong doc directory, stale dcmqrscp init/default files with contradicting documentation, and an autopkgtest that cannot fail.
Issues
blocker licensing 1. Unicode mapping tables forbidding redistribution remain in the source package ◂
- Files:
oficonv/datasrc/csmapper/JIS/JISX0201-KANA%UCS.src:22-35,oficonv/datasrc/csmapper/JIS/JISX0208@1990%UCS.src:22-35,oficonv/datasrc/csmapper/JIS/JISX0212%UCS.src:22-35,oficonv/datasrc/csmapper/JIS/UCS%JISX0201-KANA.src:22-35,oficonv/datasrc/csmapper/JIS/UCS%JISX0208@1990.src:22-35,oficonv/datasrc/csmapper/JIS/UCS%JISX0212.src:22-35,oficonv/datasrc/csmapper/KS/KSC5601HANGUL%UCS.src:35,oficonv/datasrc/csmapper/KS/KSC5601HANJA%UCS.src:35,oficonv/datasrc/csmapper/KS/UCS%KSC5601HANGUL.src:35,oficonv/datasrc/csmapper/KS/UCS%KSC5601HANJA.src:35,oficonv/data/csmapper/JIS/JISX0201-KANA%UCS.mps,oficonv/data/csmapper/JIS/JISX0208@1990%UCS.mps,oficonv/data/csmapper/JIS/JISX0212%UCS.mps,oficonv/data/csmapper/JIS/UCS%JISX0201-KANA.mps,oficonv/data/csmapper/JIS/UCS%JISX0208@1990.mps,oficonv/data/csmapper/JIS/UCS%JISX0212.mps,oficonv/data/csmapper/KS/KSC5601HANGUL%UCS.mps,oficonv/data/csmapper/KS/KSC5601HANJA%UCS.mps,oficonv/data/csmapper/KS/UCS%KSC5601HANGUL.mps,oficonv/data/csmapper/KS/UCS%KSC5601HANJA.mps,debian/copyright:204 - Basis: checked, in the package or with a reference tool
- Evidence:
# Copyright (c) 1991-1994 Unicode, Inc. All Rights reserved....Unicode, Inc. specifically excludes the right to re-distribute this file directly to third parties or other organizations whether for profit or not. - Problem: These ten mapping files carry a licence term that forbids redistribution, so they are non-free under the DFSG. The copyright file nevertheless blanket-labels
oficonv/*as Citrus BSD-2-clause, and these charsets are also compiled into libdcmtk21 (oficonv/libsrc/data_csmapper.c includes csmapper_jis_.h and csmapper_ks_.h) and installed in dcmtk-data. - Fix: Exclude these .src files and their derived .mps/.h files in the repack (or replace the tables with data under a free Unicode licence), list them in Files-Excluded, and document the actual situation in debian/copyright.
blocker licensing 2. Compiled mapping data whose sources were excluded is still shipped and embedded ◂
- Files:
debian/copyright:6-28,oficonv/datasrc/CMakeLists.txt:12,oficonv/datasrc/CMakeLists.txt:26-45,oficonv/data/csmapper/ISO-8859/ISO-8859-2%UCS.mps,oficonv/data/csmapper/ISO-8859/ISO-8859-3%UCS.mps,oficonv/data/csmapper/ISO-8859/ISO-8859-4%UCS.mps,oficonv/data/csmapper/ISO-8859/ISO-8859-5%UCS.mps,oficonv/data/csmapper/ISO-8859/ISO-8859-6%UCS.mps,oficonv/data/csmapper/ISO-8859/ISO-8859-7%UCS.mps,oficonv/data/csmapper/ISO-8859/ISO-8859-8%UCS.mps,oficonv/data/csmapper/ISO-8859/ISO-8859-9%UCS.mps,oficonv/data/csmapper/ISO-8859/ISO-8859-11%UCS.mps,oficonv/data/csmapper/ISO-8859/ISO-8859-15%UCS.mps,oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-2.mps,oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-3.mps,oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-4.mps,oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-5.mps,oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-6.mps,oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-7.mps,oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-8.mps,oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-9.mps,oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-11.mps,oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-15.mps,oficonv/data/csmapper/GB/GB2312%UCS.mps,oficonv/data/csmapper/GB/GB2312GBK%UCS.mps,oficonv/data/csmapper/GB/UCS%GB2312.mps,oficonv/libsrc/csmapper_iso_8859_iso_8859_2_ucs_mps.h,oficonv/libsrc/csmapper_iso_8859_ucs_iso_8859_2_mps.h,oficonv/libsrc/csmapper_gb_gb2312_ucs_mps.h,oficonv/libsrc/csmapper_gb_gb2312gbk_ucs_mps.h,oficonv/libsrc/csmapper_gb_ucs_gb2312_mps.h - Basis: checked, in the package or with a reference tool
- Evidence:
Files-Excluded: oficonv/datasrc/csmapper/ISO-8859/ISO-8859-2%UCS.src ...while oficonv/datasrc/CMakeLists.txt:26 readsCOMMAND mkcsmapper -o ".../data/csmapper/ISO-8859/ISO-8859-2%UCS.mps" ".../datasrc/csmapper/ISO-8859/ISO-8859-2%UCS.src", and oficonv/data/CMakeLists.txt installs those .mps into dcmtk-data. - Problem: The sources of these twenty ISO-8859 and three GB2312 mapping tables were deleted, but the tables themselves survive as generated binary .mps files and as xxd-generated headers that oficonv/libsrc/data_csmapper.c compiles into libdcmtk21 (DCMTK_ENABLE_BUILTIN_OFICONV_DATA is ON). That is both a DFSG 2 problem (no preferred form for modification left) and a continuation of the very licensing problem the repack was meant to remove.
- Fix: Either keep the .src files and document a free licence for them, or remove the corresponding .mps and generated csmapper_*.h as well, adjust oficonv/data/CMakeLists.txt and data_csmapper.c accordingly, and update Files-Excluded/copyright.
blocker licensing 3. debian/copyright misdescribes the whole oficonv tree and omits Unicode, Inc. ◂
- Files:
debian/copyright:202-204,debian/copyright:339-344 - Basis: checked, in the package or with a reference tool
- Evidence:
Files: oficonv/*/Copyright: 2003-2008 Citrus Project/License: BSD-2-clause - Problem: This stanza covers oficonv/datasrc and oficonv/data as well, including the Unicode mapping tables and the generated .mps data, whose holders and terms are different. Unicode, Inc. is never named, and the compiled csmapper_*.h files are attributed to Citrus although they are generated data with no such notice. The file is therefore neither accurate nor complete.
- Fix: Add dedicated Files stanzas for oficonv/datasrc/csmapper and oficonv/data (including the generated csmapper_*.h) with the correct holders, licences and, where needed, licence text, and make Files-Excluded consistent with the outcome.
important licensing 4. Several copyright holders and one licence are missing from debian/copyright ◂
- Files:
dcmiod/include/dcmtk/dcmiod/cielabutil.h:3,dcmiod/libsrc/cielabutil.cc:3,ofstd/include/dcmtk/ofstd/oftest.h:7,oficonv/libsrc/windows_mmap.h:2,oflog/include/dcmtk/oflog/clfsap.h:8,oflog/include/dcmtk/oflog/config/windowsh.h:8,ofstd/libsrc/ofstd.cc:11-86,config/config.guess:3-23,config/config.sub:3-26 - Basis: checked, in the package or with a reference tool
- Evidence:
Copyright (C) 2016-2026, Pascal Getreuer, Open Connections GmbH;This code is inspired by quicktest. Copyright (C) 2005-2008 Tyler Streeter;Copyright (c) 2014, Newcastle University, UK.;Copyright (C) 2010-2012, Vaclav Zeman; config.guess/config.sub:under the terms of the GNU General Public License ... either version 2 ... or (at your option) any later versionwith the Autoconf exception. - Problem: Files:* attributes these files to OFFIS e.V. under OFFISeV. cielabutil is adapted from Pascal Getreuer's BSD-2 package (upstream COPYRIGHT:577-600), oftest.h is based on QuickTest (BSD fallback), windows_mmap.h is Newcastle BSD-2, and the oflog Windows/fragment files are Vaclav Zeman's BSD-2; ofstd.cc contains UC Berkeley/Todd Miller/Bob Withers portions under their own permissive terms; config.guess and config.sub are GPL-2+ with the Autoconf special exception, not the FSFUL given for config/configure.
- Fix: Add the missing copyright holders and, for config.guess/config.sub, a GPL-2+ with Autoconf-exception stanza; split ofstd.cc out with its additional holders and the correct terms.
important packaging 5. libdcmtk-dev lacks the libssl-dev dependency required by a public header ◂
- Files:
debian/control:73-80,dcmsign/include/dcmtk/dcmsign/simdmac.h:28-35,CMake/osconfig.h.in:493 - Basis: checked, in the package or with a reference tool
- Evidence:
#ifdef WITH_OPENSSL/#include <openssl/opensslv.h>, with#cmakedefine WITH_OPENSSLin the installed osconfig.h (the package is built with DCMTK_WITH_OPENSSL=ON); libdcmtk-dev Depends lists libxml2-dev and libz-dev but not libssl-dev. - Problem: libdcmtk-dev installs /usr/include/dcmtk/dcmsign/simdmac.h, which includes an OpenSSL header whenever WITH_OPENSSL is defined in the installed osconfig.h. A reverse dependency compiling that public API without libssl-dev installed will fail; -dev packages must depend on the packages providing the headers they include.
- Fix: Add libssl-dev to libdcmtk-dev Depends.
minor licensing 6. IJG documentation files other than ijg_readme.txt fall under Files: * ◂
- Files:
dcmjpeg/docs/ijg_libjpeg.txt:1,dcmjpeg/docs/ijg_filelist.txt:1,dcmjpeg/docs/ijg_structure.txt:1 - Basis: checked, in the package or with a reference tool
- Evidence: The JPEG stanza names only
dcmjpeg/libijg8/*,dcmjpeg/libijg12/*,dcmjpeg/libijg16/*anddcmjpeg/docs/ijg_readme.txt, while the other ijg_*.txt files carry the IJG notice. - Problem: They are therefore attributed to OFFIS e.V. under OFFISeV instead of Thomas G. Lane/IJG under the JPEG licence.
- Fix: Widen the JPEG stanza to
dcmjpeg/docs/ijg_*.txtor add the three files to it.
minor packaging 7. dcmtk-doc jquery symlink is created in the wrong documentation directory ◂
- Files:
debian/rules:108-109,debian/dcmtk-doc.docs:1,debian/dcmtk-doc.doc-base:7 - Basis: checked, in the package or with a reference tool
- Evidence:
dh_link -pdcmtk-doc usr/share/javascript/jquery/jquery.js usr/share/doc/dcmtk-doc/html/jquery.js, while dh_installdocs at compat 13 auto-detects dcmtk as doc-main-package and installs the HTML under /usr/share/doc/dcmtk/dcmtk-3.7.1/html (as the doc-base Index path says). - Problem: The symlink ends up in /usr/share/doc/dcmtk-doc/html/, next to no HTML, and the jquery.js used by the generated pages is still absent from the html directory.
- Fix: Point the link at usr/share/doc/dcmtk/dcmtk-3.7.1/html/jquery.js (or drop it and the libjs-jquery dependency if the current doxygen output no longer uses jquery).
minor packaging 8. Autopkgtest can never fail on its final integrity check ◂
- Files:
debian/tests/run-unit-test:20,debian/tests/run-unit-test:37-78 - Basis: checked, in the package or with a reference tool
- Evidence: The checksum recorded at the start is of the unmodified CT_small.dcm, but Test 9 runs
dcmodify --write-dataset -e "(0008,0031)" CT_small.dcmin place; the finalif ... md5sum --check checksums; then echo PASS; else echo FAIL; fidoes not exit non-zero andset -eis suppressed inside the condition. - Problem: A failed checksum prints FAIL but the script exits 0, so the autopkgtest reports success regardless of the check; and the check itself compares against a file the test has modified.
- Fix: Checksum a file that is not modified (or record it after Test 9), and
exit 1in the else branch.
minor packaging 9. The ABI guard in debian/rules never runs ◂
- Files:
debian/rules:60-75 - Basis: checked, in the package or with a reference tool
- Evidence: The guard is an
execute_before_dh_autoreconftarget, but the rules file usesdh $@ --buildsystem=cmakeand neither build-depends on dh-sequence-autoreconf nor passes--with autoreconf; dh_autoreconf is not in debhelper's default sequence at compat 13 (debian/control has no dh-sequence-autoreconf). - Problem: The check added in 3.7.0+really3.7.0-0+exp1 to stop a SONAME/package-name mismatch therefore never executes, so a future DCMTK_ABI_VERSION bump would not be caught.
- Fix: Run the check from an unconditional target (e.g. override_dh_auto_configure) or add dh-sequence-autoreconf so the hook is reached.
minor packaging 10. Stale dcmqrscp init/default files and contradicting README instructions ◂
- Files:
debian/dcmqrscp.init:1,debian/dcmqrscp.default:1,debian/dcmtk.README.Debian:60-66 - Basis: checked, in the package or with a reference tool
- Evidence:
debian/dcmqrscp.initanddebian/dcmqrscp.defaultexist, but the only binary package is dcmtk and there is nodh_installinit --name=dcmqrscpin debian/rules; the maintscript removes /etc/init.d/dcmqrscp and /etc/default/dcmqrscp. README.Debian still says dcmqrscpcan be invoked as a daemon process at boot time by setting DCMQRSCP_ENABLE=Yes in /etc/defaults/dcmqrscp. - Problem: The files are never installed, yet they look maintained; users are told to set an option in a non-existent path (/etc/defaults instead of /etc/default) to start a service the package no longer ships. The packaged /etc/dcmtk/dcmqrscp.cfg is likewise unreachable through a service.
- Fix: Remove the two dead files and update README.Debian to describe how dcmqrscp is actually started (or restore the init script via dh_installinit --name=dcmqrscp and fix the path).
Verified ◂
- debian/copyright was read in full (835 lines): it is DEP-5 with a correct Format URL, 23 Files-Excluded entries (all of which are indeed absent), a Files:* catch-all and the stanzas listed above.
- The tree was inventoried directory by directory and searched for Copyright/(C)/©, SPDX-License-Identifier, Licensed under, Permission is hereby granted, GNU General Public, GNU Lesser, Apache License, Mozilla Public, public domain and All rights reserved. The only separate licence files are COPYRIGHT, oflog/docs/LICENSE and dcmjpls/docs/License.txt.
- The oflog Apache-2.0 stanzas match the per-file Apache headers, and the BSD-2 log4cplus files (e.g. oflog/include/dcmtk/oflog/config/windowsh.h, oflog/include/dcmtk/oflog/helpers/fileinfo.h) are under the oflog/* BSD-2 stanza, though with a generic holder.
- dcmjpls/libcharls (BSD-3, Jan de Vaan) and dcmjpeg/libijg* (IJG) are correctly covered; dcmrt, dcmect, dcmfg/dcmiod, dcmsr, dcmnet and config/install-sh stanzas match the file notices I sampled.
- The 82 unrecognised binary files from the scan are oficonv code-page data: oficonv/data/csmapper/CP/CP936EXT%UCS.mps, oficonv/data/csmapper/CP/UCS%CP936EXT.mps, oficonv/data/csmapper/GB/GB18030%UCS@BMP.mps, oficonv/data/csmapper/GB/GB2312%UCS.mps, oficonv/data/csmapper/GB/GB2312EXT%UCS.mps, oficonv/data/csmapper/GB/GB2312GBK%UCS.mps, oficonv/data/csmapper/GB/GB2312UDA1%UCS.mps, oficonv/data/csmapper/GB/GB2312UDA2%UCS.mps, oficonv/data/csmapper/GB/GBKEXT%UCS.mps, oficonv/data/csmapper/GB/GBKUDA%UCS.mps, oficonv/data/csmapper/GB/UCS%GB2312.mps, oficonv/data/csmapper/GB/UCS%GB2312EXT.mps, oficonv/data/csmapper/GB/UCS%GB2312UDA1.mps, oficonv/data/csmapper/GB/UCS%GB2312UDA2.mps, oficonv/data/csmapper/GB/UCS%GBKEXT.mps, oficonv/data/csmapper/GB/UCS%GBKUDA.mps, oficonv/data/csmapper/GB/UCS@BMP%GB18030.mps, oficonv/data/csmapper/ISO-8859/ISO-8859-11%UCS.mps, oficonv/data/csmapper/ISO-8859/ISO-8859-15%UCS.mps, oficonv/data/csmapper/ISO-8859/ISO-8859-2%UCS.mps, oficonv/data/csmapper/ISO-8859/ISO-8859-3%UCS.mps, oficonv/data/csmapper/ISO-8859/ISO-8859-4%UCS.mps, oficonv/data/csmapper/ISO-8859/ISO-8859-5%UCS.mps, oficonv/data/csmapper/ISO-8859/ISO-8859-6%UCS.mps, oficonv/data/csmapper/ISO-8859/ISO-8859-7%UCS.mps, oficonv/data/csmapper/ISO-8859/ISO-8859-8%UCS.mps, oficonv/data/csmapper/ISO-8859/ISO-8859-9%UCS.mps, oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-11.mps, oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-15.mps, oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-2.mps, oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-3.mps, oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-4.mps, oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-5.mps, oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-6.mps, oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-7.mps, oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-8.mps, oficonv/data/csmapper/ISO-8859/UCS%ISO-8859-9.mps, oficonv/data/csmapper/JIS/JISX0201-KANA%UCS.mps, oficonv/data/csmapper/JIS/JISX0208@1990%UCS.mps and oficonv/data/csmapper/JIS/JISX0212%UCS.mps, plus the remaining KS and reverse-JIS .mps, the oficonv/data/esdb .esdb/esdb.db files, mapper.dir.db, charset.pivot.pvdb and the ISO646 *.646 copies. All are generated by mkcsmapper/mkesdb from oficonv/datasrc (oficonv/datasrc/CMakeLists.txt); the ISO-8859 and three GB2312 ones are reported as blockers because their .src files are gone.
- Generated .mps whose source .src is present and whose notice is the Citrus BSD licence, so they are not issues in themselves: oficonv/data/csmapper/CP/UCS%CP936EXT.mps, oficonv/data/csmapper/GB/GB18030%UCS@BMP.mps, oficonv/data/csmapper/GB/GB2312EXT%UCS.mps, oficonv/data/csmapper/GB/GB2312UDA1%UCS.mps, oficonv/data/csmapper/GB/GB2312UDA2%UCS.mps, oficonv/data/csmapper/GB/GBKEXT%UCS.mps, oficonv/data/csmapper/GB/GBKUDA%UCS.mps, oficonv/data/csmapper/GB/UCS%GB2312EXT.mps, oficonv/data/csmapper/GB/UCS%GB2312UDA1.mps, oficonv/data/csmapper/GB/UCS%GB2312UDA2.mps, oficonv/data/csmapper/GB/UCS%GBKEXT.mps, oficonv/data/csmapper/GB/UCS%GBKUDA.mps and oficonv/data/csmapper/GB/UCS@BMP%GB18030.mps; the JIS .mps oficonv/data/csmapper/JIS/JISX0201-KANA%UCS.mps, oficonv/data/csmapper/JIS/JISX0208@1990%UCS.mps and oficonv/data/csmapper/JIS/JISX0212%UCS.mps are compiled from the non-free JIS sources reported in the first issue.
- The nine rare-licence hits were identified: COPYRIGHT:180 and debian/copyright:169 are the IJG licence text (free, documented in the JPEG stanza); COPYRIGHT:1218 is the OpenSSL/SSLeay text for the system libssl DCMTK links against; dcmjpeg/docs/ijg_libjpeg.txt:312,373,558 and ijg_readme.txt:151,315 are API prose and the IJG licence, not additional restrictions; ofstd/include/dcmtk/ofstd/ofmap.h:62 is a comment about const iterators.
- The holder check was worked through: Wietse Venema, Eric Young, Jean-loup Gailly/Mark Adler, Glenn Randers-Pehrson, Guy Eric Schalnat, Sam Leffler and Silicon Graphics occur only in COPYRIGHT's notices for third-party libraries (libwrap, OpenSSL, zlib, libpng, libtiff), not in code in this tree; Gary S. Brown's CRC code is used under his unrestricted/public-domain terms; 'Chapter 29, pp. 183-213' in oflog/helpers/pointer.h is a book citation; the OFFIS e&.V&. hits are escaped man-page text.
- No .jar, .class, .exe, .dll, .so, .pyc or PDF files exist. The bison/flex outputs (oficonv/apps/*_bison.cc, *_flex.cc) have their .y/.l inputs, config/configure is generated from config/configure.in, and the doxygen man pages are generated from the shipped sources.
- All files under debian/ were read (control, rules, changelog head, source/format, install/docs/examples/manpages/dirs files, maintainer scripts, maintscript, sysusers, tmpfiles, doc-base, tests, upstream/metadata, patches/series and every patch, lintian overrides).
- Packaging checks: compat 13 dh + cmake, ${misc:Depends}/${shlibs:Depends} present where needed (compat 13), Standards-Version 4.7.4 against Policy 4.7.4.1, Vcs-* and Homepage present, packages split sensibly, doc-main-package installation and the doc-base Index path agree, dh_installsysusers/dh-cruft used for the dcmtk user and /var/lib/dcmtk/db.
- uscan found the packaged version as the newest upstream release (upstream
3.7.1, packaged3.7.1+dfsg). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (Apache-2.0,GPL-2,GPL-3).
Not confirmed ◂
- oficonv/datasrc/csmapper/CP/*.src, GB/GB2312EXT%UCS.src, GB/UCS%GB2312EXT.src and the other GB tables that were not excluded carry no licence statement of their own, only a note that the mapping data came from Unicode, Inc.; whether the package's blanket BSD terms can cover the Microsoft cp936 table data is not stated anywhere.
- Whether the doxygen version used for the build still emits jquery.js into the HTML directory; if it does not, the libjs-jquery dependency is unnecessary as well as the symlink misplaced.
- The custom target oficonv_data_files references the removed .src files and would fail if invoked; it is not part of the default build (no ALL), so a normal build is unaffected, but it no longer works.
debian/watchlooks atgithub.com/dcmtk/dcmtk, but theSourcefield ofdebian/copyrightnamesgithub.com/commontk/dcmtk. Whether these are the same upstream was not checked.
Proposed changes ◂
None.
Review Information
rejected — allocated to awm 21 days ago, started 21 days ago, completed 21 days ago.
Final Comment
Hi,
The LLM Review has found some evidence of files that should not be in the package, either because they are licensed in a way that is not distributable, or the compiled files are in place when the sources have been excluded. I looked in the package myself, and while some of this seems true, there's a different read on what is written there which says that the LLM is just misunderstanding what is going on.
Can you reply with your understanding of these issues (see full review at link below)?
There are a few less important issues which the LLM identifies which probably should be fixed, and which I do have more confidence in, so I have rejected the package anyway, but the ones the LLM considers blockers seem more likely to be misunderstandings.
I welcome any other comments, too, of course.
Thanks!
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 3.7.0+really3.7.0-0+exp1 | 106a7bc8… | 2026-02-18 23:42 | 2026-02-19 01:27 | awm | accepted | VIEW |