Review: debian-reference 2.133.2
Review Information
rejected — allocated to awm 1 month, 10 days ago, started 1 month, 10 days ago, completed 1 month, 10 days ago.
Final Comment
On unpacking I get this error from dpkg-source:
Signing key on 3133724D6207881579E95D621E1356881DD8D791 is not bound:
No binding signature at time 2026-01-22T04:51:34Z
because: Policy rejected non-revocation signature (PositiveCertification) requiring second pre-image resistance
because: SHA1 is not considered secure since 2023-02-01T00:00:00Z
dpkg-source: warning: cannot verify inline signature for /usr/src/dfsg/debian-reference_2.133.2.dsc: no acceptable signature found
Also, it seems that source/format has an unexpected second line in it which could be fixed.
I think that the debian reference - especially - should follow policy on this, so I am rejecting
it for now. Feel free to e-mail me or discuss in https://matrix.to/#/#debian-dfsg:matrix.debian.social
if you have reasons why I should accept as-is.
Thanks!
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 2.136 | f88e4726… | 2026-02-12 04:02 | 2026-02-12 04:21 | awm | accepted | VIEW |
Public Notes
vulture
Command: vulture .
Exit code: 3
/usr/src/dfsg/debian-reference_2.133.2/utils/moin2asc.py:149: SyntaxWarning: invalid escape sequence '\*'
if re.match("^ +\*", line):
/usr/src/dfsg/debian-reference_2.133.2/utils/moin2asc.py:176: SyntaxWarning: invalid escape sequence '\ '
+ /!\ for "WARNING"
/usr/src/dfsg/debian-reference_2.133.2/utils/cnvtblcols.py:40: SyntaxWarning: invalid escape sequence '\['
if flag_table == 0 and flag_example == 0 and re.match('\[grid', line):
/usr/src/dfsg/debian-reference_2.133.2/utils/cnvtblcols.py:84: SyntaxWarning: invalid escape sequence '\|'
xline = xline + "|" + re.sub('\|', '@@@bar@@@',line[i:j].strip())
/usr/src/dfsg/debian-reference_2.133.2/utils/cnvtblcols.py:86: SyntaxWarning: invalid escape sequence '\|'
xline = xline + "|" + re.sub('\|', '@@@bar@@@',line[i:].strip())
/usr/src/dfsg/debian-reference_2.133.2/utils/cnvtblcols.py:103: SyntaxWarning: invalid escape sequence '\|'
xline = xline + "|" + re.sub('\|', '@@@bar@@@',line[i:j])
/usr/src/dfsg/debian-reference_2.133.2/utils/cnvtblcols.py:105: SyntaxWarning: invalid escape sequence '\|'
xline = xline + "|" + re.sub('\|', '@@@bar@@@',line[i:])
bin/colspec.py:13: unused variable 'VERSION' (60% confidence)
bin/colspec.py:25: unused variable 'title' (60% confidence)
utils/asc2title.py:9: unused import 'os' (90% confidence)
utils/asc2title.py:11: unused variable 'VERSION' (60% confidence)
utils/cnvtblcols.py:28: unused import 'os' (90% confidence)
utils/cnvtblcols.py:30: unused variable 'VERSION' (60% confidence)
utils/moin2asc.py:9: unused import 'os' (90% confidence)
utils/moin2asc.py:11: unused variable 'VERSION' (60% confidence)
utils/moin2asc.py:65: unused variable 'm2a_table_mode' (60% confidence)
utils/moin2asc.py:66: unused variable 'm2a_table_popcon' (60% confidence)
utils/moin2asc.py:78: unused variable 'table_rows' (60% confidence)
utils/moin2asc.py:79: unused variable 'table_cols' (60% confidence)
utils/moin2asc.py:108: unused variable 'table_rows' (60% confidence)
utils/po4a-new.py:17: unused import 'os' (90% confidence)
utils/po4a-new.py:19: unused variable 'VERSION' (60% confidence)
utils/po4a-old.py:14: unused import 'os' (90% confidence)
utils/po4a-old.py:16: unused variable 'VERSION' (60% confidence)
utils/po4a-trim.py:13: unused import 'os' (90% confidence)
utils/po4a-trim.py:15: unused variable 'VERSION' (60% confidence)
CME fix
Command: cme fix --verbose dpkg
Exit code: 255
Reading package lists... 0%
Reading package lists... 100%
Reading package lists... Done
Building dependency tree... 0%
Building dependency tree... 0%
Building dependency tree... 50%
Building dependency tree... 50%
Building dependency tree... Done
Reading state information... 0%
Reading state information... 0%
Reading state information... Done
cme: running fix on dpkg configuration...
Connecting to api.ftp-master.debian.org to check 37 package versions. Please wait...
Got info from api.ftp-master.debian.org for 37 packages.
Warning in 'control source Standards-Version': Current standards version is '4.7.3'. Please read https://www.debian.org/doc/debian-policy/upgrading-checklist.html for the changes that may be needed on your package
to upgrade it from standard version '4.6.2' to '4.7.3'.
Offending value: '4.6.2'
Configuration item 'source format' has a wrong value:
enum type does not know '3.0 (native)
'. Expected '1.0' or '2.0' or '3.0 (native)' or '3.0 (quilt)' or '3.0 (custom)' or '3.0 (git)' or '3.0 (bzr)'