Review: dwarves 1.31-2
Review Information
accepted — allocated to awm 1 month, 11 days ago, started 1 month, 11 days ago, completed 1 month, 11 days ago.
Final Comment
There are some trivial looking shell scripts in the debian/tests directory stating that they are Apache 2 licensed incompatibly with everything else here which seems to be mostly GPL2, and also at odds with the statement in debian/copyright. It seems like a simple mistake but it should be corrected.
I also recommend running cme fix --verbose dpkg on the package which will fix some minor issues in the control file.
Public Notes
1 month, 11 days ago
● public
suspicious-source
Command: suspicious-source
Exit code: 0
./ctf_encoder.c
./lib/bpf/ci/diffs/4002-selftests-bpf-Fix-verifier_private_stack-test-failur.patch
./lib/bpf/ci/diffs/4001-selftests-bpf-Fix-verifier_bpf_fastcall-test.patch
./lib/bpf/ci/diffs/0001-selftests-bpf-set-test-path-for-token-obj_priv_impli.patch
./lib/bpf/ci/diffs/4000-selftests-bpf-Fix-tests-after-fields-reorder-in-stru.patch
./lib/bpf/fuzz/bpf-object-fuzzer_seed_corpus.zip
1 month, 11 days ago
● public
vulture
Command: vulture .
Exit code: 3
lib/bpf/docs/conf.py:12: unused variable 'project' (60% confidence)
lib/bpf/docs/conf.py:14: unused variable 'extensions' (60% confidence)
lib/bpf/docs/conf.py:28: unused variable 'exclude_patterns' (60% confidence)
lib/bpf/docs/conf.py:36: unused variable 'html_theme' (60% confidence)
lib/bpf/docs/conf.py:38: unused variable 'breathe_projects' (60% confidence)
lib/bpf/docs/conf.py:39: unused variable 'breathe_default_project' (60% confidence)
lib/bpf/docs/conf.py:40: unused variable 'breathe_show_define_initializer' (60% confidence)
lib/bpf/docs/conf.py:41: unused variable 'breathe_show_enumvalue_initializer' (60% confidence)
ostra/python/ostra.py:28: unused attribute 'grab_expr' (60% confidence)
ostra/python/ostra.py:29: unused attribute 'collector_fmt' (60% confidence)
ostra/python/ostra.py:73: unused attribute 'calls' (60% confidence)
ostra/python/ostra.py:74: unused attribute 'total_time' (60% confidence)
ostra/python/ostra.py:77: unused attribute 'exits' (60% confidence)
ostra/python/ostra.py:80: unused attribute 'calls' (60% confidence)
ostra/python/ostra.py:88: unused attribute 'total_time' (60% confidence)
ostra/python/ostra.py:150: unused attribute 'last_method' (60% confidence)
ostra/python/ostra.py:170: unused attribute 'last_method' (60% confidence)
ostra/python/ostra.py:194: unused method 'parse_file' (60% confidence)
ostra/python/ostra.py:241: unused method 'plot_methods' (60% confidence)
ostra/python/ostra.py:263: unused variable 'pos' (100% confidence)
ostra/python/ostra.py:274: unused variable 'pos' (100% confidence)
1 month, 11 days ago
● public
Licenserecon
Command: lrc -l
Exit code: 3
en: Versions: licenserecon '11.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
GPL-2-only | GPL-2 btfdiff
GPL-2-only | GPL-2 btf_encoder.c
GPL-2-only | GPL-2 btf_encoder.h
GPL-2-only | GPL-2 codiff.c
GPL-2-only | GPL-2 config.h.cmake
GPL-2-only | GPL-2 ctf_encoder.c
GPL-2-only | GPL-2 ctf_encoder.h
GPL-2-only | GPL-2 ctf.h
GPL-2-only | GPL-2 ctracer.c
GPL-2-only | Apache-2.0 debian/tests/btf-struct-with-hole
GPL-2-only | Apache-2.0 debian/tests/dwarf-struct-with-hole
GPL-2-only | Apache-2.0 debian/tests/smoketest
GPL-2-only | GPL-2 dtagnames.c
GPL-2-only | GPL-2 dutil.c
GPL-2-only | GPL-2 dutil.h
GPL-2-only | GPL-2 dwarf_loader.c
GPL-2-only | GPL-2 dwarves.c
GPL-2-only | GPL-2 dwarves_emit.c
GPL-2-only | GPL-2 dwarves_emit.h
GPL-2-only | GPL-2 dwarves_fprintf.c
GPL-2-only | GPL-2 dwarves.h
GPL-2-only | GPL-2 dwarves_reorganize.c
GPL-2-only | GPL-2 dwarves_reorganize.h
GPL-2-only | GPL-2 elfcreator.c
GPL-2-only | GPL-2 elfcreator.h
GPL-2-only | GPL-2 elf_symtab.c
GPL-2-only | GPL-2 elf_symtab.h
GPL-2-only | GPL-2 fullcircle
GPL-2-only | GPL-2 gobuffer.c
GPL-2-only | GPL-2 gobuffer.h
GPL-2-only | GPL-2 lib/bpf/docs/conf.py
GPL-2-only | LGPL-2.1 lib/bpf/docs/libbpf_naming_convention.rst
GPL-2-only | GPL-2 lib/bpf/docs/libbpf_overview.rst
GPL-2-only | GPL-2 lib/bpf/include/uapi/linux/bpf_common.h
GPL-2-only | GPL-2 lib/bpf/include/uapi/linux/bpf.h
GPL-2-only | GPL-2 lib/bpf/include/uapi/linux/btf.h
GPL-2-only | GPL-2 lib/bpf/include/uapi/linux/if_link.h
GPL-2-only | GPL-2 lib/bpf/include/uapi/linux/if_xdp.h
GPL-2-only | GPL-2 lib/bpf/include/uapi/linux/netlink.h
GPL-2-only | GPL-2 lib/bpf/include/uapi/linux/perf_event.h
GPL-2-only | GPL-2 lib/bpf/include/uapi/linux/pkt_cls.h
GPL-2-only | GPL-2 lib/bpf/include/uapi/linux/pkt_sched.h
GPL-2-only | BSD-2-clause lib/bpf/LICENSE.BSD-2-Clause
GPL-2-only | LGPL-2.1 lib/bpf/LICENSE.LGPL-2.1
GPL-2-only | LGPL-2.1 lib/bpf/src/bpf.c
GPL-2-only | LGPL-2.1 lib/bpf/src/bpf.h
GPL-2-only | GPL-2 libctf.c
GPL-2-only | GPL-2 libctf.h
GPL-2-only | GPL-2 lib/ctracer_relay.c
GPL-2-only | GPL-2 lib/ctracer_relay.h
GPL-2-only | GPL-2 list.h
GPL-2-only | GPL-2 man-pages/pahole.1
GPL-2-only | GPL-2 ostra/ostra-cg
GPL-2-only | GPL-2 ostra/python/ostra.py
GPL-2-only | GPL-2 pahole.c
GPL-2-only | GPL-2 pdwtags.c
GPL-2-only | GPL-2 pfunct.c
GPL-2-only | GPL-2 pglobal.c
GPL-2-only | GPL-2 prefcnt.c
GPL-2.0-or-later | GPL-2 rbtree.c
GPL-2.0-or-later | GPL-2 rbtree.h
GPL-2-only | GPL-2 regtest
GPL-2-only | GPL-2 rpm/SPECS/dwarves.spec
GPL-2-only | GPL-2 scncopy.c
GPL-2-only | GPL-2 syscse.c