DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: easel 0.49+dfsg-1

Package Information

Descriptionlibrary of C functions for biological sequence analysis (runtime library)

Easel is an ANSI C code library for computational analysis of biological sequences using probabilistic models. Easel is used by HMMER, the profile hidden Markov model software that underlies the Pfam protein families database, and by Infernal, the profile stochastic context-free grammar software that underlies the Rfam RNA family database. Easel aims to make similar applications more robust and easier to develop, by providing a set of reusable, documented, and well-tested functions.

This package contains the shared Easel library.

MaintainerDebian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>
Changed ByAndreas Tille <tille@debian.org>
Sponsortille@debian.org
Distributionunstable
Architectureany all
VCSgit: https://salsa.debian.org/med-team/easel.git (browse)
Closes#860746
Trackerhttps://tracker.debian.org/pkg/easel
Uploaded3 days ago

New Package Report

.changes◂
DateThu, 12 Nov 2026 08:58:12 +0100
Sourceeasel
Version0.49+dfsg-1
Changed-ByAndreas Tille <tille@debian.org>
Architecturesource amd64 all
Distributionunstable
Changelog◂
easel (0.49+dfsg-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #860746)
.dsc◂
Componentmain
Package-Listeasel-apps deb science optional arch=any
easel-doc deb doc optional arch=all
libeasel-dev deb libdevel optional arch=any
libeasel0 deb libs optional arch=any
Sectionscience
Priorityoptional
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: easel
Source: https://github.com/EddyRivasLab/easel
Files-Excluded: demotic/*

Files: *
Copyright: © 2004-2016 Sean R. Eddy
           © 2004-2016 Howard Hughes Medical Institute
           © 2015-2016 President and Fellows of Harvard College
           © 2004-2006 Washington University School of Medicine
License: BSD-3-clause

Files: debian/*
Copyright: © 2017 Michael R. Crusoe <michael.crusoe@gmail.com>
License: BSD-3-clause

License: BSD-3-clause
   Redistribution and use in source and binary forms, with or without
   modification, are permitted provided that the following conditions
   are met:
   .
   1. Redistributions of source code must retain the above copyright
      notice, this list of conditions and the following disclaimer.
   .
   2. Redistributions in binary form must reproduce the above
      copyright notice, this list of conditions and the following
      disclaimer in the documentation and/or other materials provided
      with the distribution.
   .
   3. Neither the name of the copyright holder nor the names of its
      contributors may be used to endorse or promote products derived
      from this software without specific prior written permission.
   .
   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
   COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
   INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
   OF THE POSSIBILITY OF SUCH DAMAGE.

Files: esl_stopwatch.c
Copyright: 2012, David Robert Nadeau, http:NadeauSoftware.com
License: CC-BY-3.0
 Creative Commons Attribution 3.0 Unported
 .
 CREATIVE COMMONS CORPORATION IS NOT A LAW FIRM AND DOES NOT PROVIDE
 LEGAL SERVICES. DISTRIBUTION OF THIS LICENSE DOES NOT CREATE AN
 ATTORNEY-CLIENT RELATIONSHIP. CREATIVE COMMONS PROVIDES THIS INFORMATION
 ON AN "AS-IS" BASIS. CREATIVE COMMONS MAKES NO WARRANTIES REGARDING THE
 INFORMATION PROVIDED, AND DISCLAIMS LIABILITY FOR DAMAGES RESULTING FROM
 ITS USE.
 .
 License
 .
 THE WORK (AS DEFINED BELOW) IS PROVIDED UNDER THE TERMS OF THIS CREATIVE
 COMMONS PUBLIC LICENSE ("CCPL" OR "LICENSE"). THE WORK IS PROTECTED BY
 COPYRIGHT AND/OR OTHER APPLICABLE LAW. ANY USE OF THE WORK OTHER THAN AS
 AUTHORIZED UNDER THIS LICENSE OR COPYRIGHT LAW IS PROHIBITED.
 .
 BY EXERCISING ANY RIGHTS TO THE WORK PROVIDED HERE, YOU ACCEPT AND AGREE
 TO BE BOUND BY THE TERMS OF THIS LICENSE. TO THE EXTENT THIS LICENSE MAY
 BE CONSIDERED TO BE A CONTRACT, THE LICENSOR GRANTS YOU THE RIGHTS
 CONTAINED HERE IN CONSIDERATION OF YOUR ACCEPTANCE OF SUCH TERMS AND
 CONDITIONS.
 .
 1. Definitions
 .
 a. "Adaptation" means a work based upon the Work, or upon the Work and
 other pre-existing works, such as a translation, adaptation, derivative
 work, arrangement of music or other alterations of a literary or
 artistic work, or phonogram or performance and includes cinematographic
 adaptations or any other form in which the Work may be recast,
 transformed, or adapted including in any form recognizably derived from
 the original, except that a work that constitutes a Collection will not
 be considered an Adaptation for the purpose of this License. For the
 avoidance of doubt, where the Work is a musical work, performance or
 phonogram, the synchronization of the Work in timed-relation with a
 moving image ("synching") will be considered an Adaptation for the
 purpose of this License.
 .
 b. "Collection" means a collection of literary or artistic works, such
 as encyclopedias and anthologies, or performances, phonograms or
 broadcasts, or other works or subject matter other than works listed in
 Section 1(f) below, which, by reason of the selection and arrangement of
 their contents, constitute intellectual creations, in which the Work is
 included in its entirety in unmodified form along with one or more other
 contributions, each constituting separate and independent works in
 themselves, which together are assembled into a collective whole. A work
 that constitutes a Collection will not be considered an Adaptation (as
 defined above) for the purposes of this License.
 .
 c.  "Distribute" means to make available to the public the original and
 copies of the Work or Adaptation, as appropriate, through sale or other
 transfer of ownership.
 .
 d. "Licensor" means the individual, individuals, entity or entities that
 offer(s) the Work under the terms of this License.
 .
 e. "Original Author" means, in the case of a literary or artistic work,
 the individual, individuals, entity or entities who created the Work or
 if no individual or entity can be identified, the publisher; and in
 addition (i) in the case of a performance the actors, singers,
 musicians, dancers, and other persons who act, sing, deliver, declaim,
 play in, interpret or otherwise perform literary or artistic works or
 expressions of folklore; (ii) in the case of a phonogram the producer
 being the person or legal entity who first fixes the sounds of a
 performance or other sounds; and, (iii) in the case of broadcasts, the
 organization that transmits the broadcast.
 .
 f. "Work" means the literary and/or artistic work offered under the
 terms of this License including without limitation any production in the
 literary, scientific and artistic domain, whatever may be the mode or
 form of its expression including digital form, such as a book, pamphlet
 and other writing; a lecture, address, sermon or other work of the same
 nature; a dramatic or dramatico-musical work; a choreographic work or
 entertainment in dumb show; a musical composition with or without words;
 a cinematographic work to which are assimilated works expressed by a
 process analogous to cinematography; a work of drawing, painting,
 architecture, sculpture, engraving or lithography; a photographic work
 to which are assimilated works expressed by a process analogous to
 photography; a work of applied art; an illustration, map, plan, sketch
 or three-dimensional work relative to geography, topography,
 architecture or science; a performance; a broadcast; a phonogram; a
 compilation of data to the extent it is protected as a copyrightable
 work; or a work performed by a variety or circus performer to the extent
 it is not otherwise considered a literary or artistic work.
 .
 g. "You" means an individual or entity exercising rights under this
 License who has not previously violated the terms of this License with
 respect to the Work, or who has received express permission from the
 Licensor to exercise rights under this License despite a previous
 violation.
 .
 h. "Publicly Perform" means to perform public recitations of the Work
 and to communicate to the public those public recitations, by any means
 or process, including by wire or wireless means or public digital
 performances; to make available to the public Works in such a way that
 members of the public may access these Works from a place and at a place
 individually chosen by them; to perform the Work to the public by any
 means or process and the communication to the public of the performances
 of the Work, including by public digital performance; to broadcast and
 rebroadcast the Work by any means including signs, sounds or images.
 .
 i. "Reproduce" means to make copies of the Work by any means including
 without limitation by sound or visual recordings and the right of
 fixation and reproducing fixations of the Work, including storage of a
 protected performance or phonogram in digital form or other electronic
 medium.
 .
 2. Fair Dealing Rights. Nothing in this License is intended to reduce,
 limit, or restrict any uses free from copyright or rights arising from
 limitations or exceptions that are provided for in connection with the
 copyright protection under copyright law or other applicable laws.
 .
 3. License Grant. Subject to the terms and conditions of this License,
 Licensor hereby grants You a worldwide, royalty-free, non-exclusive,
 perpetual (for the duration of the applicable copyright) license to
 exercise the rights in the Work as stated below:
 .
 a. to Reproduce the Work, to incorporate the Work into one or more
 Collections, and to Reproduce the Work as incorporated in the
 Collections;
 .
 b. to create and Reproduce Adaptations provided that any such
 Adaptation, including any translation in any medium, takes reasonable
 steps to clearly label, demarcate or otherwise identify that changes
 were made to the original Work. For example, a translation could be
 marked "The original work was translated from English to Spanish," or a
 modification could indicate "The original work has been modified.";
 .
 c. to Distribute and Publicly Perform the Work including as incorporated
 in Collections; and,
 .
 d. to Distribute and Publicly Perform Adaptations.
 .
 e. For the avoidance of doubt:
 .
 i. Non-waivable Compulsory License Schemes. In those jurisdictions in
 which the right to collect royalties through any statutory or compulsory
 licensing scheme cannot be waived, the Licensor reserves the exclusive
 right to collect such royalties for any exercise by You of the rights
 granted under this License;
 .
 ii. Waivable Compulsory License Schemes. In those jurisdictions in which
 the right to collect royalties through any statutory or compulsory
 licensing scheme can be waived, the Licensor waives the exclusive right
 to collect such royalties for any exercise by You of the rights granted
 under this License; and,
 .
 iii. Voluntary License Schemes. The Licensor waives the right to collect
 royalties, whether individually or, in the event that the Licensor is a
 member of a collecting society that administers voluntary licensing
 schemes, via that society, from any exercise by You of the rights
 granted under this License.
 .
 The above rights may be exercised in all media and formats whether now
 known or hereafter devised. The above rights include the right to make
 such modifications as are technically necessary to exercise the rights
 in other media and formats. Subject to Section 8(f), all rights not
 expressly granted by Licensor are hereby reserved.
 .
 4. Restrictions. The license granted in Section 3 above is expressly
 made subject to and limited by the following restrictions:
 .
 a. You may Distribute or Publicly Perform the Work only under the terms
 of this License. You must include a copy of, or the Uniform Resource
 Identifier (URI) for, this License with every copy of the Work You
 Distribute or Publicly Perform. You may not offer or impose any terms on
 the Work that restrict the terms of this License or the ability of the
 recipient of the Work to exercise the rights granted to that recipient
 under the terms of the License. You may not sublicense the Work. You
 must keep intact all notices that refer to this License and to the
 disclaimer of warranties with every copy of the Work You Distribute or
 Publicly Perform. When You Distribute or Publicly Perform the Work, You
 may not impose any effective technological measures on the Work that
 restrict the ability of a recipient of the Work from You to exercise the
 rights granted to that recipient under the terms of the License. This
 Section 4(a) applies to the Work as incorporated in a Collection, but
 this does not require the Collection apart from the Work itself to be
 made subject to the terms of this License. If You create a Collection,
 upon notice from any Licensor You must, to the extent practicable,
 remove from the Collection any credit as required by Section 4(b), as
 requested. If You create an Adaptation, upon notice from any Licensor
 You must, to the extent practicable, remove from the Adaptation any
 credit as required by Section 4(b), as requested.
 .
 b. If You Distribute, or Publicly Perform the Work or any Adaptations or
 Collections, You must, unless a request has been made pursuant to
 Section 4(a), keep intact all copyright notices for the Work and
 provide, reasonable to the medium or means You are utilizing: (i) the
 name of the Original Author (or pseudonym, if applicable) if supplied,
 and/or if the Original Author and/or Licensor designate another party or
 parties (e.g., a sponsor institute, publishing entity, journal) for
 attribution ("Attribution Parties") in Licensor's copyright notice,
 terms of service or by other reasonable means, the name of such party or
 parties; (ii) the title of the Work if supplied; (iii) to the extent
 reasonably practicable, the URI, if any, that Licensor specifies to be
 associated with the Work, unless such URI does not refer to the
 copyright notice or licensing information for the Work; and (iv) ,
 consistent with Section 3(b), in the case of an Adaptation, a credit
 identifying the use of the Work in the Adaptation (e.g., "French
 translation of the Work by Original Author," or "Screenplay based on
 original Work by Original Author"). The credit required by this Section
 4 (b) may be implemented in any reasonable manner; provided, however,
 that in the case of a Adaptation or Collection, at a minimum such credit
 will appear, if a credit for all contributing authors of the Adaptation
 or Collection appears, then as part of these credits and in a manner at
 least as prominent as the credits for the other contributing authors.
 For the avoidance of doubt, You may only use the credit required by this
 Section for the purpose of attribution in the manner set out above and,
 by exercising Your rights under this License, You may not implicitly or
 explicitly assert or imply any connection with, sponsorship or
 endorsement by the Original Author, Licensor and/or Attribution Parties,
 as appropriate, of You or Your use of the Work, without the separate,
 express prior written permission of the Original Author, Licensor and/or
 Attribution Parties.
 .
 c. Except as otherwise agreed in writing by the Licensor or as may be
 otherwise permitted by applicable law, if You Reproduce, Distribute or
 Publicly Perform the Work either by itself or as part of any Adaptations
 or Collections, You must not distort, mutilate, modify or take other
 derogatory action in relation to the Work which would be prejudicial to
 the Original Author's honor or reputation. Licensor agrees that in those
 jurisdictions (e.g. Japan), in which any exercise of the right granted
 in Section 3(b) of this License (the right to make Adaptations) would be
 deemed to be a distortion, mutilation, modification or other derogatory
 action prejudicial to the Original Author's honor and reputation, the
 Licensor will waive or not assert, as appropriate, this Section, to the
 fullest extent permitted by the applicable national law, to enable You
 to reasonably exercise Your right under Section 3(b) of this License
 (right to make Adaptations) but not otherwise.
 .
 5. Representations, Warranties and Disclaimer
 .
 UNLESS OTHERWISE MUTUALLY AGREED TO BY THE PARTIES IN WRITING, LICENSOR
 OFFERS THE WORK AS-IS AND MAKES NO REPRESENTATIONS OR WARRANTIES OF ANY
 KIND CONCERNING THE WORK, EXPRESS, IMPLIED, STATUTORY OR OTHERWISE,
 INCLUDING, WITHOUT LIMITATION, WARRANTIES OF TITLE, MERCHANTIBILITY,
 FITNESS FOR A PARTICULAR PURPOSE, NONINFRINGEMENT, OR THE ABSENCE OF
 LATENT OR OTHER DEFECTS, ACCURACY, OR THE PRESENCE OF ABSENCE OF ERRORS,
 WHETHER OR NOT DISCOVERABLE. SOME JURISDICTIONS DO NOT ALLOW THE
 EXCLUSION OF IMPLIED WARRANTIES, SO SUCH EXCLUSION MAY NOT APPLY TO YOU.
 .
 6. Limitation on Liability. EXCEPT TO THE EXTENT REQUIRED BY APPLICABLE
 LAW, IN NO EVENT WILL LICENSOR BE LIABLE TO YOU ON ANY LEGAL THEORY FOR
 ANY SPECIAL, INCIDENTAL, CONSEQUENTIAL, PUNITIVE OR EXEMPLARY DAMAGES
 ARISING OUT OF THIS LICENSE OR THE USE OF THE WORK, EVEN IF LICENSOR HAS
 BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES.
 .
 7. Termination
 .
 a. This License and the rights granted hereunder will terminate
 automatically upon any breach by You of the terms of this License.
 Individuals or entities who have received Adaptations or Collections
 from You under this License, however, will not have their licenses
 terminated provided such individuals or entities remain in full
 compliance with those licenses. Sections 1, 2, 5, 6, 7, and 8 will
 survive any termination of this License.
 .
 b. Subject to the above terms and conditions, the license granted here
 is perpetual (for the duration of the applicable copyright in the Work).
 Notwithstanding the above, Licensor reserves the right to release the
 Work under different license terms or to stop distributing the Work at
 any time; provided, however that any such election will not serve to
 withdraw this License (or any other license that has been, or is
 required to be, granted under the terms of this License), and this
 License will continue in full force and effect unless terminated as
 stated above.
 .
 8. Miscellaneous
 .
 a. Each time You Distribute or Publicly Perform the Work or a
 Collection, the Licensor offers to the recipient a license to the Work
 on the same terms and conditions as the license granted to You under
 this License.
 .
 b. Each time You Distribute or Publicly Perform an Adaptation, Licensor
 offers to the recipient a license to the original Work on the same terms
 and conditions as the license granted to You under this License.
 .
 c. If any provision of this License is invalid or unenforceable under
 applicable law, it shall not affect the validity or enforceability of
 the remainder of the terms of this License, and without further action
 by the parties to this agreement, such provision shall be reformed to
 the minimum extent necessary to make such provision valid and
 enforceable.
 .
 d. No term or provision of this License shall be deemed waived and no
 breach consented to unless such waiver or consent shall be in writing
 and signed by the party to be charged with such waiver or consent. This
 License constitutes the entire agreement between the parties with
 respect to the Work licensed here. There are no understandings,
 agreements or representations with respect to the Work not specified
 here. Licensor shall not be bound by any additional provisions that may
 appear in any communication from You.
 .
 e. This License may not be modified without the mutual written agreement
 of the Licensor and You.
 .
 f. The rights granted under, and the subject matter referenced, in this
 License were drafted utilizing the terminology of the Berne Convention
 for the Protection of Literary and Artistic Works (as amended on
 September 28, 1979), the Rome Convention of 1961, the WIPO Copyright
 Treaty of 1996, the WIPO Performances and Phonograms Treaty of 1996 and
 the Universal Copyright Convention (as revised on July 24, 1971). These
 rights and subject matter take effect in the relevant jurisdiction in
 which the License terms are sought to be enforced according to the
 corresponding provisions of the implementation of those treaty
 provisions in the applicable national law. If the standard suite of
 rights granted under applicable copyright law includes additional rights
 not granted under this License, such additional rights are deemed to be
 included in the License; this License is not intended to restrict the
 license of any rights under applicable law.
 .
 Creative Commons Notice
 .
 Creative Commons is not a party to this License, and makes no warranty
 whatsoever in connection with the Work. Creative Commons will not be
 liable to You or any party on any legal theory for any damages
 whatsoever, including without limitation any general, special,
 incidental or consequential damages arising in connection to this
 license. Notwithstanding the foregoing two (2) sentences, if Creative
 Commons has expressly identified itself as the Licensor hereunder, it
 shall have all rights and obligations of Licensor.
 .
 Except for the limited purpose of indicating to the public that the Work
 is licensed under the CCPL, Creative Commons does not authorize the use
 by either party of the trademark "Creative Commons" or any related
 trademark or logo of Creative Commons without the prior written consent
 of Creative Commons. Any permitted use will be in compliance with
 Creative Commons' then-current trademark usage guidelines, as may be
 published on its website or otherwise made available upon request from
 time to time. For the avoidance of doubt, this trademark restriction
 does not form part of this License.
 .
 Creative Commons may be contacted at http://creativecommons.org/.

DFSG Assistant LLM REVIEW 2 blocker, 0 important, 4 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 3 days ago.

Report◂

DFSG NEW review for easel version 0.49+dfsg-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: No
  • Issues: 2 blocker, 0 important, 4 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: 13 found

Licensing

Most of the tree is BSD-licensed and DFSG-free, but formats/uniprot is a UniProt record that states it is distributed under the Creative Commons Attribution-NoDerivs licence, which is non-free. debian/copyright is also far from complete: its Files: * stanza declares BSD-3-clause and four holders for the whole tree, while about twenty files carry other licences and holders (GPL-3+ macros in m4/, config.guess/config.sub, X11 install-sh, Henry Spencer's regexp, Sun's erfc, MT19937-64 and ISC code in esl_rand64.c, zlib-licensed SIMD kernels, Wheeler's MIT code and the FreeBSD strsep in easel.c, and the MRC Laboratory of Molecular Biology in LICENSE), whose notices are not reproduced.

Packaging

The structure is sound and current: compat 14, --buildsystem defaults with d-shlibs for the shared library, Multi-Arch: same on libeasel0, hardening +all, a working -doc package with doc-base, and Standards-Version: 4.7.4 against Policy 4.7.4.1. But Build-Depends lists help2man and libgsl-dev, neither of which the build uses; override_dh_auto_test runs make tests, which only compiles the unit-test binaries, so no test is ever executed at build time and the autopkgtest only builds the example; and /usr/bin/easel is installed without a manual page. All findings are minor, but each should be fixed before upload.

Issues

blocker licensing 1. debian/copyright claims BSD-3-clause for the whole tree, but m4/, config.guess, config.sub, install-sh, esl_regexp.c, esl_stats.*, esl_rand64.c, esl_sse/neon/vmx.c and easel.c carry other licences and holders ◂
  • Files: debian/copyright:6-11 (Files: *), m4/ax_pthread.m4:60-75, m4/ax_check_compile_flag.m4:29-46, m4/ax_compiler_vendor.m4, m4/ax_prog_cc_mpi.m4, m4/ax_check_gnu_make.m4:53-60, m4/ax_gcc_func_attribute.m4:67-74, config.guess:1-25, config.sub:1-25, install-sh:8-33, esl_regexp.c:444-462, esl_stats.c:395-401, esl_stats.h:33-39, esl_rand64.c:18-26, esl_sse.c:678-707, esl_neon.c:716-745, esl_vmx.c:519-548, easel.c:1485-1500, easel.c:2090-2097, LICENSE:1-10
  • Basis: checked, in the package or with a reference tool
  • Evidence: m4/ax_pthread.m4:65: "This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License ... either version 3 of the License, or (at your option) any later version."; config.guess:3: "Copyright 1992-2018 Free Software Foundation, Inc." (GPL-3+ with the Autoconf exception at :20); install-sh:10: "Copyright (C) 1994 X Consortium" (MIT/X11 text); esl_regexp.c:446: "Copyright (c) 1986, 1993, 1995 by University of Toronto."; esl_stats.c:396: "Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved." / "Permission to use, copy, modify, and distribute this software is freely granted"; esl_rand64.c:20: "Copyright (C) 2004, Makoto Matsumoto and Takuji Nishimura. All rights reserved." and :25: "Copyright (2016) Kevin Lawler. Released under ISC License."; esl_sse.c:680: "Copyright (C) 1992 Stephen Moshier" and "The zlib license"; easel.c:1487: "The Regents of the University of California"; easel.c:2093: "Licensed under the MIT license"; LICENSE:6: "Copyright (C) 1992-1995 MRC Laboratory of Molecular Biology, UK"; debian/copyright:6-11 says Files: * / License: BSD-3-clause with only Eddy, HHMI, Harvard and Washington University.
  • Problem: The licence short name is wrong for about twenty files and the holders named in the files' own notices are absent (FSF; Steven G. Johnson, Daniel Richard G., Marc Stevens, Guido U. Draheim, Maarten Bosmans, John Darrington, Enrico M. Crisostomo, Gabriele Svelto; X Consortium; Henry Spencer/University of Toronto; Sun Microsystems; Matsumoto/Nishimura and Kevin Lawler; Julien Pommier and Stephen Moshier; the Regents of the University of California; David A. Wheeler; MRC Laboratory of Molecular Biology). The notices that zlib, ISC, MIT, X11, Sun and Spencer's licences require to be reproduced are not in debian/copyright, and the Autoconf exception of the GPL-3+ files is not quoted either. debian/copyright therefore does not describe the copyright and licensing of every file (Policy 12.5). The GPL-3+ files are build-time-only (autoconf macros, config.guess/sub), so they create no licence conflict with the BSD library.
  • Fix: Add Files: stanzas for each group with the correct holders and short names (GPL-3+ with Autoconf exception for the four ax_*.m4 and for config.guess/config.sub, with the exception text quoted and GPL-3 referred to /usr/share/common-licenses/GPL-3; the unlimited Copying and distribution ... without royalty text for ax_check_gnu_make.m4 and ax_gcc_func_attribute.m4; X11 for install-sh; the Spencer/University of Toronto notice for esl_regexp.[ch]; Sun's notice for esl_stats.[ch]; BSD-3-clause for MT19937-64 plus ISC for esl_rand64.c; zlib for the SIMD files; MIT for the esl_tmpfile() part of easel.c and BSD-3-clause for its strsep() part), and add MRC Laboratory of Molecular Biology to the holder list.
blocker licensing 2. formats/uniprot carries an explicit Creative Commons Attribution-NoDerivs notice, a non-free licence ◂
  • Files: formats/uniprot:108-109
  • Basis: checked, in the package or with a reference tool
  • Evidence: CC Copyrighted by the UniProt Consortium, see http://www.uniprot.org/terms and CC Distributed under the Creative Commons Attribution-NoDerivs License.
  • Problem: A NoDerivs licence forbids distributing modified versions, so the file does not meet DFSG 3 and cannot be in main. It is in the +dfsg tarball (Files-Excluded names only demotic/*) and no debian/copyright stanza covers it (the Files: * stanza claims it as BSD-3-clause). The record is not referenced by any test or by the source; it is unused test data.
  • Fix: Repack without it (add formats/uniprot to Files-Excluded/the repack filter) and delete it, or replace it with a record of the same format under a free licence; formats/embl is a similar record with no such notice.
minor licensing 3. Files: * declares BSD-3-clause but upstream's LICENSE grants the 2-clause BSD licence ◂
  • Files: debian/copyright:6-11, debian/copyright:17-45, LICENSE
  • Basis: checked, in the package or with a reference tool
  • Evidence: The licence in LICENSE lists only conditions "1. Redistributions of source code must retain the above copyright notice..." and "2. Redistributions in binary form must reproduce the above copyright notice..." followed by the disclaimer; the stand-alone License: BSD-3-clause text in debian/copyright adds "3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products...".
  • Problem: The licence Debian records for the bulk of the tree is not the one the holder granted: the extra endorsement clause is an additional restriction that LICENSE does not impose. (Three-clause text does appear in easel.c's FreeBSD strsep() and in documentation/copyright.tex, so the two cases need separating rather than one blanket claim.)
  • Fix: Use BSD-2-clause for Files: * with the 2-clause text from LICENSE, and keep the 3-clause text in a separate stanza covering the files that really carry it (e.g. easel.c).
minor packaging 4. Build-Depends lists help2man and libgsl-dev, neither of which the build uses ◂
  • Files: debian/control:11-12, debian/rules:28, configure.ac:183
  • Basis: checked, in the package or with a reference tool
  • Evidence: help2man, and libgsl-dev, in Build-Depends; help2man appears nowhere else in the tree (the man pages are generated from miniapps/*.man.in by sed and configure); debian/rules:28 ends CC=mpicc # --with-gsl, so GSL is not enabled, and configure.ac:183 defaults with_gsl=no.
  • Problem: Two build dependencies are installed in every build without being used; interface_gsl.c is compiled only under HAVE_LIBGSL, which the commented-out --with-gsl never defines.
  • Fix: Drop help2man and libgsl-dev from Build-Depends, or enable --with-gsl and keep the latter.
minor packaging 5. override_dh_auto_test runs make tests, which only compiles the unit-test binaries; the test suite is never run ◂
  • Files: debian/rules:46-47, Makefile.in:538-545, debian/tests/run-unit-test
  • Basis: checked, in the package or with a reference tool
  • Evidence: override_dh_auto_test: / $(MAKE) tests; Makefile.in:538 tests: ${ALL_UTESTS} builds and Makefile.in:541 check: builds and then runs miniapps/check and testsuite/check; the autopkgtest only copies debian/example and builds/runs readseq.
  • Problem: About ninety unit-test binaries are built during the build and discarded without being executed, and autopkgtest does not run them either, so the upstream test suite runs nowhere.
  • Fix: Use $(MAKE) check in override_dh_auto_test (adding python3 to Build-Depends with <!nocheck>), or add a debian/tests/ entry that runs the upstream unit tests, and fix or drop make tests accordingly.
minor packaging 6. /usr/bin/easel, the multi-call program with subcommands, is installed without a manual page ◂
  • Files: miniapps/Makefile.in:46-112, miniapps/easel.c, debian/easel-apps.install
  • Basis: checked, in the package or with a reference tool
  • Evidence: all: ${PROGS} easel builds easel, and install: installs $$file.man for ${PROGS} only; easel is not in PROGS and there is no miniapps/easel.man.in (only esl-*.man.in and the unused easel-downsample.man.in).
  • Problem: Policy 12.1: "Each program, utility, and function should have an associated manual page" and "If no manual page is available, this is considered as a bug". debian/easel-apps.install ships all of usr/bin/*, so easel (with its alistat/downsample/filter/index subcommands) is the one binary without a page.
  • Fix: Add miniapps/easel.man.in documenting easel and its subcommands, generate it with the other pages, and install it.
Verified ◂
  • Inventory and coverage: 447 files; all of debian/ read in full; every file that carries a copyright or licence notice read (LICENSE, all m4/.m4, config.guess, config.sub, install-sh, the SIMD modules, esl_rand64.c, esl_stats., esl_regexp.*, esl_random.c, easel.c, esl_stopwatch.c); a tree-wide grep for Copyright/(C)/SPDX-License-Identifier/Licensed under/Permission is hereby granted/All rights reserved, excluding .pc/ (there is no debian/cargo-checksum.json).
  • The thirteen scanned documents are documentation inputs, not build products of this package: documentation/figures/easel_techtree.ai, documentation/figures/easel_techtree.pdf, documentation/figures/rna_elements.ai, documentation/figures/rna_elements.pdf, documentation/figures/rnaseP-bsu-alignment.ai, documentation/figures/rnaseP-bsu-alignment.pdf, documentation/figures/rnaseP-ecoli.ai, documentation/figures/rnaseP-ecoli.pdf are Adobe Illustrator documents (PDF-compatible) shipped with their editable sources and with .eps/.png renditions, and documentation/figures/evd_basic.pdf, evd_location.pdf, evd_scale.pdf, gev_density.pdf, gev_logdensity.pdf are plots included with \includegraphics by esl_gumbel.tex:96-107 and esl_gev.tex:104-107, whose LaTeX sources are present but whose plotting scripts are not shipped; the Userguide PDF itself is built at build time from documentation/main.tex using devkit/autodoc and devkit/cexcerpt, both present in the tree.
  • The Adobe Systems copyright lines in documentation/figures/rna_elements.eps, rnaseP-bsu-alignment.eps and rnaseP-ecoli.eps are Illustrator DSC %%Copyright: headers and an embedded Adobe font /Notice, not a licence claim over the figures' content.
  • Of the holders the scan flagged, the third-party code authors are covered by the first issue; the "HHMI Janelia Farm Research Campus # Freely ..." strings at easel.c:546,566 and esl_getopts.c:167 are the generated EASEL_COPYRIGHT/EASEL_LICENSE configure text (a sample header written by the program), not a licence of those files; David Robert Nadeau is named in the esl_stopwatch.c stanza (the URL is misspelt http:NadeauSoftware.com); the MRC Laboratory of Molecular Biology is in LICENSE:6 only.
  • esl_stopwatch.c is CC-BY-3.0 with its full text in debian/copyright; CC-BY-3.0 is DFSG-free and its notice in the file matches the stanza.
  • The SIMD files' borrowed routines are the zlib-licensed ssemath derivatives of Julien Pommier (esl_sse.c:678-707, esl_neon.c:716-745, esl_vmx.c:519-548); the Cephes/Moshier attribution in the same comment is a credit line for those derivatives ("may be used freely"), not a separate restriction.
  • Files-Excluded: demotic/* matches the tree: demotic/ is absent.
  • Test data formats/ (fasta, genbank, embl, BLOSUM62, wag.dat, ...) and esl_msa_testfiles/ carry no licence notices; BLOSUM62 and WAG are numeric matrices from the cited papers.
  • No font files (.ttf/.otf/.pfb/.afm) are in the tree.
  • Packaging basics checked: 3.0 (quilt), compat 14, hardening +all, dpkg buildflags, Multi-Arch: same on libeasel0, headers and easel.pc in the multiarch devel path, doc-base plus a generated PDF in easel-doc, no maintainer scripts needed, Vcs-* and Homepage present, changelog unstable with an ITP closure and a coherent version, no remaining lintian-class problems in the files read.
  • Standards-Version: 4.7.4 is current against Policy 4.7.4.1 (first two components 4.7).
  • There is no generated configure in the tarball, but autoconf arrives through debhelper's dependency on dh-autoreconf, and configure.ac pulls the m4 macros in with m4_include, so this is not a missing Build-Depends.
  • uscan found the packaged version as the newest upstream release (upstream 0.49, packaged 0.49+dfsg).
Not confirmed ◂
  • d-shlibs is not installed on the reviewing system, so d-shlibmove's ${devlibs:Depends} output and its s/(libmpi40|libopen_mpi40|libmpich12)-dev/mpi-default-dev/ override could not be checked; whether libeasel-dev ends up depending on mpi-default-dev (needed, because the installed esl_mpi.h includes <mpi.h> when HAVE_MPI is defined) is therefore unknown.
  • debian/rules:29 runs sed 's=\.PP=\.pp=g' over the miniapps/*.man files that miniapps/Makefile.in:112 installs as /usr/share/man/man1/esl-*.1, after configure has generated them from the .man.in templates; a build would show whether the shipped pages really keep the undefined .pp macro instead of .PP (the .1 files added by debian/patches/mans.patch are generated but never installed).
Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader rejected this upload in response to the review.

Review Information

rejected — allocated to dfsg-uploader 3 days ago, started 3 days ago, completed 3 days ago.

Final Comment

The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.

The uploader said:

Please reject

Back to Dashboard | View all reviews for this package