Review: esrf-pathlib 1.2.0~rc6-1

Package Information

Description	Pathlib-like library for the ESRF file system esrf-pathlib is a drop-in replacement for Python’s built-in pathlib.Path, extended with ESRF-specific attributes. It detects and interprets known ESRF data directory structures and provides high-level access to proposal names, processed data locations, and more.
Maintainer	Debian PaN Maintainers <debian-pan-maintainers@alioth-lists.debian.net>
Changed By	Roland Mas <lolando@debian.org>
Sponsor	lolando@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/python-team/packages/esrf-pathlib.git (browse)
Tracker	https://tracker.debian.org/pkg/esrf-pathlib
Uploaded	8 days ago

New Package Report

.changes◂

Distribution	unstable
Date	Fri, 16 Oct 2026 16:37:19 +0200
Source	esrf-pathlib
Version	1.2.0~rc6-1
Changed-By	Roland Mas <lolando@debian.org>
Architecture	source all

Changelog◂

esrf-pathlib (1.2.0~rc6-1) unstable; urgency=low
 .
   * Initial packaging.

.dsc◂

Section	python
Priority	optional
Component	main
Package-List	python3-esrf-pathlib deb python optional arch=all

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: esrf-pathlib
Upstream-Contact: ESRF <dau-pydev@esrf.fr>
Source: https://gitlab.esrf.fr/workflow/esrf-pathlib

Files: *
Copyright: (c) 2025 European Synchrotron Radiation Facility (ESRF)
License: MIT

Files: debian/*
Copyright: 2026 Roland Mas <lolando@debian.org>
License: MIT

License: MIT
 Copyright (c) 2025 European Synchrotron Radiation Facility (ESRF)
 .
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal in
 the Software without restriction, including without limitation the rights to
 use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 the Software, and to permit persons to whom the Software is furnished to do so,
 subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 1 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 6 days ago.

Report◂

DFSG NEW review for esrf-pathlib version 1.2.0~rc6-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 1 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

Every upstream file, including doc/conf.py, is covered by the catch-all Files: * stanza and is MIT-licensed with the ESRF as the sole copyright holder; LICENSE.md and the copyright field of doc/conf.py agree. debian/copyright is DEP-5, includes the full MIT text (it is not in /usr/share/common-licenses), and the packaging stanza correctly covers debian/*. No third-party, vendored, generated or non-free material was found.

Packaging

The packaging follows current practice: debhelper-compat 14 with dh-sequence-python3 and pybuild-plugin-pyproject, a correct all-architecture binary package with ${python3:Depends}, autopkgtest via autopkgtest-pkg-pybuild (dh-python selects the pytest runner because python3-pytest is in Build-Depends, and debian/pybuild.testfiles makes the tests available), Standards-Version 4.7.4 against Policy 4.7.4.1, and a sane changelog. Only a stale, ineffective debian/python3-esrf-pathlib.pyremove remains.

Issues

1. [minor] [packaging] debian/python3-esrf-pathlib.pyremove names a file that is never installed

Files: debian/python3-esrf-pathlib.pyremove
Basis: checked, in the package or with a reference tool
Evidence: the file contains only doc/conf.py; dh_python3(1) documents pyremove entries as paths under .../dist-packages/ (bar/baz.py 3.2 removes .../python3.2/dist-packages/bar/baz.py).
Problem: The package installs the esrf_pathlib module under dist-packages and ships only README.md as documentation; nothing named doc/conf.py is ever installed there, so the pyremove file has no effect. It is dead packaging, apparently copied from another package.
Fix: Delete debian/python3-esrf-pathlib.pyremove (or, if a file really needs removing, name its path relative to dist-packages).

Verified

The prescan (dfsg-author-check) reported all source authors listed in debian/copyright and singled out no individual files to account for.
Read debian/copyright in full: DEP-5, Format 1.0, Files: * (2025 ESRF, MIT) followed by Files: debian/* (2026 Roland Mas, MIT), with a standalone MIT License paragraph containing the full text.
Grepped the whole tree (excluding .pc/ and debian/cargo-checksum.json, neither present) for Copyright/(C)/©/SPDX/Licensed under/Permission is hereby/GNU/Apache/MPL/public domain/All rights reserved: the only notices are LICENSE.md and doc/conf.py (copyright = "2025-2026, ESRF"), both MIT and covered by Files: *; the year drift is trivial.
Read LICENSE.md in full: MIT, held by European Synchrotron Radiation Facility; it matches the copyright stanza and the licence text.
Read doc/conf.py, README.md, CHANGELOG.md, CONTRIBUTING.md, .readthedocs.yaml, .gitlab-ci.yml, doc/_ext/esrfpath_autodoc.py and scripts/examples.py: no further copyright holders, licence grants or vendored code.
No minified JS/CSS, archives, bytecode, shared objects, PDFs, images, fonts or data files with unclear provenance exist in the tree; doc/_static/custom.css is four lines of hand-written CSS, and doc/_templates/footer_end.html is a two-line template.
Read every debian/ file (control, changelog, rules, copyright, source/format, source/options, python3-esrf-pathlib.docs, python3-esrf-pathlib.pyremove, pybuild.testfiles, salsa-ci.yml); there are no patches, maintainer scripts or tests/control.
The orig tarball contains no debian/ directory and the same top-level entries as the unpacked tree, so no repacking or Files-Excluded entry is needed.
Checked with the policy tool that Policy is 4.7.4.1, so Standards-Version 4.7.4 is current; checked pybuild(1), dh_python3(1) and /usr/share/perl5/Debian/Debhelper/Buildsystem/pybuild.pm that dh_auto_test passes --test-pytest because python3-pytest is in Build-Depends, and that debian/pybuild.testfiles makes src/esrf_pathlib available to the test step.
Checked with apt-cache that pybuild-plugin-pyproject exists (dh-python 7.20260623, pulling python3-build and python3-installer); python3-pytest is present with the <!nocheck> profile.
Reviewed the test suite under src/esrf_pathlib/tests: plain pytest functions and fixtures (tmp_path, monkeypatch, parametrize), no additional dependencies beyond python3-pytest.
uscan found the packaged version as the newest upstream release (upstream 1.2.0~rc6, packaged 1.2.0~rc6).

Not confirmed

The orig tarball was compared by top-level entry listing only, not byte-for-byte against the unpacked tree.
Whether the upstream test suite passes was not run; nothing in the package suggests it would not.

Proposed changes

None.

Uploader's response to the LLM review

The uploader was emailed about the review 5 days ago.

Review Information

accepted — allocated to awm 4 days ago, started 4 days ago, completed 4 days ago.

Final Comment

Back to Dashboard | View all reviews for this package