Review: fence-agents 4.17.0-1
Review Information
accepted — allocated to awm 1 month, 10 days ago, started 1 month, 10 days ago, completed 1 month, 10 days ago.
Final Comment
Public Notes
1 month, 10 days ago
● public
vulture
Command: vulture .
Exit code: 3
/usr/src/dfsg/fence-agents_4.17.0-1/tests/fence_testing.py:72: SyntaxWarning: invalid escape sequence '\('
re_sleep_command = re.compile('sleep\(([0-9]+)\)', re.IGNORECASE)
agents/autodetect/autodetect.py:108: Missing parentheses in call to 'print'. Did you mean print(...)? at "print "Unable to obtain command prompt automatically""
agents/autodetect/fence_apc.py:84: leading zeros in decimal integer literals are not permitted; use an 0o prefix for octal integers at "conn.send(chr(03))"
/usr/src/dfsg/fence-agents_4.17.0-1/agents/autodetect/fence_bladecenter.py:105: SyntaxWarning: invalid escape sequence '\s'
conn = fence_login(options, "(username\s*:\s*)")
agents/autodetect/autodetect_test.py:30: Missing parentheses in call to 'print'. Did you mean print(...)? at "print self.options"
agents/autodetect/fencing.py:531: Missing parentheses in call to 'print'. Did you mean print(...)? at "print "Usage:""
agents/autodetect/a.py:3: unused function 'maf' (60% confidence)
agents/autodetect/a.py:6: unused function 'maf2' (60% confidence)
agents/autodetect/fence_bladecenter.py:23: unused variable 'REDHAT_COPYRIGHT' (60% confidence)
agents/autodetect/fence_bladecenter.py:24: unused variable 'BUILD_DATE' (60% confidence)
agents/autodetect/fence_brocade.py:11: unused variable 'REDHAT_COPYRIGHT' (60% confidence)
agents/autodetect/fence_brocade.py:12: unused variable 'BUILD_DATE' (60% confidence)
agents/autodetect/fence_ilo_moonshot.py:11: unused variable 'REDHAT_COPYRIGHT' (60% confidence)
agents/autodetect/fence_ilo_moonshot.py:12: unused variable 'BUILD_DATE' (60% confidence)
agents/autodetect/fence_lpar.py:21: unused variable 'REDHAT_COPYRIGHT' (60% confidence)
agents/autodetect/fence_lpar.py:22: unused variable 'BUILD_DATE' (60% confidence)
agents/aws/fence_aws.py:15: unused import 'NoRegionError' (90% confidence)
agents/aws_vpc_net/fence_aws_vpc_net.py:24: unused import 'NoRegionError' (90% confidence)
agents/azure_arm/fence_azure_arm.py:6: unused import 'ET' (90% confidence)
agents/eaton_snmp/fence_eaton_snmp.py:42: unused variable 'state_cycling' (60% confidence)
agents/eaton_snmp/fence_eaton_snmp.py:45: unused variable 'turn_cycle' (60% confidence)
agents/eaton_snmp/fence_eaton_snmp.py:57: unused variable 'state_cycling' (60% confidence)
agents/eaton_snmp/fence_eaton_snmp.py:60: unused variable 'turn_cycle' (60% confidence)
agents/eaton_ssh/fence_eaton_ssh.py:35: unused variable 'PENDING_OFF' (60% confidence)
agents/eaton_ssh/fence_eaton_ssh.py:36: unused variable 'PENDING_ON' (60% confidence)
agents/eaton_ssh/fence_eaton_ssh.py:65: unused function 'get_plug_ids' (60% confidence)
agents/ecloud/fence_ecloud.py:32: unused variable 'API_MONITOR' (60% confidence)
agents/evacuate/fence_evacuate.py:57: unused variable 'dictionary' (60% confidence)
agents/heuristics_ping/fence_heuristics_ping.py:21: unused variable 'con' (100% confidence)
agents/ifmib/fence_ifmib.py:27: unused variable 'STATUS_TESTING' (60% confidence)
agents/kubevirt/fence_kubevirt.py:33: unused variable 'include_uninitialized' (60% confidence)
agents/ovh/fence_ovh.py:63: unused attribute 'tempdir' (60% confidence)
agents/skalar/fence_skalar.py:10: unused import 'ast' (90% confidence)
agents/vmware_soap/fence_vmware_soap.py:12: unused import 'TransportError' (90% confidence)
agents/vmware_soap/fence_vmware_soap.py:42: unused attribute '_create_default_https_context' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:55: unused attribute 'tempdir' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:64: unused attribute '_type' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:67: unused attribute '_type' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:96: unused attribute '_type' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:99: unused attribute '_type' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:102: unused attribute '_type' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:107: unused attribute '_type' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:112: unused attribute 'skip' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:117: unused attribute 'selectSet' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:118: unused attribute 'skip' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:121: unused attribute 'all' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:122: unused attribute 'pathSet' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:127: unused attribute 'objectSet' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:159: unused attribute '_type' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:189: unused attribute '_type' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:193: unused attribute '_type' (60% confidence)
agents/vmware_soap/fence_vmware_soap.py:218: unused variable 'frame' (100% confidence)
agents/zvm/fence_zvmip.py:34: unused attribute 'check_hostname' (60% confidence)
agents/zvm/fence_zvmip.py:35: unused attribute 'verify_mode' (60% confidence)
lib/azure_fence.py.py:22: unused variable 'Type' (60% confidence)
lib/azure_fence.py.py:26: unused variable 'Id' (60% confidence)
lib/azure_fence.py.py:34: unused variable 'VMName' (60% confidence)
lib/azure_fence.py.py:41: unused variable 'Verbose' (60% confidence)
lib/azure_fence.py.py:66: unused attribute 'Id' (60% confidence)
lib/azure_fence.py.py:85: unused attribute 'Type' (60% confidence)
lib/azure_fence.py.py:307: unused attribute 'VMName' (60% confidence)
lib/azure_fence.py.py:315: unused attribute 'Verbose' (60% confidence)
lib/fencing.py.py:11: unused import '__main__' (90% confidence)
lib/fencing.py.py:523: unused variable 'size' (100% confidence)
lib/fencing.py.py:1686: unused attribute 'initial_indent' (60% confidence)
lib/fencing.py.py:1687: unused attribute 'subsequent_indent' (60% confidence)
lib/fencing.py.py:1688: unused attribute 'width' (60% confidence)
lib/fencing.py.py:1689: unused attribute 'break_on_hyphens' (60% confidence)
lib/fencing.py.py:1690: unused attribute 'break_long_words' (60% confidence)
lib/fencing.py.py:1720: unused variable 'number' (60% confidence)
lib/XenAPI.py.py:92: unused class 'UDSHTTPConnection' (60% confidence)
lib/XenAPI.py.py:101: unused method 'make_connection' (60% confidence)
lib/XenAPI.py.py:170: unused function 'xapi_local' (60% confidence)
tests/fence_testing.py:5: unused variable 'EC_CONFIG_FAIL' (60% confidence)
tests/test.py:9: unused variable 'AGENTDEF' (60% confidence)
1 month, 10 days ago
● public
Licenserecon
Command: lrc -l
Exit code: 3
en: Versions: licenserecon '11.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
GPL-2+ | Apache-2.0 agents/amt_ws/fence_amt_ws.py
GPL-2+ | GPL-3 agents/cdu/fence_cdu.py
GPL-2+ | LGPL-2.1+ agents/crosslink/fence_crosslink.py
GPL-2+ | LGPL-2.1+ agents/ecloud/fence_ecloud.py
GPL-2+ | LGPL-2.1+ agents/ibmz/fence_ibmz.py
GPL-2+ | GPL-2+ agents/kdump/fence_kdump.c
GPL-2+ | GPL-2+ agents/kdump/fence_kdump_send.c
GPL-2+ | GPL-2+ agents/kdump/message.h
GPL-2+ | GPL-2+ agents/kdump/options.h
GPL-2+ | GPL-2+ agents/kdump/version.h
GPL-2+ | LGPL-2.1+ agents/lindy_pdu/fence_lindypdu.py
GPL-2+ | GPL-2+ agents/virt/client/main.c
GPL-2+ | GPL-2 agents/virt/client/Makefile.am
GPL-2+ | GPL-2+ agents/virt/client/mcast.c
GPL-2+ | GPL-2+ agents/virt/client/options.c
GPL-2+ | GPL-2 agents/virt/client/serial.c
GPL-2+ | GPL-2+ agents/virt/client/tcp.c
GPL-2+ | GPL-2+ agents/virt/client/vsock.c
GPL-2+ | GPL-2+ agents/virt/common/debug.c
GPL-2+ | GPL-2+ agents/virt/common/fdops.c
GPL-2+ | LGPL-2.1+ agents/virt/common/ip_lookup.c
GPL-2+ | GPL-2 agents/virt/common/Makefile.am
GPL-2+ | GPL-2+ agents/virt/common/mcast.c
GPL-2+ | GPL-2+ agents/virt/common/simple_auth.c
GPL-2+ | GPL-2+ agents/virt/common/tcp.c
GPL-2+ | GPL-2 agents/virt/config/Makefile.am
GPL-2+ | GPL-2+ agents/virt/include/debug.h
GPL-2+ | LGPL-2.1+ agents/virt/include/ip_lookup.h
GPL-2+ | GPL-2+ agents/virt/include/mcast.h
GPL-2+ | GPL-2+ agents/virt/include/options.h
GPL-2+ | GPL-2+ agents/virt/include/simple_auth.h
GPL-2+ | GPL-2+ agents/virt/include/tcp.h
GPL-2+ | GPL-2+ agents/virt/include/xvm.h
GPL-2+ | GPL-2 agents/virt/Makefile.am
GPL-2+ | GPL-2 agents/virt/man/Makefile.am
GPL-2+ | GPL-2+ agents/virt/server/cpg-virt.c
GPL-2+ | GPL-2+ agents/virt/server/libvirt.c
GPL-2+ | GPL-2 agents/virt/server/Makefile.am
GPL-2+ | GPL-2+ agents/virt/server/mcast.c
GPL-2+ | LGPL-2.1+ agents/virt/server/plugin.c
GPL-2+ | GPL-2+ agents/virt/server/serial.c
GPL-2+ | GPL-2+ agents/virt/server/tcp.c
GPL-2+ | GPL-2+ agents/virt/server/virt.c
GPL-2+ | GPL-2+ agents/virt/server/virt.h
GPL-2+ | GPL-2+ agents/virt/server/vsock.c
GPL-2+ | GPL-2+ agents/xenapi/fence_xenapi.py
LGPL-2.1+ | LGPL-2.1+ agents/zvm/fence_zvm.c
LGPL-2.1+ | LGPL-2.1+ agents/zvm/fence_zvm.h
GPL-2+ | LGPL-2.1+ agents/zvm/fence_zvmip.c
GPL-2+ | GPL-2 fence-agents.spec.in
GPL-2+ | LGPL-2.1 lib/XenAPI.py.py
GPL-2+ | GPL-3+ with Autoconf-2.0~Archive exception m4/ax_check_link_flag.m4
GPL-2+ | GPL-3+ m4/ax_prog_date.m4
GPL-2+ | GPL m4/ax_pthread.m4
GPL-2+ | GPL-2 m4/PKG_CHECK_VAR.m4
GPL-2+ | GPL-3+ make/gitlog-to-changelog
GPL-2+ | GPL-3+ make/git-version-gen
GPL-2+ | GPL-2+ systemd/Makefile.am