Review: fwts 26.07.00-1
Package Information
| Description | FirmWare Test Suite This is a firmware test suite that performs sanity checks on system firmware. It is intended to identify BIOS and ACPI errors and if appropriate it will try to explain the errors and give advice to help workaround or fix firmware bugs. It is primarily intended to be a Linux-centric firmware troubleshooting tool. |
|---|---|
| Maintainer | Manuel Traut <manut@debian.org> |
| Changed By | Manuel Traut <manut@debian.org> |
| Distribution | unstable |
| Architecture | amd64 arm64 armhf i386 loong64 ppc64 ppc64el riscv64 s390x x32 |
| VCS | git: https://salsa.debian.org/debian/fwts.git (browse) |
| Closes | #748783 |
| Tracker | https://tracker.debian.org/pkg/fwts |
| Uploaded | 1 month, 13 days ago |
New Package Report
.changes
| Source | fwts |
|---|---|
| Version | 26.07.00-1 |
| Changed-By | Manuel Traut <manut@debian.org> |
| Architecture | source arm64 |
| Distribution | unstable |
| Date | Tue, 22 Sep 2026 17:00:31 +0200 |
Changelog
fwts (26.07.00-1) unstable; urgency=medium . * Initial release. (Closes: #748783)
.dsc
| Component | main |
|---|---|
| Package-List | fwts deb devel optional arch=amd64,arm64,armhf,i386,loong64,ppc64,ppc64el,riscv64,s390x,x32 fwts-frontend deb devel optional arch=amd64,arm64,armhf,i386,loong64,ppc64,ppc64el,riscv64,s390x,x32 fwts-smccc-dkms deb kernel optional arch=arm64 |
| Section | devel |
| Priority | optional |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: https://github.com/fwts/fwts Upstream-Name: fwts Files-Excluded: debian/* Files: * Copyright: 2010-2026, Canonical, Ltd. 1999-2026, Intel Corp. License: GPL-2+ Files: debian/* Copyright: 2026 Manuel Traut <manut@debian.org> 2010-2026, Canonical Ltd License: GPL-2+ Files: fedora/fwts.spec.in Copyright: 2017 Prarit Bhargava <prarit@redhat.com> License: GPL-2 Files: git.mk Copyright: 2010-2013, Behdad Esfahbod 2009, Red Hat, Inc. License: Public-Domain Files: live-image/fwts-frontend-text Copyright: 2016-2025, IBM 2010-2026, Canonical License: GPL-2+ Files: src/acpi/acpidump/* Copyright: 2010-2026, Canonical License: GPL-1 Files: src/acpi/acpitables/* Copyright: 2010-2026, Canonical License: GPL-1 Files: src/acpi/madt/* Copyright: 2015-2026, Canonical 2015, Al Stone <ahs3@redhat.com> License: GPL-2+ Files: src/acpi/rhct/* Copyright: 2026, Canonical 2025, Ventana Micro Systems Inc 2023, Intel Corporation License: GPL-2+ Files: src/coreboot/clog/* Copyright: 9, 2018-2021, elements Cyber Security 9, 2018-2021, elements Cyber Security 2010-2026, Canonical License: GPL-2+ Files: src/cpu/virt/* Copyright: 2010-2026, Canonical 2007, AMD Inc 2006, Intel Corp License: LGPL-2.1 Files: src/cpu/virt/virt.h Copyright: 2014-2026, Canonical License: GPL-2+ Files: src/cpu/virt/virt.c Copyright: 2010-2026, Canonical 2007, AMD Inc 2006, Intel Corp License: GPL-2+ Files: src/cpu/virt/virt_vmx.c Copyright: 2010-2026, Canonical 2007, AMD Inc 2006, Intel Corporation License: LGPL-2.1 Files: src/devicetree/* Copyright: 2014-2021, Jeremy Kerr <jk@ozlabs.org> License: GPL-2+ Files: src/ipmi/* Copyright: 2016-2025, IBM 2010-2026, Canonical License: GPL-2+ Files: src/kernel/olog/* Copyright: 2016-2025, IBM 2010-2026, Canonical License: GPL-2+ Files: src/lib/include/fwts.h src/lib/include/fwts_framework.h src/lib/include/fwts_ipmi.h src/lib/include/fwts_olog.h Copyright: 2016-2025, IBM 2010-2026, Canonical License: GPL-2+ Files: src/lib/include/fwts_arch.h Copyright: 2016-2021, Al Stone <ahs3@redhat.com> License: GPL-2+ Files: src/lib/include/fwts_clog.h Copyright: 9, 2018-2021, elements Cyber Security 2010-2026, Canonical License: GPL-2+ Files: src/lib/include/fwts_coreboot.h Copyright: 9, 2018-2021, elements Cyber Security 2017-2021, Google Inc. 2010-2026, Canonical License: GPL-2+ Files: src/lib/include/fwts_devicetree.h Copyright: 2016-2021, IBM Corporation License: GPL-2+ Files: src/lib/include/fwts_memorymap.h Copyright: 2010-2026, Canonical 2006, Intel Corporation License: GPL-2+ Files: src/lib/include/fwts_smccc.h Copyright: 2026, Arm Ltd. License: GPL-2+ Files: src/lib/src/fwts_arch.c Copyright: 2016-2021, Al Stone <ahs3@redhat.com> License: GPL-2+ Files: src/lib/src/fwts_args.c src/lib/src/fwts_framework.c src/lib/src/fwts_ipmi.c src/lib/src/fwts_olog.c Copyright: 2016-2025, IBM 2010-2026, Canonical License: GPL-2+ Files: src/lib/src/fwts_clog.c Copyright: 9, 2018-2021, elements Cyber Security 2010-2026, Canonical License: GPL-2+ Files: src/lib/src/fwts_coreboot.c src/lib/src/fwts_coreboot_cbmem.c Copyright: 9, 2018-2021, elements Cyber Security 2017-2021, Google Inc. 2010-2026, Canonical License: GPL-2+ Files: src/lib/src/fwts_devicetree.c Copyright: 2016-2021, IBM Corporation License: GPL-2+ Files: src/lib/src/fwts_pipeio.c src/lib/src/fwts_stringextras.c Copyright: 2010-2026, Canonical 2010, Lennart Poettering: License: GPL-2+ Files: src/lib/src/fwts_smccc.c Copyright: 2026, Arm Ltd. License: GPL-2+ Files: src/opal/* Copyright: 2016-2025, IBM 2010-2026, Canonical License: GPL-2+ Files: src/sbbr/* Copyright: 2017-2021, ARM Ltd 2010-2026, Canonical License: GPL-2+ Files: src/sbbr/acpitables/* Copyright: 2017-2021, ARM Ltd 2010-2026, Canonical License: GPL-1 Files: src/uefi/uefirttime/* Copyright: 2021, ARM Limited. 2012-2026, Canonical License: GPL-2+ License: GPL-1 This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License On Debian systems, the complete text of version 1 of the GNU General Public License can be found in '/usr/share/common-licenses/GPL-1'. License: GPL-2 This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; version 2 dated June, 1991. On Debian systems, the complete text of version 2 of the GNU General Public License can be found in '/usr/share/common-licenses/GPL-2'. License: GPL-2+ This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; version 2 dated June, 1991, or (at your option) any later version. On Debian systems, the complete text of version 2 of the GNU General Public License can be found in '/usr/share/common-licenses/GPL-2'. License: LGPL-2.1 This program is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; version 2.1 of the License. On Debian systems, the complete text of version 2.1 of the GNU Lesser General Public License can be found in '/usr/share/common-licenses/LGPL-2.1'. License: Public-Domain Copying and distribution of this file, with or without modification, is permitted in any medium without royalty provided the copyright notice and this notice are preserved.
Review Information
rejected — allocated to awm 1 month, 12 days ago, started 1 month, 12 days ago, completed 1 month, 12 days ago.
Final Comment
Hi,
The package has a number of issues with debian/copyright, as follows...
- Mangled copyright holder name (×6).
debian/copyright lines 50, 51, 104, 109, 140, and 146 read Copyright: 9, 2018-2021, elements Cyber Security. The real holder is 9elements Cyber Security — the "9" has been split off the company name into a stray 9, prefix, and the name is truncated to "elements". The source headers confirm the correct name, e.g. src/lib/src/fwts_coreboot.c and src/lib/src/fwts_clog.c say Copyright (C) 2018-2021 9elements Cyber Security. This violates Policy §12.5 (copyright/license must be accurate).
- Duplicate copyright entry.
The src/coreboot/clog/* stanza (lines 49–53) lists the same "elements Cyber Security" copyright twice on lines 50 and 51.
- Files: * blanket GPL-2+ claim is incomplete/inaccurate.
The largest omission is the entire bundled ACPICA tree (src/acpica/), which carries the Intel ACPICA dual license (a BSD-3-clause-style license), not GPL-2+. Verified in src/acpica/source/components/debugger/dbcmds.c ("This is your license from Intel Corp. under its intellectual property rights…"). There is no src/acpica/* stanza in debian/copyright at all — the only acpica reference in the whole debian/ tree is debian/not-installed. So the real license of a substantial bundled component is undocumented.
- GPL-1 labels are unsupported by the files.
src/acpi/acpidump/* (line 32), src/acpi/acpitables/* (line 36) and src/sbbr/acpitables/* (line 178) are claimed as GPL-1. But the actual headers (src/acpi/acpidump/acpidump.c, src/acpi/acpitables/acpitables.c, src/sbbr/acpitables/acpitables.c) contain a truncated GPL header — they read "modify it under the terms of the GNU General Public License" and jump straight to "This program is distributed…", missing the version clause entirely. So neither the "GPL-1" label nor the generic "GPL-2+" is accurate for these files; the headers simply lack a complete license grant. (The malformed header is an upstream defect the packager should have caught rather than inventing a "GPL-1" attribution.)
- Files-Excluded: debian/* (line 4) is meaningless.
That field excludes upstream tarball files, but debian/ is not part of the upstream tarball, so it does nothing. There is no +dfsg version suffix (the version is plain 26.07.00-1, per the .dsc), no debian/patches/, and no debian/README.source. So if a DFSG repack was intended, it's not reflected anywhere; if not, the Files-Excluded line should be removed.
- Additional authors missing from debian/copright are listed in the full review.
Thanks!
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 26.07.00-1 | 2fa2c82d… | 2026-09-29 09:02 | 2026-09-29 09:04 | awm | accepted | VIEW |
Public Notes
Missed Author Check
Command: dnq author-check -prepare
Exit code: 0
Author check: scanned 1291 files.
NOT IN debian/copyright (4):
Arm
src/smccc/psci.c:4
Atheros Corporation
fwts-test/oops-0001/oops.txt:24516
Microsoft
src/acpica/source/include/actbl2.h:2573
src/acpica/source/include/actbl3.h:214
src/acpica/source/include/actbl3.h:826
okir@monad.swb.de)
fwts-test/arg-json-0001/klog.txt:856
fwts-test/arg-klog-0001/klog.txt:856
fwts-test/arg-results-0001/klog.txt:856
fwts-test/arg-results-no-separators-0001/klog.txt:856
fwts-test/arg-show-progress-dialog-0001/klog.txt:856
... and 1 more file
PROBABLE FALSE POSITIVES (1) — a name fragment already appears in debian/copyright:
9elements Cyber Security (might be "9, 2018-2021, elements Cyber Security")
src/coreboot/clog/clog.c:3
src/lib/include/fwts_clog.h:3
src/lib/include/fwts_coreboot.h:4
src/lib/src/fwts_clog.c:3
src/lib/src/fwts_coreboot.c:4
... and 1 more file
Result: ATTENTION REQUIRED — 4 authors not in debian/copyright