DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: geny 1.1.1-1

Package Information

Descriptionpush-based generators with resource cleanup for Scala (Scala 2.13)

Geny provides geny.Generator, the dual of scala.Iterator: the producer pushes values to the consumer, so files and other resources are always released when the consumer stops early. It also provides geny.Writable and geny.Readable, push and pull interfaces for streams of bytes.

This package provides com.lihaoyi:geny_2.13, built for Scala 2.13.

MaintainerDebian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org>
Changed ByJuan Manuel Méndez Rey <juan.mendezr@proton.me>
Sponsortsimonq2@debian.org
Distributionunstable
Architectureall
VCSgit: https://salsa.debian.org/java-team/geny.git (browse)
Closes#1152800
Trackerhttps://tracker.debian.org/pkg/geny
Uploaded2 hours ago

New Package Report

.changes◂
Changed-ByJuan Manuel Méndez Rey <juan.mendezr@proton.me>
Architecturesource all
Distributionunstable
DateMon, 02 Nov 2026 21:47:59 +0100
Sourcegeny
Version1.1.1-1
Changelog◂
geny (1.1.1-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #1152800)
.dsc◂
Package-Listlibgeny-scala2.13-java deb java optional arch=all
libgeny-scala3-java deb java optional arch=all
Sectionjava
Priorityoptional
Componentmain
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: geny
Upstream-Contact: Li Haoyi <haoyi.sg@gmail.com>
Source: https://github.com/com-lihaoyi/geny

Files: *
Copyright: 2016 Li Haoyi (haoyi.sg@gmail.com)
License: Expat

Files: mill
Copyright: 2017 Li Haoyi (haoyi.sg@gmail.com)
License: Expat
Comment: Mill's launcher script from Mill 0.10.5, under Mill's LICENSE.
 Not used by the build.

Files: debian/*
Copyright: 2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me>
License: Expat

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in
 all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 DEALINGS IN THE SOFTWARE.

DFSG Assistant LLM REVIEW 1 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 0 hours ago.

Report◂

DFSG NEW review for geny version 1.1.1-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: Yes
  • Issues: 1 blocker, 0 important, 0 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

The package is otherwise Expat/MIT throughout and debian/copyright is in DEP-5 format and matches LICENSE, but geny/src/geny/Internal.scala explicitly contains a block copied from Guava (marked // VENDORED FROM GUAVA), which is Apache-2.0 code by The Guava Authors. The Files: * stanza claims that file is Expat with Li Haoyi as the only holder, which is inaccurate: the third-party notice is missing and the licence named is wrong. The source package distributes that code and both binary packages compile it in, so this must be fixed before upload. No non-free terms, no files without a licence, no build products or generated sources in the tree.

Packaging

Packaging is modern and clean: debhelper compat 14, the dh-sequence-scala build system with a scala-build file, two clearly split Architecture: all packages for Scala 2.13 and Scala 3, DEP-5 copyright, autopkgtests, current Standards-Version 4.7.4 and a Java-team Vcs-* field. The only defect found is the licensing inaccuracy in debian/copyright, reported under licensing; no packaging-specific fault warranted an issue.

Issues

blocker licensing 1. debian/copyright declares geny/src/geny/Internal.scala as Expat, but the file contains code copied from Guava (Apache-2.0, The Guava Authors) ◂
  • Files: geny/src/geny/Internal.scala:64-112, debian/copyright:6-9
  • Basis: checked, in the package or with a reference tool
  • Evidence: Internal.scala: // VENDORED FROM GUAVA ... def encodedLength(sequence: String) = { // Warning to maintainers: this implementation is highly optimized. ... // END VENDORED FROM GUAVA; debian/copyright: Files: * / Copyright: 2016 Li Haoyi (haoyi.sg@gmail.com) / License: Expat.
  • Problem: The ~50 lines between the two markers are Guava's Utf8.encodedLength/encodedLengthGeneral, translated to Scala with Guava's comments retained. Guava is under the Apache License 2.0, copyright The Guava Authors, so the Files: * stanza names the wrong licence and omits a holder whose notice the licence requires to be kept (Policy 2.3). The file is compiled into both libgeny-scala2.13-java and libgeny-scala3-java, so the omission is not excused by the file being shipped as plain text with its notice; and a wrong licence is a defect wherever the file is, since the source package distributes it too. Expat and Apache-2.0 are compatible, so the fix is documentation, not removal.
  • Fix: Add a stanza for the file (placed after Files: *) naming both holders and both licences, e.g. Files: geny/src/geny/Internal.scala / Copyright: 2016 Li Haoyi (haoyi.sg@gmail.com) / Copyright: 2011 The Guava Authors / License: Expat and Apache-2.0, plus a standalone License: Apache-2.0 paragraph referring to /usr/share/common-licenses/Apache-2.0.
Verified ◂
  • Tree inventory: 16 upstream files (LICENSE, Readme.adoc, build.sc, mill, .mill-version, .gitignore, .github/dependabot.yml, .github/workflows/{actions,dependency-graph}.yml, geny/src/geny/{ByteData,Bytes,Generator,Internal,Writable}.scala, geny/test/src/geny/{TestGenerator,TestReadable,TestWritable}.scala) plus debian/; no other LICENSE, COPYING, NOTICE or AUTHORS file exists, and no subdirectory carries its own licensing.
  • Prescan's author check listed no unnamed holder and no file path; I also grepped the whole tree for Copyright/(C)/©/SPDX/Licensed under/GNU/Apache/Mozilla/public domain/All rights reserved/vendored and the only hit is the Guava block in Internal.scala.
  • LICENSE is the MIT text; debian/copyright's Expat text matches it, and the Files: mill stanza correctly gives the Mill launcher script (MIT, not used by the build since debian/scala-build builds geny/src) a separate stanza.
  • Readme.adoc contains only documentation and code examples, no third-party licence text; .github CI/workflow files carry no notices and are covered by the top-level LICENSE; both are source-only.
  • No built files, minified code, archives, PDFs or fonts in the tree; no debian/patches, so no patch-created files to account for.
  • debian/control: debhelper-compat 14 and dh-sequence-scala (provided by scala-debian-helper 0.1, in the archive) with scala-2.13 and scala3, both in the archive; ${scala:Depends} is present and would also be added automatically at compat 14.
  • Standards-Version 4.7.4 is current enough against the reviewing system's Policy 4.7.4.1 (first two components match).
  • Autopkgtests exist: a superficial smoke test and a compile-and-run test that compiles debian/tests/GenyTest.scala against each installed jar; Architecture: all jars, no maintainer scripts, source format 3.0 (quilt).
  • uscan found the packaged version as the newest upstream release (upstream 1.1.1, packaged 1.1.1).
Not confirmed ◂
  • debian/tests/compile-and-run runs java -cp $J/scala-library-$v.jar with v=3; Debian's scala3-library probably installs the jar as scala3-library_3.jar, but the package file list is not available here, so I could not confirm whether the Scala 3 autopkgtest would fail on that classpath entry.
  • debian/poms/*.pom.xml declare scala-library 2.13.8 and scala3-library_3 3.3.1 while the archive has 2.13.18 and 3.9.0; I could not verify whether dh_scala rewrites those versions when installing the POMs, so I make no claim about Maven resolution.
  • The existence of /usr/share/scala-debian-helper/smoke-test in scala-debian-helper 0.1 could not be checked (the helper is not installed on the reviewing system).
Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader rejected this upload in response to the review.

Review Information

rejected — allocated to dfsg-uploader 0 hours ago, started 0 hours ago, completed 0 hours ago.

Final Comment

The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.

The uploader said:

Confirmed. geny/src/geny/Internal.scala contains encodedLength and encodedLengthGeneral from Guava’s Utf8 (Apache-2.0, The Guava Authors), marked VENDORED FROM GUAVA.

Fixed in debian/copyright: https://salsa.debian.org/java-team/geny/-/commit/412fbecba46dc8423b7f4cbbadd97c64b94745ab .

Please reject; the same version will be uploaded again with the fix.

Back to Dashboard | View all reviews for this package