Review: gmpfrxx-mkii 1.5.0+ds-1
Package Information
| Description | versioned runtime for gmpfrxx_mkII default context provider This package contains the shared library that provides the versioned external default-context API used by gmpfrxx_mkII consumers sharing thread-local GMP precision state. |
|---|---|
| Maintainer | Debian Science Maintainers <debian-science-maintainers@lists.alioth.debian.org> |
| Changed By | Maho Nakata <maho.nakata@gmail.com> |
| Sponsor | rafael@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/science-team/gmpfrxx-mkii.git (browse) |
| Closes | #1151368 |
| Tracker | https://tracker.debian.org/pkg/gmpfrxx-mkii |
| Uploaded | 13 days ago |
New Package Report
.changes
| Source | gmpfrxx-mkii |
|---|---|
| Version | 1.5.0+ds-1 |
| Changed-By | Maho Nakata <maho.nakata@gmail.com> |
| Architecture | source amd64 |
| Distribution | unstable |
| Date | Sun, 25 Oct 2026 06:21:00 +0000 |
Changelog
gmpfrxx-mkii (1.5.0+ds-1) unstable; urgency=medium . * Initial release. (Closes: #1151368)
.dsc
| Section | libdevel |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | libgmpfrxx-mkii-dev deb libdevel optional arch=any libgmpxx-mkii-default-context-provider1 deb libs optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: gmpfrxx_mkII
Source: https://github.com/nakatamaho/gmpfrxx_mkII
Files-Excluded: reference/upstream/*
Files: *
Copyright: 2026 Maho NAKATA
License: BSD-2-Clause
Files: include/gmpfrxx_mkII/adapters/ds_real.hpp
include/gmpfrxx_mkII/adapters/edd_real.hpp
include/gmpfrxx_mkII/adapters/qs_real.hpp
include/gmpfrxx_mkII/adapters/single_real.hpp
include/gmpfrxx_mkII/adapters/td_real.hpp
include/gmpfrxx_mkII/adapters/ts_real.hpp
Copyright: 2026 Maho NAKATA
License: BSD-3-Clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
1. Redistributions of source code must retain the above copyright
notice, and the entire permission notice in its entirety,
including the disclaimer of warranties.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
3. The name of the author may not be used to endorse or promote
products derived from this software without specific prior
written permission.
.
THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE, ALL OF
WHICH ARE HEREBY DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE
LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE OF THIS SOFTWARE, EVEN IF NOT ADVISED OF THE POSSIBILITY OF SUCH
DAMAGE.
Files: debian/*
Copyright: 2026 Maho NAKATA
License: BSD-2-Clause
License: BSD-2-Clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
.
1. Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
.
THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS "AS IS" AND ANY
EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR ANY
DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 1 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 13 days ago.
Report
DFSG NEW review for gmpfrxx-mkii version 1.5.0+ds-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 1 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: 1 found
Licensing
The whole source is under permissive BSD licences: BSD-2-Clause for everything except six adapter headers that carry SPDX BSD-3-Clause. debian/copyright is machine-readable (DEP-5) and its stanzas match the tree: Files: * names BSD-2-Clause and the sole copyright holder (Maho NAKATA), a dedicated stanza names the six BSD-3-Clause adapter headers with full licence text, and debian/* is covered. Both licences are DFSG-free and their full texts are reproduced (BSD-2/BSD-3) rather than relying on /usr/share/common-licenses, which is correct. The only holder found anywhere is Maho Nakata (the mplapack-derived benchmark files carry the same author under 'Nakata, Maho' with earlier years, which is the same entity).
Packaging
Clean, conventional packaging: debhelper-compat 14 with the cmake buildsystem, correct Build-Depends (gmp/mpfr/mpc -dev), hardening=+all, a sensible binary split into a versioned runtime library and a -dev package, correct symbols file with the versioned _v1 ABI, an autopkgtest that exercises an installed consumer via find_package, and two DEP-3 patches with clear purposes. The 11 qd-adapter headers are deliberately dropped at install time because libQD3 is not in Debian, and the qd-dependent tests are properly gated on qd being found, so nothing breaks. The only gap is the absence of Multi-Arch: same on the two binary packages.
Issues
minor packaging 1. libgmpxx-mkii-default-context-provider1 and libgmpfrxx-mkii-dev lack Multi-Arch: same ◂
- Files:
debian/control - Basis: checked, in the package or with a reference tool
- Evidence: Both
Package: libgmpxx-mkii-default-context-provider1andPackage: libgmpfrxx-mkii-devdeclareArchitecture: anywith noMulti-Archfield, yet install files underusr/lib/*/(the multiarch libdir). - Problem: The runtime shared library and the -dev package install architecture-specific files under the multiarch libdir but do not declare
Multi-Arch: same, so the two architectures cannot be installed concurrently and arch-qualified reverse dependencies (including cross-built consumers of this header-only library) are impossible. Policy 5.6.34.3 requires theMulti-Arch: samedeclaration for packages meant to be co-installable per architecture. - Fix: Add
Multi-Arch: sameto both binary packages (and, as the -dev Depends already uses(= ${binary:Version}), qualify the runtime dependency as:anyor:sameas appropriate once the library is multi-arch).
Verified ◂
- Read debian/copyright in full: DEP-5 format, header paragraph,
Files: *(BSD-2-Clause, 2026 Maho NAKATA), the six BSD-3-Clause adapter files,debian/*, and the standalone BSD-2-Clause text; the BSD-3-Clause text is inlined in the stanza. - Grepped the whole tree (gitignore off) for
SPDX-License-Identifier,Copyright,GNU General Public,GNU Lesser,Apache License,Mozilla Public,public domain,non-commercial,Permission is hereby granted,Licensed under,All rights reserved: the only licences present are BSD-2-Clause and BSD-3-Clause; no GPL/LGPL/Apache/MPL/MIT, no restrictive terms. manual/gmpfrxx_mkII_manual.pdf(the scan's generated-document hit) is generated frommanual/gmpfrxx_mkII_manual.texviamanual/Makefile(pdflatex); its preferred form for modification is present, so it is not a DFSG problem.- The mplapack-derived benchmark files (
benchmarks/gmp/00_Rdot/Rdot.hpp,benchmarks/mpfr/00_Rdot/Rdot.hppand the Raxpy/Rgemv analogues) carryCopyright (c) 2008-2021/2008-2024 Nakata, Mahowith a 2-clause BSD notice — the same holder asMaho NAKATA, soFiles: *covers them; only the year differs. reference/is empty: theFiles-Excluded: reference/upstream/*repack removed those files, and the+dsorig tarball contains noreference/entries.- The
benchmarks/.../results_raw/CSV/PNG/log files are generated benchmark output with no licence header, correctly falling underFiles: *. - Read debian/control, rules, changelog, source/format, gbp.conf, salsa-ci.yml, both install files, the symbols file, both patches, tests/control, installed-smoke and smoke/*; verified the qd-adapter tests in tests/CMakeLists.txt are gated on
find_path/find_libraryfor qd and are skipped when libQD3 is absent. - Standards-Version 4.7.4 is current (Policy 4.7.x), per the policy tool.
- uscan found the packaged version as the newest upstream release (upstream
1.5.0, packaged1.5.0+ds).
Not confirmed ◂
- Licence identification was done by grepping the full tree plus reading representative file headers and every LICENSE-like file; I did not read all 635 files line-by-line, though the uniform single-author BSD-2 origin makes hidden third-party code unlikely.
- Could not build or run the package; build/autopkgtest success is assumed from the packaging and will be confirmed by the build daemons.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader rejected this upload in response to the review.
Review Information
rejected — allocated to dfsg-uploader 13 days ago, started 13 days ago, completed 13 days ago.
Final Comment
The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.
The uploader said:
I am hereby rejecting this upload. I will fix the Multi-Arch issue and re-upload the package.