DFSG NEW Queue

DFSG, Licensing & New Packages Team

golang-github-alicebob-miniredis 2.40.0-1

Package Information

DescriptionPure Go Redis server for Go unittests (library)

Miniredis is used when you want to test code which uses Redis, without making it a full-blown integration test. Miniredis implements (parts of) the Redis server, to be used in unittests. It enables a simple, cheap, in-memory, Redis replacement, with a real TCP interface. Think of it as the Redis version of net/http/httptest.

MaintainerDebian Go Packaging Team <team+pkg-go@tracker.debian.org>
Changed ByRafael Passos <rafael@rcpassos.me>
Distributionunstable
Architectureall
VCSgit: https://salsa.debian.org/go-team/packages/golang-github-alicebob-miniredis.git (browse)
Closes#1127854
Popcon Installs1
Blocked Bugs#982891 (wishlist)
Trackerhttps://tracker.debian.org/pkg/golang-github-alicebob-miniredis
Uploaded2 hours ago

New Package Report

.changes◂
DateSat, 07 Nov 2026 21:56:05 -0300
Sourcegolang-github-alicebob-miniredis
Version2.40.0-1
Changed-ByRafael Passos <rafael@rcpassos.me>
Architecturesource all
Distributionunstable
Changelog◂
golang-github-alicebob-miniredis (2.40.0-1) unstable; urgency=medium
 .
   * Reintroduce package (Closes: #1127854)
   * New upstream version 2.40.0
   * d/patches: patch fix 32bit support
   * d/watch: update debian watch to v5
.dsc◂
Sectiongolang
Priorityoptional
Componentmain
Package-Listgolang-github-alicebob-miniredis-v2-dev deb golang optional arch=all
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/alicebob/miniredis
Upstream-Name: miniredis
Upstream-Contact: Harmen <alicebob@lijzij.de>

Files: *
Copyright: 2014 Harmen
License: Expat

Files: fpconv/*
Copyright: 2016 Damian Gryski
License: BSL-1.0

Files: metro/*
Copyright: 2016 Damian Gryski
License: Expat

Files: geohash/*
Copyright: 2015 Michael McLoughlin
License: Expat

Files: gopher-json/*
Copyright: Harmen
License: Unlicense
Comment: The License file says it was copied from
         another repository from the same author.

Files: hyperloglog/*
Copyright: 2017 Axiom Inc. <seif@axiom.sh>
License: Expat

Files: debian/*
Copyright:
    2017 Michael Lustfield <michael@lustfield.net>
    2026 Rafael Passos <rafael@rcpassos.me>
License: Expat
Comment: Debian packaging is licensed under the same terms as upstream

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

License: BSL-1.0
 Debian systems provide the Boost Software License - Version 1.0 license in
 /usr/share/common-licenses/BSL-1.0

License: Unlicense
 This is free and unencumbered software released into the public domain.
 .
 Anyone is free to copy, modify, publish, use, compile, sell, or
 distribute this software, either in source code form or as a compiled
 binary, for any purpose, commercial or non-commercial, and by any
 means.
 .
 In jurisdictions that recognize copyright laws, the author or authors
 of this software dedicate any and all copyright interest in the
 software to the public domain. We make this dedication for the benefit
 of the public at large and to the detriment of our heirs and
 successors. We intend this dedication to be an overt act of
 relinquishment in perpetuity of all present and future rights to this
 software under copyright law.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
 IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
 OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
 ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 OTHER DEALINGS IN THE SOFTWARE.
 .
 For more information, please refer to <http://unlicense.org/>

DFSG Assistant LLM REVIEW 0 blocker, 1 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 hour ago.

Report◂

DFSG NEW review for golang-github-alicebob-miniredis version 2.40.0-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: Yes
  • Issues: 0 blocker, 1 important, 0 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: 2 found

Licensing

Every licence found in the tree (Expat/MIT, Boost 1.0, Unlicense) is DFSG-free and compatible, and debian/copyright is DEP-5 with correct stanzas for the root, fpconv/, metro/, geohash/, gopher-json/, hyperloglog/ and debian/. One inaccuracy remains: size/ is credited by the package itself to github.com/DmitriyVTitov/size and reproduces that package's code, yet debian/copyright's catch-all stanza attributes it solely to Harmen under Expat and records neither the origin nor any upstream holder.

Packaging

Packaging is clean and conventional: debhelper compat 14 with dh-sequence-golang and dpkg-build-api 1, --buildsystem=golang, single-binary add-on so dh_auto_install installs the Go source directly into the one arch:all binary package, DH_GOLANG_EXCLUDES for the integration test package main, correct Build-Depends (golang-any, gopher-lua) and Depends, Standards-Version 4.7.4, Vcs-*/Homepage/XS-Go-Import-Path present, Testsuite: autopkgtest-pkg-go, and one well-described DEP-3 patch, forwarded upstream, fixing 32-bit builds.

Issues

important licensing 1. debian/copyright attributes size/ solely to Harmen and omits its credited origin github.com/DmitriyVTitov/size ◂
  • Files: debian/copyright:6-8, size/readme.md:2, size/size.go:9-25
  • Basis: inferred from what was read, not seen directly
  • Evidence: size/readme.md:2: "Credits to DmitriyVTitov on his package https://github.com/DmitriyVTitov/size"; debian/copyright: Files: * / Copyright: 2014 Harmen / License: Expat; size/size.go reproduces that package's Of(v interface{}) int/sizeOf(..., cache map[uintptr]bool) implementation and comments ("10.79 comes from https://golang.org/src/runtime/map.go").
  • Problem: size/ is a third-party package adapted into the tree, but debian/copyright's catch-all stanza names only Harmen for it, so the provenance and the upstream copyright notice are not recorded, which makes debian/copyright inaccurate for those files. MIT-licensed code must keep its copyright notice reproduced.
  • Fix: Add a Files: size/* stanza naming the upstream holder as github.com/DmitriyVTitov/size states it, with License: Expat (or whatever that file states) and a Comment: giving the source URL; also ask upstream to ship the notice in size/ itself.
Verified ◂
  • Read every file under debian/ in full: control, rules, changelog, copyright, gbp.conf, salsa-ci.yml, source/format, upstream/metadata, patches/*, plus the .dsc; debian/watch was left to the separate check.
  • Read the single quilt patch (669 lines) in full: DEP-3 header with From/Date/Subject, a Forwarded: PR URL and a rationale; it converts the expire/incr wire paths to int64, adds proto.Int64()/WriteInt64(), and makes the size tests architecture-independent. Nothing obsolete or unforwarded.
  • The whole tree (134 files) was inventoried; debian/copyright's stanzas match every licence file: root LICENSE (Expat, 2014 Harmen), fpconv/LICENSE.txt (Boost-1.0 text), metro/LICENSE (Expat, 2016 Damian Gryski), geohash/LICENSE (Expat, 2015 Michael McLoughlin), gopher-json/LICENSE (Unlicense), hyperloglog/LICENSE (Expat, 2017 Axiom Inc.).
  • Scan item debian/copyright:67 and gopher-json/LICENSE:5, "...for any purpose, commercial or non-commercial...": this is the Unlicense's permissive grant wording, not a non-commercial restriction. Unlicense is DFSG-free and its full text is in debian/copyright.
  • Scan author check: every holder found is named in debian/copyright; I confirmed all six holders against the shipped LICENSE files, and the only credited-but-unrecorded origin is size/ (reported as an issue).
  • hyperloglog/compressed.go:5 comments "Original author of this file is github.com/clarkduvall/hyperloglog"; that is an attribution remark without a copyright line, and the directory ships Axiom Inc.'s MIT LICENSE, which the stanza matches.
  • fpconv/LICENSE.txt states the Go code derives from redis-7.2.0/deps/fpconv and carries the full Boost 1.0 text; the stanza's holder (Damian Gryski, the translator) matches the only holder statement available.
  • testdata/client.crt, client.key, server.crt, server.key are PEM-format test fixtures generated by the openssl commands in testdata/Makefile, whose source is in the package; they are test data, not built artifacts.
  • No built binaries, minified code, PDFs or other compiled artifacts in the tree; no go:generate/"Code generated by" markers, so no generated source lacks its input. .pc/ and debian/cargo-checksum.json (absent) were passed over.
  • integration/ is package main without any func main() (19 files checked), correctly excluded by DH_GOLANG_EXCLUDES := /integration$; its tests skip themselves without INT=1, and autopkgtest-pkg-go only runs the installed source, which excludes it.
  • Only external import is github.com/yuin/gopher-lua (lua.go, gopher-json/json.go); golang-github-yuin-gopher-lua-dev is in both Build-Depends and the binary package's Depends, and exists in the archive. Integration and root tests import nothing else external.
  • debian/control at compat 14 needs no ${misc:Depends}/${shlibs:Depends} in the arch:all package; dpkg-build-api (= 1) is provided by dpkg-dev 1.23.11, dh-sequence-single-binary is provided by debhelper 14.5 (so --with=single-binary resolves), and the old binary name golang-github-alicebob-miniredis-dev is no longer in the archive, so the -v2-dev name breaks no upgrade path.
  • uscan found the packaged version as the newest upstream release (upstream 2.40.0, packaged 2.40.0).
  • Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (BSL-1.0).
Not confirmed ◂
  • The exact copyright line and licence file of github.com/DmitriyVTitov/size could not be fetched (no network access), so the holder and year for the proposed Files: size/* stanza should be copied from upstream when adding it.
Proposed changes ◂

None.

Uploader's response to the LLM review

Waiting for the uploader's response until , because the review found serious issues.

Back to Dashboard | View all reviews for this package