Review: golang-github-anacrolix-missinggo 2.1.0-8
Package Information
| Description | Stuff that's missing in Go stdlib, or hasn't made it into its own repo. Stuff that supplements Go's stdlib, or isn't significant enough to be in its own repo. This package provides Go source code for the missinggo. |
|---|---|
| Maintainer | Debian Go Packaging Team <team+pkg-go@tracker.debian.org> |
| Changed By | Andrew Lee (李健秋) <ajqlee@debian.org> |
| Sponsor | ajqlee@debian.org |
| Distribution | unstable |
| Architecture | any all |
| VCS | git: https://salsa.debian.org/go-team/packages/golang-github-anacrolix-missinggo.git (browse) |
| Closes | #940286, #1017544, #1146181 |
| Popcon Installs | 14 |
| Binary NEW | Yes (binary-only upload) |
| Tracker | https://tracker.debian.org/pkg/golang-github-anacrolix-missinggo |
| Uploaded | 13 hours ago |
New Package Report
.changes
| Date | Sun, 27 Sep 2026 21:13:14 +0200 |
|---|---|
| Source | golang-github-anacrolix-missinggo |
| Version | 2.1.0-8 |
| Changed-By | Andrew Lee (李健秋) |
| Architecture | source amd64 all |
| Distribution | unstable |
Changelog
golang-github-anacrolix-missinggo (2.1.0-8) unstable; urgency=medium
.
* Team Upload.
.
[ Marcos Talau ]
* debian/salsa-ci.yml: Add to provide CI tests for Salsa
.
[ Andrew Lee (李健秋) ]
* debian/control: align XS-Go-Import-Path.
* debian/control: drop Priority: optional (now the default).
* debian/control: Drop Rules-Requires-Root: no (now the default).
* debian/control: bump to Standards-version to 4.7.4.
* Remove legacy patch. May disable tests in debian/rules with go test
-skip command.
* fix-import-path.patch: align upstream /v2 import path. (Closes: #940286)
* debian/rules: skip specific tests that doesn't work in debian's build
environment. (Closes: #1146181, #1017544)
* debian/control: align -dev binary package and create transitional
dummy package..dsc
| Package-List | golang-github-anacrolix-missinggo-bin-static deb devel optional arch=any golang-github-anacrolix-missinggo-dev deb oldlibs optional arch=all golang-github-anacrolix-missinggo-v2-dev deb devel optional arch=all |
|---|---|
| Section | devel |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: missinggo Source: https://github.com/anacrolix/missinggo Files-Excluded: Godeps/_workspace Files: * Copyright: 2015 Matt Joiner License: MIT Files: debian/* Copyright: 2019 Drew Parsons <dparsons@debian.org> License: MIT Comment: Debian packaging is licensed under the same terms as upstream License: MIT Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Review Information
accepted — allocated to awm 1 hour ago, started 1 hour ago, completed 0 hours ago.
Final Comment
Hi,
I hope the following quality issues are worthwhile...
- Suspicious install entry
debian/golang-github-anacrolix-missinggo-bin-static.install:1 installs usr/bin usr/lib/missinggo. dh-golang only emits /usr/bin binaries; there is no build artifact or upstream install target that produces usr/lib/missinggo. This looks like a stale/incorrect glob that will silently match nothing (or install the wrong thing).
- Inconsistent test-skip story
debian/rules:6-7 skips only TestTimerDrain, yet debian/changelog:16-17 claims to "skip specific tests" closing two bugs (#1146181, #1017544). The skip list and the referenced bugs don't obviously correspond, and it also coexists awkwardly with the retained increase_delayed_test_time.patch (a timing workaround from -7). Worth reconciling.
- Unnecessary shlibs dependency
debian/control:67 puts ${shlibs:Depends} on the bin-static package, but these are statically linked Go binaries (with Built-Using for the toolchain). The libc dependency it injects is generally unwanted.
- Fragile, large import-path patch
debian/patches/fix-import-path.patch (~9 KB) rewrites dozens of internal imports to /v2 because upstream's go.mod declares module github.com/anacrolix/missinggo/v2 while the source still uses unversioned imports. This works (verified the working tree is fully consistent; the pre-patch copies remain only under .pc/), but it's a substantial Debian-side fork of the source that should really be fixed upstream. Also note the patch only touches cmd/filecache; the other cmd/* binaries don't import missinggo, so that's correct.
- Minor
debian/control:28 uses the legacy XS-Go-Import-Path: prefix (modern dh-golang accepts X-Go-Import-Path). The debian/copyright Source:/Upstream-Name fields are fine.
Thanks!